-
Nicolò Pretto authored
* WIP PublicOrCustomEmbedDashboardPage without using dashboard controls * add usePublicDashboardEndpoints instead of WithPublicDashboardEndpoints * fix type error by setting null as default value for hide_parameters and hide_download_button * use usePublicDashboardEndpoints inside WithPublicDashboardEndpoints * also migrate embed * i don't think we need useDashboardNav public/static embed * SetTitle component to use instead of the `title` hoc * wrap setEmbedDashboardEndpoints/setPublicDashboardEndpoints in useEffect as per PR comment * after the fix for metabase#38640 we don't need the public routes in the main app * renamed test file * change tests to use PublicOrEmbeddedDashboardPage * remove PublicOrEmbeddedDashboardControlled and change imports for PublicOrEmbeddedDashboardPage * remove debug prop left by mistake
Nicolò Pretto authored* WIP PublicOrCustomEmbedDashboardPage without using dashboard controls * add usePublicDashboardEndpoints instead of WithPublicDashboardEndpoints * fix type error by setting null as default value for hide_parameters and hide_download_button * use usePublicDashboardEndpoints inside WithPublicDashboardEndpoints * also migrate embed * i don't think we need useDashboardNav public/static embed * SetTitle component to use instead of the `title` hoc * wrap setEmbedDashboardEndpoints/setPublicDashboardEndpoints in useEffect as per PR comment * after the fix for metabase#38640 we don't need the public routes in the main app * renamed test file * change tests to use PublicOrEmbeddedDashboardPage * remove PublicOrEmbeddedDashboardControlled and change imports for PublicOrEmbeddedDashboardPage * remove debug prop left by mistake
Code owners
Assign users and groups as approvers for specific file changes. Learn more.