This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 25, 2024
-
-
Nicolò Pretto authored
* WIP PublicOrCustomEmbedDashboardPage without using dashboard controls * add usePublicDashboardEndpoints instead of WithPublicDashboardEndpoints * fix type error by setting null as default value for hide_parameters and hide_download_button * use usePublicDashboardEndpoints inside WithPublicDashboardEndpoints * also migrate embed * i don't think we need useDashboardNav public/static embed * SetTitle component to use instead of the `title` hoc * wrap setEmbedDashboardEndpoints/setPublicDashboardEndpoints in useEffect as per PR comment * after the fix for metabase#38640 we don't need the public routes in the main app * renamed test file * change tests to use PublicOrEmbeddedDashboardPage * remove PublicOrEmbeddedDashboardControlled and change imports for PublicOrEmbeddedDashboardPage * remove debug prop left by mistake
-
Noah Moss authored
-
Alexander Polyankin authored
* Pass expressionPosition * Add a test * Update e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Rename expressionPosition to expressionIndex --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Add e2e test to verify that step previews only care about the step being previewed * Use getNotebookStep and find preview button using cy.icon * Remove empty line Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Nemanja Glumac authored
-
Uladzimir Havenchyk authored
* Drop old and not used endpoint * fixup! Drop old and not used endpoint * fixup! fixup! Drop old and not used endpoint
-
Mahatthana (Kelvin) Nomsawadi authored
* Make the code makes more sense * Fix type error
-
Nemanja Glumac authored
* Move SimpleSpecificDatePicker to the form * Extract `isSpecificValue` helper * Integrate the toggle into `SimpleDateIntervalPicker` * Make DateOperatorPicker do only one thing Separation of concerns - lift SimpleRelativeDatePicker up to the form. * Fix unit tests * Add back the test for the `SimpleSpecificDatePicker` * Keep the rendering logic in the `SimpleDatePicker`
-
Ryan Laurie authored
-
Phoomparin Mano authored
* apply css variables injection right under the public component * refactor css variables * fix name changes * apply css variables to global styles * update path * render component wrapper as full-width * move style resets to public component styles wrapper * update unit tests for global styles
-
- Jun 24, 2024
-
-
Cal Herries authored
-
adam-james authored
Sanitize SVG before parsing with Batik to prevent render failures when invalid characters are in the SVG content (#44516) * Add Temporal Units List to Dashboard Parameters Schema Closes: #44361 This adds an entry to the Dashboard Parameter schema so that we can validate the list of temporal_units that might be passed from the frontend when adding or updating the `Unit of Time` type parameters. * Sanitize the SVG before parsing it with Batik WIP Fixes: #43677 There are characters that are invalid according to the Batik XML Parser. This sanitizes the svg string to strip out some of those characters so that the render can continue. * Use the xml 1.0 spec allowed unicode chars list for the regex * Remove accidentally merged code * still miseed a line
-
Case Nelson authored
* fix: dont always optimize between expressions Fixes #42291 The frontend produces expressions like ``` [:between [+ [:field ... {:temporal-bucket :day] [:interval 2 :day]] [:relative-datetime -1 :week] [:relative-datetime 0 :week]] ``` This should not be optimized because of the mixed `:day` and `:week` units. However, it was being optimized since the compatible units weren't being properly picked up by the match. * Disable suspcicios args eastwood lint, kondo does it better * Stop autobucket to day when adding a time interval
-
Case Nelson authored
* perf: disable view log and card used updates during metadata fetches * Disable writes for view_count and last_used_at * Disable view_count tests * Disable last-used-at tests * Disable view_count test * Fix view count test * Disable view_count e2e testing
-
Alexander Polyankin authored
-
Alexander Polyankin authored
* Fix the operator list for `type/TextLike` PKs * Fix the bug with using wrong operators * Fix the bug with using wrong operators * Update test/metabase/lib/filter_test.cljc Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> * Test FKs too * Update test/metabase/lib/filter_test.cljc Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> --------- Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
* Get rid of the styled component * Stack date operator on top of actual filter pickers * Use the existing `CurrentDatePicker` * Fix unit test * Conditionally apply padding to the `CurrentDatePicker` * Remove the custom prop
-
Denis Berezin authored
* part 1 * part 1 * part 2 * part 3 * part 4 * Self review * Self review * Fix merge conflicts * Fix e2e * review fixes * review fixes
-
Uladzimir Havenchyk authored
* test: add a test for the edge case in mapping on parameter change * fixup! test: add a test for the edge case in mapping on parameter change
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove `this` reference from the markup * Move functions inline * Introduce a view component making it purer * Introduce question embed view component * Address review: Don't lie about types Co-authored-by:
Nicolò Pretto <info@npretto.com> * Address review: Make code consistent --------- Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Fix the comment * Update the threshold for the front-end
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
* Exrtract 'useResetParameterMapping' * Extract 'DashCardCardParameterMapperButton' * Extract 'DashCardCardParameterMapperContent' * cleanup * Drop if/else * cleanup
-
lbrdnk authored
This PR removes `:role` removal from spec, even if it was added in `:connection-uri`. It seems that `:connection-uri` is ignored on `do-with-connection-options` code path. Hence use of non-default roles is again available on Snowflake.
-
lbrdnk authored
This commit adds `$size` operator wrapping to `$addToSet`. That enables use of `:distinct` clause in expressions on Mongo.
-
Ryan Laurie authored
* fix infinite backport PR recursion * dedupe issue numbers
-
Alexander Solovyov authored
-
Alexander Solovyov authored
This not only does not make sense, but also fails for models with aggregations (and thus not having those fields for filtering available).
-
Ryan Laurie authored
-
- Jun 22, 2024
-
-
Alexander Solovyov authored
-
Uladzimir Havenchyk authored
* refactor: Rework undo to typescript * fixup! refactor: Rework undo to typescript * fixup! fixup! refactor: Rework undo to typescript * Convert UndoListing to ts * fixup! Convert UndoListing to ts * Update frontend/src/metabase/redux/undo.ts Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * address review --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-