Skip to content
Snippets Groups Projects
Unverified Commit 0c90ddfa authored by lbrdnk's avatar lbrdnk Committed by GitHub
Browse files

[Databricks] Use Sparksql formatting in prettify-native-form for Databricks (#49053)

* Format databricks as spark in prettify-native-form

* Add test to be generalized in follow up
parent e99c67a1
No related branches found
No related tags found
No related merge requests found
...@@ -155,6 +155,7 @@ ...@@ -155,6 +155,7 @@
(def dialects (def dialects
"Mapping of dialect kw to dialect, used by sql formatter in [[format-sql]], to dialect." "Mapping of dialect kw to dialect, used by sql formatter in [[format-sql]], to dialect."
{:db2 Dialect/Db2 {:db2 Dialect/Db2
:databricks Dialect/SparkSql
:mariadb Dialect/MariaDb :mariadb Dialect/MariaDb
:mysql Dialect/MySql :mysql Dialect/MySql
:n1ql Dialect/N1ql :n1ql Dialect/N1ql
......
(ns metabase.driver.sql.util-test (ns ^:mb/driver-tests metabase.driver.sql.util-test
(:require (:require
[clojure.string :as str] [clojure.string :as str]
[clojure.test :refer :all] [clojure.test :refer :all]
......
...@@ -8,6 +8,8 @@ ...@@ -8,6 +8,8 @@
[metabase.driver.h2 :as h2] [metabase.driver.h2 :as h2]
[metabase.driver.impl :as driver.impl] [metabase.driver.impl :as driver.impl]
[metabase.plugins.classloader :as classloader] [metabase.plugins.classloader :as classloader]
[metabase.query-processor :as qp]
[metabase.query-processor.compile :as qp.compile]
[metabase.task.sync-databases :as task.sync-databases] [metabase.task.sync-databases :as task.sync-databases]
[metabase.test :as mt] [metabase.test :as mt]
[metabase.test.data.env :as tx.env] [metabase.test.data.env :as tx.env]
...@@ -193,6 +195,15 @@ ...@@ -193,6 +195,15 @@
(is (= query (is (= query
(json/parse-string weird-formatted-query))))))))) (json/parse-string weird-formatted-query)))))))))
(deftest ^:parallel prettify-native-form-executable-test
(mt/test-drivers
(set (filter (partial get-method driver/prettify-native-form) (mt/normal-drivers)))
(is (=? {:status :completed}
(qp/process-query {:database (mt/id)
:type :native
:native (-> (qp.compile/compile (mt/mbql-query orders {:limit 1}))
(update :query (partial driver/prettify-native-form driver/*driver*)))})))))
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;; Begin tests for `describe-*` methods used in sync ;;; Begin tests for `describe-*` methods used in sync
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment