Skip to content
Snippets Groups Projects
Unverified Commit 1b28389c authored by Romeo Van Snick's avatar Romeo Van Snick Committed by GitHub
Browse files

Metrics empty copy (#48449)

* Update copy on metrics page

* Update copy in empty metric builder

* Fix e2e test
parent 77cb69f8
No related branches found
No related tags found
No related merge requests found
...@@ -113,7 +113,7 @@ describe("scenarios > browse > metrics", () => { ...@@ -113,7 +113,7 @@ describe("scenarios > browse > metrics", () => {
cy.visit("/browse/metrics"); cy.visit("/browse/metrics");
main() main()
.findByText( .findByText(
"Metrics help you summarize and analyze your data effortlessly.", "Create Metrics to define the official way to calculate important numbers for your team",
) )
.should("be.visible"); .should("be.visible");
}); });
...@@ -279,7 +279,7 @@ describe("scenarios > browse > metrics", () => { ...@@ -279,7 +279,7 @@ describe("scenarios > browse > metrics", () => {
main() main()
.findByText( .findByText(
"Metrics help you summarize and analyze your data effortlessly.", "Create Metrics to define the official way to calculate important numbers for your team",
) )
.should("be.visible"); .should("be.visible");
......
...@@ -88,9 +88,9 @@ export function BrowseMetrics() { ...@@ -88,9 +88,9 @@ export function BrowseMetrics() {
function MetricsEmptyState() { function MetricsEmptyState() {
return ( return (
<Flex align="center" justify="center" mih="70vh"> <Flex align="center" justify="center" mih="70vh">
<Box maw="25rem"> <Box maw="30rem">
<EmptyState <EmptyState
title={t`Metrics help you summarize and analyze your data effortlessly.`} title={t`Create Metrics to define the official way to calculate important numbers for your team`}
message={ message={
<Text mt="sm" maw="25rem"> <Text mt="sm" maw="25rem">
{t`Metrics are like pre-defined calculations: create your aggregations once, save them as metrics, and use them whenever you need to analyze your data.`} {t`Metrics are like pre-defined calculations: create your aggregations once, save them as metrics, and use them whenever you need to analyze your data.`}
......
...@@ -237,7 +237,7 @@ describe("BrowseMetrics", () => { ...@@ -237,7 +237,7 @@ describe("BrowseMetrics", () => {
setup({ metricCount: 0 }); setup({ metricCount: 0 });
expect( expect(
await screen.findByText( await screen.findByText(
"Metrics help you summarize and analyze your data effortlessly.", "Create Metrics to define the official way to calculate important numbers for your team",
), ),
).toBeInTheDocument(); ).toBeInTheDocument();
}); });
......
...@@ -20,10 +20,10 @@ export function MetricEmptyState({ ...@@ -20,10 +20,10 @@ export function MetricEmptyState({
data-testid="metric-empty-state" data-testid="metric-empty-state"
> >
<Text mb="sm" fw="bold" fz="lg"> <Text mb="sm" fw="bold" fz="lg">
{t`A metric is one of the key numbers you want to keep track of`} {t`Create Metrics to define the official way to calculate important numbers for your team`}
</Text> </Text>
<Text mb="lg" c="text-medium" maw="28.75rem" align="center"> <Text mb="lg" c="text-medium" maw="30rem" align="center">
{t`To create one, you’ll need to define how it’s calculated, add any required filters, and optionally pick the main dimension for your metric.`} {t`Metrics are like pre-defined calculations: create your aggregations once, save them as metrics, and use them whenever you need to analyze your data.`}
</Text> </Text>
{isRunnable && ( {isRunnable && (
<Button variant="filled" onClick={() => runQuestionQuery()}> <Button variant="filled" onClick={() => runQuestionQuery()}>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment