Skip to content
Snippets Groups Projects
Unverified Commit 1d2e85dd authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Move drill thrus to their own namespaces & numerous bug fixes (#33572)

* First crack at drill-thru, adding quick-filter-drill

* Adding object detail drill

Needs tests for the multi-PK case

* Add distribution-drill and foreign-key-drill

* Add sort drill

* summarize-column and part of automatic-insights

* Add `display-info` for drill-thrus and the special pivot functions

Clean up and should be ready for FE first crack

* Add `drill-thru` implementations for all current drills

* small fixes

* overhaul of available-drill-thru

Fixes several issues with targeting, merges in Mode logic, fixes
pivot-drills

Still TODO: other drills' mode conditions; lots of checking and testing
the various cases of what should be shown; writing tests for that.

* Add `display-info` for drill-thrus and the special pivot functions

Clean up and should be ready for FE first crack

* Add `display-info` for drill-thrus and the special pivot functions

Clean up and should be ready for FE first crack

* Integrating the basic drill-thru ops, with some debugging hacks

* Fix bad spelling of parameters

* bunch of a progress, :null sentinel, refactor to context

* tests for lots more cases; two missing drills

* adding underlying records drills, not yet working

* fixing up to work with upstream changes

* fixes from Denis' PR

* more progress debugging FE drills and adding tests

* drill tests coming along

* cleanup, test fixes

* display-info-js for recursion

* Add TS typing for displayInfo of drill thrus

* partial changes for underlying records

* hack hack

* splitting out progression logic to a separate file

* First crack at drill-thru, adding quick-filter-drill

* Adding object detail drill

Needs tests for the multi-PK case

* Add distribution-drill and foreign-key-drill

* Add sort drill

* summarize-column and part of automatic-insights

* Add `display-info` for drill-thrus and the special pivot functions

Clean up and should be ready for FE first crack

* Add `drill-thru` implementations for all current drills

* small fixes

* overhaul of available-drill-thru

Fixes several issues with targeting, merges in Mode logic, fixes
pivot-drills

Still TODO: other drills' mode conditions; lots of checking and testing
the various cases of what should be shown; writing tests for that.

* Add `display-info` for drill-thrus and the special pivot functions

Clean up and should be ready for FE first crack

* Add `display-info` for drill-thrus and the special pivot functions

Clean up and should be ready for FE first crack

* Integrating the basic drill-thru ops, with some debugging hacks

* Fix bad spelling of parameters

* bunch of a progress, :null sentinel, refactor to context

* tests for lots more cases; two missing drills

* adding underlying records drills, not yet working

* fixing up to work with upstream changes

* fixes from Denis' PR

* more progress debugging FE drills and adding tests

* drill tests coming along

* cleanup, test fixes

* display-info-js for recursion

* Add TS typing for displayInfo of drill thrus

* partial changes for underlying records

* hack hack

* splitting out progression logic to a separate file

* Lint and test cleanup

* MLv2 pivot reorganization part 1

* MLv2 pivots reorganization

* Revert some unneeded changes

* Don't enable the histogram test

* Fix lint errors and add a drill-thru-method implementation for sort

* `drill-thru` should support > 3 args

* Fix `mu/defmethod` for Cljs

* Fix reader error in commented-out code :unamused:



* appease Eastwood

---------

Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
parent b8489bd0
No related branches found
No related tags found
No related merge requests found
Showing
with 958 additions and 695 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment