Prevent duplicate connection properties (#18359)

Removing duplicate property declaration from presto-jdbc driver YAML

Add test that executes against all drivers to confirm that no duplicate names come out of connection-properties

Change the way the test runs to avoid needing to initialize test data namespace (to make googleanalytics happy)

Unskip repro Cypress test

frontend/test/metabase/scenarios/admin/databases/add-presto.cy.spec.js

 import { restore, popover } from "__support__/e2e/cypress";
 
-describe.skip("admin > database > add > Presto", () => {
+describe("admin > database > add > Presto", () => {
   beforeEach(() => {
     restore();
     cy.signInAsAdmin();

modules/drivers/presto-jdbc/resources/metabase-plugin.yaml

@@ -30,9 +30,6 @@ driver:
         - password
         - required: false
     - ssl
-    - merge:
-        - additional-options
-        - placeholder: "trustServerCertificate=false"
     - name: kerberos
       type: boolean
       display-name: Authenticate with Kerberos?

test/metabase/driver_test.clj

@@ -2,7 +2,8 @@
   (:require [clojure.test :refer :all]
             [metabase.driver :as driver]
             [metabase.driver.impl :as impl]
-            [metabase.plugins.classloader :as classloader]))
+            [metabase.plugins.classloader :as classloader]
+            [metabase.test.data.env :as tx.env]))
 
 (driver/register! ::test-driver, :abstract? true)
 
@@ -36,3 +37,21 @@
     (is (driver/available? ::test-driver))
     (is (driver/available? "metabase.driver-test/test-driver")
         "`driver/available?` should work for if `driver` is a string -- see #10135")))
+
+(deftest unique-connection-property-test
+  ;; abnormal usage here; we are not using the regular mt/test-driver or mt/test-drivers, because those involve
+  ;; initializing the driver and test data namespaces, which don't necessarily exist for all drivers (ex:
+  ;; googleanalytics), and besides which, we don't actually need sample data or test extensions for this test itself
+
+  ;; so instead, just iterate through all drivers currently set to test by the environment, and check their
+  ;; connection-properties; between all the different CI driver runs, this should cover everything
+  (doseq [d (tx.env/test-drivers)]
+    (testing (str d " has entirely unique connection property names")
+      (let [props         (driver/connection-properties d)
+            props-by-name (group-by :name props)]
+        (is (= (count props) (count props-by-name))
+            (format "Property(s) with duplicate name: %s" (-> (filter (fn [[_ props]]
+                                                                        (> (count props) 1))
+                                                                      props-by-name)
+                                                              vec
+                                                              pr-str)))))))