Skip to content
Snippets Groups Projects
Unverified Commit 2590f778 authored by Noah Moss's avatar Noah Moss Committed by GitHub
Browse files

use lower case email when fetching user from DB (#16091)

parent 250b14de
No related branches found
No related tags found
No related merge requests found
......@@ -94,7 +94,7 @@
(s/defn ^:private fetch-or-create-user!* :- (class User)
[{:keys [first-name last-name email groups]} :- i/UserInfo
{:keys [sync-groups?], :as settings} :- i/LDAPSettings]
(let [user (or (db/select-one [User :id :last_login] :email email)
(let [user (or (db/select-one [User :id :last_login] :email (u/lower-case-en email))
(user/create-new-ldap-auth-user!
{:first_name first-name
:last_name last-name
......
......@@ -564,4 +564,16 @@
(is (schema= SessionResponse
(mt/client :post 200 "session" {:username "sbrown20", :password "1234"})))
(finally
(db/delete! User :email "sally.brown@metabase.com"))))))
(db/delete! User :email "sally.brown@metabase.com"))))
(testing "Test that we can login with LDAP multiple times if the email stored in LDAP contains upper-case
characters (#13739)"
(try
(is (schema=
SessionResponse
(mt/client :post 200 "session" {:username "John.Smith@metabase.com", :password "strongpassword"})))
(is (schema=
SessionResponse
(mt/client :post 200 "session" {:username "John.Smith@metabase.com", :password "strongpassword"})))
(finally
(db/delete! User :email "John.Smith@metabase.com"))))))
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment