Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
26fe0465
Unverified
Commit
26fe0465
authored
6 years ago
by
Cam Saul
Browse files
Options
Downloads
Patches
Plain Diff
Remove unused SparkSQL call to qp.store/table
parent
4753be7c
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/driver/sparksql.clj
+9
-10
9 additions, 10 deletions
src/metabase/driver/sparksql.clj
with
9 additions
and
10 deletions
src/metabase/driver/sparksql.clj
+
9
−
10
View file @
26fe0465
...
...
@@ -65,16 +65,15 @@
:else
field
)))
(
defn-
apply-join-tables
[
honeysql-form
{
join-tables
:join-tables,
source-table-id
:source-table
}]
(
let
[{
source-table-name
:name,
source-schema
:schema
}
(
qp.store/table
source-table-id
)]
(
loop
[
honeysql-form
honeysql-form,
[{
:keys
[
table-name
pk-field
source-field
schema
join-alias
]}
&
more
]
join-tables
]
(
let
[
honeysql-form
(
h/merge-left-join
honeysql-form
[(
hx/qualify-and-escape-dots
schema
table-name
)
(
keyword
join-alias
)]
[
:=
(
hx/qualify-and-escape-dots
source-table-alias
(
:field-name
source-field
))
(
hx/qualify-and-escape-dots
join-alias
(
:field-name
pk-field
))])]
(
if
(
seq
more
)
(
recur
honeysql-form
more
)
honeysql-form
)))))
[
honeysql-form
{
join-tables
:join-tables
}]
(
loop
[
honeysql-form
honeysql-form,
[{
:keys
[
table-name
pk-field
source-field
schema
join-alias
]}
&
more
]
join-tables
]
(
let
[
honeysql-form
(
h/merge-left-join
honeysql-form
[(
hx/qualify-and-escape-dots
schema
table-name
)
(
keyword
join-alias
)]
[
:=
(
hx/qualify-and-escape-dots
source-table-alias
(
:field-name
source-field
))
(
hx/qualify-and-escape-dots
join-alias
(
:field-name
pk-field
))])]
(
if
(
seq
more
)
(
recur
honeysql-form
more
)
honeysql-form
))))
(
defn-
apply-page-using-row-number-for-offset
"Apply `page` clause to HONEYSQL-FROM, using row_number() for drivers that do not support offsets"
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment