Skip to content
Snippets Groups Projects
Commit 2775afa7 authored by Allen Gilliland's avatar Allen Gilliland
Browse files

Merge pull request #1879 from metabase/empty_dashboard_header_fix

fix issue with absolutely positioned empty state messaging
parents c4bc9011 4700c033
No related branches found
No related tags found
No related merge requests found
......@@ -47,12 +47,12 @@ export default class Dashboard extends Component {
<LoadingAndErrorWrapper className="Dashboard full-height" loading={!dashboard} error={error}>
{() =>
<div className="full">
<header className="bg-white border-bottom">
<header className="bg-white border-bottom relative z2">
<DashboardHeader {...this.props} />
</header>
<div className="Dash-wrapper wrapper">
{ dashboard.ordered_cards.length === 0 ?
<div className="absolute top bottom left right flex flex-column layout-centered">
<div className="absolute z1 top bottom left right flex flex-column layout-centered">
<span className="QuestionCircle">?</span>
<div className="text-normal mt3 mb1">This dashboard is looking empty.</div>
<div className="text-normal text-grey-2">Add a question to start making it useful!</div>
......
......@@ -150,7 +150,7 @@ export default class DashboardHeader extends Component {
ref="addQuestionModal"
triggerElement={
<a data-metabase-event="Dashboard;Add Card Modal" title="Add a question to this dashboard">
<Icon className={cx("text-brand-hover", { "Icon--pulse": isEmpty })} name="add" width="16px" height="16px" />
<Icon className={cx("text-brand-hover cursor-pointer", { "Icon--pulse": isEmpty })} name="add" width="16px" height="16px" />
</a>
}
>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment