Skip to content
Snippets Groups Projects
Unverified Commit 2f95ef01 authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Remove unused `GET /api/database/db-ids-with-deprecated-drivers` endpoint (#32710)

parent f83a891e
No related merge requests found
......@@ -340,7 +340,6 @@ export const MetabaseApi = {
db_discard_values: POST("/api/database/:dbId/discard_values"),
db_persist: POST("/api/database/:dbId/persist"),
db_unpersist: POST("/api/database/:dbId/unpersist"),
db_get_db_ids_with_deprecated_drivers: GET("/db-ids-with-deprecated-drivers"),
db_usage_info: GET("/api/database/:dbId/usage_info"),
table_list: GET("/api/table"),
// table_get: GET("/api/table/:tableId"),
......
......@@ -1179,16 +1179,4 @@
[:in :collection_id (api/check-404 (not-empty (t2/select-pks-set Collection :name schema)))])])
(map api.table/card->virtual-table))))
(api/defendpoint GET "/db-ids-with-deprecated-drivers"
"Return a list of database IDs using currently deprecated drivers."
[]
(map
u/the-id
(filter
(fn [database]
(let [info (driver.u/available-drivers-info)
d (driver.u/database->driver database)]
(some? (:superseded-by (d info)))))
(t2/select-pks-set Database))))
(api/define-routes)
......@@ -1512,16 +1512,6 @@
:refresh-token protected-password})))))
(deftest db-ids-with-deprecated-drivers-test
(mt/with-driver :driver-deprecation-test-legacy
(testing "GET /api/database/db-ids-with-deprecated-drivers"
(t2.with-temp/with-temp [Database {db-id :id} {:engine :driver-deprecation-test-legacy}]
(is (not-empty (filter #(= % db-id) (mt/user-http-request
:crowberto
:get
200
"database/db-ids-with-deprecated-drivers"))))))))
(deftest secret-file-paths-returned-by-api-test
(mt/with-driver :secret-test-driver
(testing "File path values for secrets are returned as plaintext in the API (#20030)"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment