Skip to content
Snippets Groups Projects
Commit 4023fed9 authored by Ryan Senior's avatar Ryan Senior
Browse files

Switch alert-test `expect-with-temp` calls to `expect` 

Using `expect-with-temp` rather than `(expect ... (with-temp*` can
obscure some test failures. When using data from the `with-temp*` in
the left side of the `expect` it's needed, but if not, it's better to
nest he `with-temp*` so as to not interfere with the error handling
and test failure reporting.

This commit flips a bunch of the alerts tests that don't need `expect-with-temp`.
parent bf979161
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
test/metabase/api/alert_test.clj
+ 285
− 270
View file @ 4023fed9
......@@ -212,46 +212,48 @@
#"My question")]))
;; Check creation of a below goal alert
(tt/expect-with-temp [Card [card1 {:name "My question"
:display "line"}]]
(expect
(rasta-new-alert-email {"goes below its goal" true})
(with-alert-setup
(et/with-expected-messages 1
((user->client :rasta) :post 200 "alert"
{:card {:id (:id card1)}
:alert_condition "goal"
:alert_above_goal false
:alert_first_only false
:channels [{:enabled true
:channel_type "email"
:schedule_type "daily"
:schedule_hour 12
:schedule_day nil
:recipients []}]}))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"goes below its goal"
#"My question")))
(tt/with-temp* [Card [card1 {:name "My question"
:display "line"}]]
(with-alert-setup
(et/with-expected-messages 1
((user->client :rasta) :post 200 "alert"
{:card {:id (:id card1)}
:alert_condition "goal"
:alert_above_goal false
:alert_first_only false
:channels [{:enabled true
:channel_type "email"
:schedule_type "daily"
:schedule_hour 12
:schedule_day nil
:recipients []}]}))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"goes below its goal"
#"My question"))))
;; Check creation of a above goal alert
(tt/expect-with-temp [Card [card1 {:name "My question"
:display "bar"}]]
(expect
(rasta-new-alert-email {"meets its goal" true})
(with-alert-setup
(et/with-expected-messages 1
((user->client :rasta) :post 200 "alert"
{:card {:id (:id card1)}
:alert_condition "goal"
:alert_above_goal true
:alert_first_only false
:channels [{:enabled true
:channel_type "email"
:schedule_type "daily"
:schedule_hour 12
:schedule_day nil
:recipients []}]}))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"meets its goal"
#"My question")))
(tt/with-temp* [Card [card1 {:name "My question"
:display "bar"}]]
(with-alert-setup
(et/with-expected-messages 1
((user->client :rasta) :post 200 "alert"
{:card {:id (:id card1)}
:alert_condition "goal"
:alert_above_goal true
:alert_first_only false
:channels [{:enabled true
:channel_type "email"
:schedule_type "daily"
:schedule_hour 12
:schedule_day nil
:recipients []}]}))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"meets its goal"
#"My question"))))
;; ## PUT /api/alert
......@@ -412,36 +414,38 @@
#"letting you know that Crowberto Corv")]))
;; Non-admin users can't edit alerts they didn't create
(tt/expect-with-temp [Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
Card [{card-id :id :as card}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [{pcr-id :id} {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(expect
"You don't have permissions to do that."
(with-alert-setup
((alert-client :rasta) :put 403 (format "alert/%d" pulse-id)
(default-alert-req card pc-id))))
(tt/with-temp* [Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
Card [{card-id :id :as card}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [{pcr-id :id} {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(with-alert-setup
((alert-client :rasta) :put 403 (format "alert/%d" pulse-id)
(default-alert-req card pc-id)))))
;; Non-admin users can't edit alerts if they're not in the recipient list
(tt/expect-with-temp [Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
Card [{card-id :id :as card}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [{pcr-id :id} {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(expect
"You don't have permissions to do that."
(with-alert-setup
((alert-client :rasta) :put 403 (format "alert/%d" pulse-id)
(default-alert-req card pc-id))))
(tt/with-temp* [Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
Card [{card-id :id :as card}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [{pcr-id :id} {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(with-alert-setup
((alert-client :rasta) :put 403 (format "alert/%d" pulse-id)
(default-alert-req card pc-id)))))
(defn- basic-alert-query []
{:name "Foo"
......@@ -472,55 +476,57 @@
((alert-client :rasta) :get 200 (format "alert/question/%d" card-id))))
;; Non-admin users shouldn't see alerts they created if they're no longer recipients
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:alert_above_goal true
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [{pcr-id :id} {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(expect
[1 0]
(with-alert-setup
[(count ((alert-client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(db/delete! PulseChannelRecipient :id pcr-id)
(count ((alert-client :rasta) :get 200 (format "alert/question/%d" card-id))))]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:alert_above_goal true
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [{pcr-id :id} {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(count ((alert-client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(db/delete! PulseChannelRecipient :id pcr-id)
(count ((alert-client :rasta) :get 200 (format "alert/question/%d" card-id))))])))
;; Non-admin users should not see others alerts, admins see all alerts
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id-1 :id} {:alert_condition "rows"
:alert_first_only false
:alert_above_goal false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id-1
:card_id card-id
:position 0}]
PulseChannel [{pc-id-1 :id} {:pulse_id pulse-id-1}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id-1}]
;; A separate admin created alert
Pulse [{pulse-id-2 :id} {:alert_condition "rows"
:alert_first_only false
:alert_above_goal false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id-2
:card_id card-id
:position 0}]
PulseChannel [{pc-id-2 :id} {:pulse_id pulse-id-2}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id-2}]
PulseChannel [{pc-id-3 :id} {:pulse_id pulse-id-2
:channel_type "slack"}]]
(expect
[1 2]
(with-alert-setup
[(count ((alert-client :rasta) :get 200 (format "alert/question/%d" card-id)))
(count ((alert-client :crowberto) :get 200 (format "alert/question/%d" card-id)))]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id-1 :id} {:alert_condition "rows"
:alert_first_only false
:alert_above_goal false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id-1
:card_id card-id
:position 0}]
PulseChannel [{pc-id-1 :id} {:pulse_id pulse-id-1}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id-1}]
;; A separate admin created alert
Pulse [{pulse-id-2 :id} {:alert_condition "rows"
:alert_first_only false
:alert_above_goal false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id-2
:card_id card-id
:position 0}]
PulseChannel [{pc-id-2 :id} {:pulse_id pulse-id-2}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id-2}]
PulseChannel [{pc-id-3 :id} {:pulse_id pulse-id-2
:channel_type "slack"}]]
(with-alert-setup
[(count ((alert-client :rasta) :get 200 (format "alert/question/%d" card-id)))
(count ((alert-client :crowberto) :get 200 (format "alert/question/%d" card-id)))])))
(expect
"Admin user are not allowed to unsubscribe from alerts"
......@@ -536,204 +542,213 @@
set))
;; Alert has two recipients, remove one
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(expect
[#{"crowberto@metabase.com" "rasta@metabase.com"}
#{"crowberto@metabase.com"}
(rasta-unsubscribe-email {"Foo" true})]
(with-alert-setup
[(recipient-emails ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(recipient-emails ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(recipient-emails ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(recipient-emails ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")])))
;; Alert should be deleted if the creator unsubscribes and there's no one left
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id
:channel_type :email}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(expect
[1
0
(rasta-unsubscribe-email {"Foo" true})]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id
:channel_type :email}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")])))
;; Alert should not be deleted if there is a slack channel
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id-1 :id} {:pulse_id pulse-id
:channel_type :email}]
PulseChannel [{pc-id-2 :id} {:pulse_id pulse-id
:channel_type :slack}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id-1}]]
(expect
[1
1 ;;<-- Alert should not be deleted
(rasta-unsubscribe-email {"Foo" true})]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id-1 :id} {:pulse_id pulse-id
:channel_type :email}]
PulseChannel [{pc-id-2 :id} {:pulse_id pulse-id
:channel_type :slack}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id-1}]]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")])))
;; Alert should not be deleted if the unsubscriber isn't the creator
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id-1 :id} {:pulse_id pulse-id
:channel_type :email}]
PulseChannel [{pc-id-2 :id} {:pulse_id pulse-id
:channel_type :slack}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id-1}]]
(expect
[1
1 ;<-- Alert should not be deleted
1 ;<-- Alert should not be deleted
(rasta-unsubscribe-email {"Foo" true})]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id-1 :id} {:pulse_id pulse-id
:channel_type :email}]
PulseChannel [{pc-id-2 :id} {:pulse_id pulse-id
:channel_type :slack}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id-1}]]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(do
(et/with-expected-messages 1
((user->client :rasta) :put 204 (format "alert/%d/unsubscribe" pulse-id)))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))))
(et/regex-email-bodies #"https://metabase.com/testmb"
#"Foo")])))
;; Only admins can delete an alert
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(expect
[1 "You don't have permissions to do that."]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
((user->client :rasta) :delete 403 (format "alert/%d" pulse-id))]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
((user->client :rasta) :delete 403 (format "alert/%d" pulse-id))])))
;; Testing a user can't delete an admin's alert
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(expect
[1 nil 0]
(with-alert-setup
(let [original-alert-response ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))]
;; A user can't delete an admin's alert
((user->client :rasta) :delete 403 (format "alert/%d" pulse-id))
[(count original-alert-response)
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id))
(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))])))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(with-alert-setup
(let [original-alert-response ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id))]
;; A user can't delete an admin's alert
((user->client :rasta) :delete 403 (format "alert/%d" pulse-id))
[(count original-alert-response)
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id))
(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))]))))
;; An admin can delete a user's alert
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(expect
[1 nil 0
(rasta-deleted-email {})]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/with-expected-messages 1
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id)))
(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/regex-email-bodies #"Crowberto Corv deleted an alert")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/with-expected-messages 1
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id)))
(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/regex-email-bodies #"Crowberto Corv deleted an alert")])))
;; A deleted alert should notify the creator and any recipients
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]
PulseChannelRecipient [_ {:user_id (user->id :lucky)
:pulse_channel_id pc-id}]]
(expect
[1 nil 0
(merge
(rasta-deleted-email {"Crowberto Corv unsubscribed you from alerts" false})
(et/email-to :lucky {:subject "You’ve been unsubscribed from an alert",
:body {"Crowberto Corv deleted an alert" false
"Crowberto Corv unsubscribed you from alerts" true}}))]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/with-expected-messages 2
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id)))
(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/regex-email-bodies #"Crowberto Corv deleted an alert"
#"Crowberto Corv unsubscribed you from alerts")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :rasta)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :rasta)
:pulse_channel_id pc-id}]
PulseChannelRecipient [_ {:user_id (user->id :lucky)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/with-expected-messages 2
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id)))
(count ((user->client :rasta) :get 200 (format "alert/question/%d" card-id)))
(et/regex-email-bodies #"Crowberto Corv deleted an alert"
#"Crowberto Corv unsubscribed you from alerts")])))
;; When an admin deletes their own alert, it should not notify them
(tt/expect-with-temp [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(expect
[1 nil 0 {}]
(with-alert-setup
[(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id)))
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id)))
(et/regex-email-bodies #".*")]))
(tt/with-temp* [Card [{card-id :id} (basic-alert-query)]
Pulse [{pulse-id :id} {:alert_condition "rows"
:alert_first_only false
:creator_id (user->id :crowberto)}]
PulseCard [_ {:pulse_id pulse-id
:card_id card-id
:position 0}]
PulseChannel [{pc-id :id} {:pulse_id pulse-id}]
PulseChannelRecipient [_ {:user_id (user->id :crowberto)
:pulse_channel_id pc-id}]]
(with-alert-setup
[(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id)))
((user->client :crowberto) :delete 204 (format "alert/%d" pulse-id))
(count ((user->client :crowberto) :get 200 (format "alert/question/%d" card-id)))
(et/regex-email-bodies #".*")])))
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment