Skip to content
Snippets Groups Projects
Unverified Commit 47804c52 authored by Alexander Polyankin's avatar Alexander Polyankin Committed by GitHub
Browse files

Remove metabase/writeback dependency in metabase-lib (#25959)

parent ac324bb6
No related branches found
No related tags found
No related merge requests found
......@@ -3,7 +3,6 @@ import { getIn } from "icepick";
import { parseTimestamp } from "metabase/lib/time";
import { formatDateTimeForParameter } from "metabase/lib/formatting/date";
import { isValidImplicitActionClickBehavior } from "metabase/writeback/utils";
import {
dimensionFilterForParameter,
variableFilterForParameter,
......@@ -231,6 +230,26 @@ export function clickBehaviorIsValid(clickBehavior) {
return false;
}
function isValidImplicitActionClickBehavior(clickBehavior) {
if (
!clickBehavior ||
clickBehavior.type !== "action" ||
!("actionType" in clickBehavior)
) {
return false;
}
if (clickBehavior.actionType === "insert") {
return clickBehavior.tableId != null;
}
if (
clickBehavior.actionType === "update" ||
clickBehavior.actionType === "delete"
) {
return typeof clickBehavior.objectDetailDashCardId === "number";
}
return false;
}
export function formatSourceForTarget(
source,
target,
......
......@@ -87,28 +87,6 @@ export function isMappedExplicitActionButton(
);
}
export function isValidImplicitActionClickBehavior(
clickBehavior?: ClickBehavior,
) {
if (
!clickBehavior ||
clickBehavior.type !== "action" ||
!("actionType" in clickBehavior)
) {
return false;
}
if (clickBehavior.actionType === "insert") {
return clickBehavior.tableId != null;
}
if (
clickBehavior.actionType === "update" ||
clickBehavior.actionType === "delete"
) {
return typeof clickBehavior.objectDetailDashCardId === "number";
}
return false;
}
export function getActionButtonLabel(dashCard: ActionDashboardCard) {
const label = dashCard.visualization_settings?.["button.label"];
return label || "";
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment