Skip to content
Snippets Groups Projects
Commit 4b846646 authored by Paul Rosenzweig's avatar Paul Rosenzweig
Browse files

undefined -> null, you can spread null aparently

parent cfdcb747
Branches
Tags
No related merge requests found
......@@ -6,7 +6,7 @@ import visualizations from "metabase/visualizations";
import SidebarContent from "metabase/query_builder/components/SidebarContent";
export default class ChartSettingsSidebar extends React.Component {
state = { sidebarPropsOverride: undefined };
state = { sidebarPropsOverride: null };
setSidebarPropsOverride = sidebarPropsOverride =>
this.setState({ sidebarPropsOverride });
......@@ -29,7 +29,7 @@ export default class ChartSettingsSidebar extends React.Component {
title={t`${visualizations.get(question.display()).uiName} options`}
onDone={onClose}
onBack={onOpenChartType}
{...sidebarPropsOverride || {}}
{...sidebarPropsOverride}
>
<ChartSettings
question={question}
......
......@@ -53,7 +53,7 @@ class ColumnWidgets extends React.Component {
componentWillUnmount() {
const { setSidebarPropsOverride } = this.props;
if (setSidebarPropsOverride) {
setSidebarPropsOverride(undefined);
setSidebarPropsOverride(null);
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment