Skip to content
Snippets Groups Projects
Unverified Commit 590be772 authored by Ryan Laurie's avatar Ryan Laurie Committed by GitHub
Browse files

Consolidate dashboard e2e specs (#43613) 

* consolidate dashboard e2e specs

* fix import
parent ce5b1cfe
No related branches found
No related tags found
No related merge requests found
Expand all Hide whitespace changes
Inline Side-by-side
Showing
with 1618 additions and 1731 deletions
e2e/test/scenarios/dashboard/caching.cy.spec.js deleted 100644 → 0
+ 0
− 60
View file @ ce5b1cfe
import { ORDERS_DASHBOARD_ID } from "e2e/support/cypress_sample_instance_data";
import {
describeEE,
restore,
rightSidebar,
setTokenFeatures,
toggleDashboardInfoSidebar,
visitDashboard,
} from "e2e/support/helpers";
describeEE("scenarios > dashboard > caching", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
setTokenFeatures("all");
cy.request("PUT", "/api/setting/enable-query-caching", { value: true });
});
/**
* @note There is a similar test for the cache config form that appears in the question sidebar.
* It's in the Cypress describe block labeled "scenarios > question > caching"
*/
it("can configure cache for a dashboard, on an enterprise instance", () => {
cy.intercept("PUT", "/api/cache").as("putCacheConfig");
visitDashboard(ORDERS_DASHBOARD_ID);
toggleDashboardInfoSidebar();
rightSidebar().within(() => {
cy.findByText(/Caching policy/).within(() => {
cy.findByText(/Use default/).click();
});
cy.findByRole("heading", { name: /Caching settings/ }).click();
cy.findByRole("radio", { name: /Duration/ }).click();
cy.findByLabelText("Cache results for this many hours").type("48");
cy.findByRole("button", { name: /Save/ }).click();
cy.wait("@putCacheConfig");
cy.findByText(/Caching policy/).within(() => {
cy.log(
"Check that the newly chosen cache invalidation policy - Duration - is now visible in the sidebar",
);
const durationButton = cy.findByRole("button", { name: /Duration/ });
durationButton.should("be.visible");
cy.log("Open the cache invalidation policy configuration form again");
durationButton.click();
});
cy.findByRole("radio", { name: /Adaptive/ }).click();
cy.findByLabelText(/Minimum query duration/).type("999");
cy.findByRole("button", { name: /Save/ }).click();
cy.wait("@putCacheConfig");
cy.findByText(/Caching policy/).within(() => {
cy.log(
"Check that the newly chosen cache invalidation policy - Adaptive - is now visible in the sidebar",
);
const policyToken = cy.findByRole("button", { name: /Adaptive/ });
policyToken.should("be.visible");
});
});
});
});
e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js 0 → 100644
+ 1401
− 0
View file @ 590be772
This diff is collapsed.
e2e/test/scenarios/dashboard/dashboard.cy.spec.js
+ 217
− 0
View file @ 590be772
import { assoc } from "icepick";
import _ from "underscore";
import { SAMPLE_DB_ID } from "e2e/support/cypress_data";
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
......@@ -46,6 +49,8 @@ import {
setFilter,
commandPaletteButton,
commandPalette,
describeEE,
setTokenFeatures,
} from "e2e/support/helpers";
import { GRID_WIDTH } from "metabase/lib/dashboard_grid";
import {
......@@ -1178,3 +1183,215 @@ function assertScrollBarExists() {
cy.window().its("innerWidth").should("be.gte", bodyWidth);
});
}
describe("LOCAL TESTING ONLY > dashboard", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
/**
* WARNING:
* https://github.com/metabase/metabase/issues/15656
* - We are currently not able to test translations in CI
* - DO NOT unskip this test even after the issue is fixed
* - To be used for local testing only
* - Make sure you have translation resources built first.
* - Run `./bin/i18n/build-translation-resources`
* - Then start the server and Cypress tests
*/
it.skip("dashboard filter should not show placeholder for translated languages (metabase#15694)", () => {
cy.request("GET", "/api/user/current").then(({ body: { id: USER_ID } }) => {
cy.request("PUT", `/api/user/${USER_ID}`, { locale: "fr" });
});
cy.createQuestionAndDashboard({
questionDetails: {
name: "15694",
query: { "source-table": PEOPLE_ID },
},
dashboardDetails: {
parameters: [
{
name: "Location",
slug: "location",
id: "5aefc725",
type: "string/=",
sectionId: "location",
},
],
},
}).then(({ body: { card_id, dashboard_id } }) => {
addOrUpdateDashboardCard({
card_id,
dashboard_id,
card: {
parameter_mappings: [
{
parameter_id: "5aefc725",
card_id,
target: ["dimension", ["field", PEOPLE.STATE, null]],
},
],
},
});
cy.visit(`/dashboard/${dashboard_id}?location=AK&location=CA`);
filterWidget().contains(/\{0\}/).should("not.exist");
});
});
});
describeEE("scenarios > dashboard > caching", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
setTokenFeatures("all");
cy.request("PUT", "/api/setting/enable-query-caching", { value: true });
});
/**
* @note There is a similar test for the cache config form that appears in the question sidebar.
* It's in the Cypress describe block labeled "scenarios > question > caching"
*/
it("can configure cache for a dashboard, on an enterprise instance", () => {
cy.intercept("PUT", "/api/cache").as("putCacheConfig");
visitDashboard(ORDERS_DASHBOARD_ID);
toggleDashboardInfoSidebar();
rightSidebar().within(() => {
cy.findByText(/Caching policy/).within(() => {
cy.findByText(/Use default/).click();
});
cy.findByRole("heading", { name: /Caching settings/ }).click();
cy.findByRole("radio", { name: /Duration/ }).click();
cy.findByLabelText("Cache results for this many hours").type("48");
cy.findByRole("button", { name: /Save/ }).click();
cy.wait("@putCacheConfig");
cy.findByText(/Caching policy/).within(() => {
cy.log(
"Check that the newly chosen cache invalidation policy - Duration - is now visible in the sidebar",
);
const durationButton = cy.findByRole("button", { name: /Duration/ });
durationButton.should("be.visible");
cy.log("Open the cache invalidation policy configuration form again");
durationButton.click();
});
cy.findByRole("radio", { name: /Adaptive/ }).click();
cy.findByLabelText(/Minimum query duration/).type("999");
cy.findByRole("button", { name: /Save/ }).click();
cy.wait("@putCacheConfig");
cy.findByText(/Caching policy/).within(() => {
cy.log(
"Check that the newly chosen cache invalidation policy - Adaptive - is now visible in the sidebar",
);
const policyToken = cy.findByRole("button", { name: /Adaptive/ });
policyToken.should("be.visible");
});
});
});
});
describe("scenarios > dashboard > permissions", () => {
let dashboardId;
beforeEach(() => {
restore();
// This first test creates a dashboard with two questions.
// One is in Our Analytics the other is in a more locked down collection.
cy.signInAsAdmin();
// The setup is a bunch of nested API calls to create the questions, dashboard, dashcards, collections and link them all up together.
let firstQuestionId, secondQuestionId;
cy.request("POST", "/api/collection", {
name: "locked down collection",
parent_id: null,
}).then(({ body: { id: collection_id } }) => {
cy.request("GET", "/api/collection/graph").then(
({ body: { revision, groups } }) => {
// update the perms for the just-created collection
cy.request("PUT", "/api/collection/graph", {
revision,
groups: _.mapObject(groups, (groupPerms, groupId) =>
assoc(
groupPerms,
collection_id,
// 2 is admins, so leave that as "write"
groupId === "2" ? "write" : "none",
),
),
});
},
);
cy.request("POST", "/api/card", {
dataset_query: {
database: SAMPLE_DB_ID,
type: "native",
native: { query: "select 'foo'" },
},
display: "table",
visualization_settings: {},
name: "First Question",
collection_id,
}).then(({ body: { id } }) => (firstQuestionId = id));
cy.request("POST", "/api/card", {
dataset_query: {
database: SAMPLE_DB_ID,
type: "native",
native: { query: "select 'bar'" },
},
display: "table",
visualization_settings: {},
name: "Second Question",
collection_id: null,
}).then(({ body: { id } }) => (secondQuestionId = id));
});
cy.createDashboard().then(({ body: { id: dashId } }) => {
dashboardId = dashId;
updateDashboardCards({
dashboard_id: dashId,
cards: [
{ card_id: firstQuestionId, row: 0, col: 0, size_x: 8, size_y: 6 },
{ card_id: secondQuestionId, row: 0, col: 6, size_x: 8, size_y: 6 },
],
});
});
});
it("should let admins view all cards in a dashboard", () => {
visitDashboard(dashboardId);
// Admin can see both questions
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("First Question");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("foo");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Second Question");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("bar");
});
it("should display dashboards with some cards locked down", () => {
cy.signIn("nodata");
visitDashboard(dashboardId);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Sorry, you don't have permission to see this card.");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Second Question");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("bar");
});
it("should display an error if they don't have perms for the dashboard", () => {
cy.signIn("nocollection");
visitDashboard(dashboardId);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Sorry, you don’t have permission to see that.");
});
});
e2e/test/scenarios/dashboard/dashboard_local-only.cy.spec.js deleted 100644 → 0
+ 0
− 66
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
restore,
filterWidget,
addOrUpdateDashboardCard,
} from "e2e/support/helpers";
const { PEOPLE, PEOPLE_ID } = SAMPLE_DATABASE;
describe("LOCAL TESTING ONLY > dashboard", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
/**
* WARNING:
* https://github.com/metabase/metabase/issues/15656
* - We are currently not able to test translations in CI
* - DO NOT unskip this test even after the issue is fixed
* - To be used for local testing only
* - Make sure you have translation resources built first.
* - Run `./bin/i18n/build-translation-resources`
* - Then start the server and Cypress tests
*/
it.skip("dashboard filter should not show placeholder for translated languages (metabase#15694)", () => {
cy.request("GET", "/api/user/current").then(({ body: { id: USER_ID } }) => {
cy.request("PUT", `/api/user/${USER_ID}`, { locale: "fr" });
});
cy.createQuestionAndDashboard({
questionDetails: {
name: "15694",
query: { "source-table": PEOPLE_ID },
},
dashboardDetails: {
parameters: [
{
name: "Location",
slug: "location",
id: "5aefc725",
type: "string/=",
sectionId: "location",
},
],
},
}).then(({ body: { card_id, dashboard_id } }) => {
addOrUpdateDashboardCard({
card_id,
dashboard_id,
card: {
parameter_mappings: [
{
parameter_id: "5aefc725",
card_id,
target: ["dimension", ["field", PEOPLE.STATE, null]],
},
],
},
});
cy.visit(`/dashboard/${dashboard_id}?location=AK&location=CA`);
filterWidget().contains(/\{0\}/).should("not.exist");
});
});
});
e2e/test/scenarios/dashboard/permissions.cy.spec.js deleted 100644 → 0
+ 0
− 112
View file @ ce5b1cfe
import { assoc } from "icepick";
import _ from "underscore";
import { SAMPLE_DB_ID } from "e2e/support/cypress_data";
import {
updateDashboardCards,
restore,
visitDashboard,
} from "e2e/support/helpers";
describe("scenarios > dashboard > permissions", () => {
let dashboardId;
beforeEach(() => {
restore();
// This first test creates a dashboard with two questions.
// One is in Our Analytics the other is in a more locked down collection.
cy.signInAsAdmin();
// The setup is a bunch of nested API calls to create the questions, dashboard, dashcards, collections and link them all up together.
let firstQuestionId, secondQuestionId;
cy.request("POST", "/api/collection", {
name: "locked down collection",
parent_id: null,
}).then(({ body: { id: collection_id } }) => {
cy.request("GET", "/api/collection/graph").then(
({ body: { revision, groups } }) => {
// update the perms for the just-created collection
cy.request("PUT", "/api/collection/graph", {
revision,
groups: _.mapObject(groups, (groupPerms, groupId) =>
assoc(
groupPerms,
collection_id,
// 2 is admins, so leave that as "write"
groupId === "2" ? "write" : "none",
),
),
});
},
);
cy.request("POST", "/api/card", {
dataset_query: {
database: SAMPLE_DB_ID,
type: "native",
native: { query: "select 'foo'" },
},
display: "table",
visualization_settings: {},
name: "First Question",
collection_id,
}).then(({ body: { id } }) => (firstQuestionId = id));
cy.request("POST", "/api/card", {
dataset_query: {
database: SAMPLE_DB_ID,
type: "native",
native: { query: "select 'bar'" },
},
display: "table",
visualization_settings: {},
name: "Second Question",
collection_id: null,
}).then(({ body: { id } }) => (secondQuestionId = id));
});
cy.createDashboard().then(({ body: { id: dashId } }) => {
dashboardId = dashId;
updateDashboardCards({
dashboard_id: dashId,
cards: [
{ card_id: firstQuestionId, row: 0, col: 0, size_x: 8, size_y: 6 },
{ card_id: secondQuestionId, row: 0, col: 6, size_x: 8, size_y: 6 },
],
});
});
});
it("should let admins view all cards in a dashboard", () => {
visitDashboard(dashboardId);
// Admin can see both questions
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("First Question");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("foo");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Second Question");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("bar");
});
it("should display dashboards with some cards locked down", () => {
cy.signIn("nodata");
visitDashboard(dashboardId);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Sorry, you don't have permission to see this card.");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Second Question");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("bar");
});
it("should display an error if they don't have perms for the dashboard", () => {
cy.signIn("nocollection");
visitDashboard(dashboardId);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Sorry, you don’t have permission to see that.");
});
});
e2e/test/scenarios/dashboard/reproductions/12578-prevent-fetching-slow-cards-more-than-one-at-a-time-when-auto-refreshing.cy.spec.js deleted 100644 → 0
+ 0
− 43
View file @ ce5b1cfe
const { SAMPLE_DATABASE } = require("e2e/support/cypress_sample_database");
const { restore, visitDashboard, popover } = require("e2e/support/helpers");
const { ORDERS_ID } = SAMPLE_DATABASE;
const ORDERS_QUESTION = {
name: "Orders question",
query: {
"source-table": ORDERS_ID,
},
};
describe("issue 12578", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
it("should not fetch cards that are still loading when refreshing", () => {
cy.clock(Date.now());
cy.createQuestionAndDashboard({ questionDetails: ORDERS_QUESTION }).then(
({ body: { dashboard_id } }) => {
visitDashboard(dashboard_id);
},
);
// Without tick the dashboard header will not load
cy.tick();
cy.findByLabelText("Auto Refresh").click();
popover().findByText("1 minute").click();
// Mock slow card request
cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query", req => {
req.on("response", res => {
res.setDelay(99999);
});
}).as("dashcardQuery");
cy.tick(61 * 1000);
cy.tick(61 * 1000);
cy.get("@dashcardQuery.all").should("have.length", 1);
});
});
e2e/test/scenarios/dashboard/reproductions/12926-editing-dashboards-doesnt-cancel-running-queries.cy.spec.js deleted 100644 → 0
+ 0
− 161
View file @ ce5b1cfe
import {
addTextBox,
editDashboard,
getDashboardCard,
openQuestionsSidebar,
popover,
removeDashboardCard,
restore,
saveDashboard,
setFilter,
showDashboardCardActions,
sidebar,
undo,
visitDashboard,
} from "e2e/support/helpers";
const filterDisplayName = "F";
const queryResult = 42;
const parameterValue = 10;
const questionDetails = {
name: "Question 1",
native: {
query: `SELECT ${queryResult} [[+{{F}}]] as ANSWER`,
"template-tags": {
F: {
type: "number",
name: "F",
id: "b22a5ce2-fe1d-44e3-8df4-f8951f7921bc",
"display-name": filterDisplayName,
},
},
},
};
describe("issue 12926", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
describe("card removal while query is in progress", () => {
it("should stop the ongoing query when removing a card from a dashboard", () => {
slowDownDashcardQuery();
cy.createNativeQuestionAndDashboard({
questionDetails,
}).then(({ body: { dashboard_id } }) => {
cy.visit(`/dashboard/${dashboard_id}`);
});
cy.window().then(win => {
cy.spy(win.XMLHttpRequest.prototype, "abort").as("xhrAbort");
});
removeCard();
cy.get("@xhrAbort").should("have.been.calledOnce");
});
it("should re-fetch the query when doing undo on the removal", () => {
slowDownDashcardQuery();
cy.createNativeQuestionAndDashboard({
questionDetails,
}).then(({ body: { dashboard_id } }) => {
cy.visit(`/dashboard/${dashboard_id}`);
});
removeCard();
restoreDashcardQuery();
undo();
cy.wait("@dashcardQueryRestored");
getDashboardCard().findByText(queryResult);
});
it("should not break virtual cards (metabase#35545)", () => {
cy.createDashboard().then(({ body: { id: dashboardId } }) => {
visitDashboard(dashboardId);
});
addTextBox("Text card content");
removeDashboardCard();
undo();
getDashboardCard().findByText("Text card content");
});
});
describe("saving a dashboard that retriggers a non saved query (negative id)", () => {
it("should stop the ongoing query", () => {
// this test requires the card to be manually added to the dashboard, as it requires the dashcard id to be negative
cy.createNativeQuestion(questionDetails);
cy.createDashboard().then(({ body: { id: dashboardId } }) => {
visitDashboard(dashboardId);
});
editDashboard();
openQuestionsSidebar();
// when the card is added to a dashboard, it doesn't use the dashcard endpoint but instead uses the card one
slowDownCardQuery("cardQuerySlowed");
sidebar().findByText(questionDetails.name).click();
setFilter("Number", "Equal to");
sidebar().findByText("No default").click();
popover().findByPlaceholderText("Enter a number").type(parameterValue);
popover().findByText("Add filter").click();
getDashboardCard().findByText("Select…").click();
popover().contains(filterDisplayName).eq(0).click();
saveDashboard();
cy.wait("@cardQuerySlowed").then(xhrProxy =>
expect(xhrProxy.state).to.eq("Errored"),
);
getDashboardCard().findByText(queryResult + parameterValue);
});
});
});
function slowDownCardQuery(as) {
cy.intercept("POST", "/api/card/*/query", req => {
req.on("response", res => {
res.setDelay(300000);
});
}).as(as);
}
function slowDownDashcardQuery() {
cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query", req => {
req.on("response", res => {
res.setDelay(5000);
});
}).as("dashcardQuerySlowed");
}
function restoreDashcardQuery() {
cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query", req => {
// calling req.continue() will make cypress skip all previously added intercepts
req.continue();
}).as("dashcardQueryRestored");
}
function removeCard() {
editDashboard();
showDashboardCardActions();
cy.findByTestId("dashboardcard-actions-panel")
.findByLabelText("close icon")
.click();
}
e2e/test/scenarios/dashboard/reproductions/13736-dashboard-should-work-if-some-cards-are-broken.cy.spec.js deleted 100644 → 0
+ 0
− 79
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
getDashboardCards,
restore,
updateDashboardCards,
visitDashboard,
} from "e2e/support/helpers";
const { ORDERS_ID } = SAMPLE_DATABASE;
const questionDetails = {
name: "Orders count",
query: {
"source-table": ORDERS_ID,
aggregation: [["count"]],
},
};
describe("issue 13736", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
it("should work even if some cards are broken (metabase#13736)", () => {
cy.createQuestion(questionDetails, {
wrapId: true,
idAlias: "failingQuestionId",
});
cy.createQuestion(questionDetails, {
wrapId: true,
idAlias: "successfulQuestionId",
});
cy.createDashboard({ name: "13736 Dashboard" }).then(
({ body: { id: dashboardId } }) => {
cy.wrap(dashboardId).as("dashboardId");
},
);
cy.then(function () {
const dashboardId = this.dashboardId;
const failingQuestionId = this.failingQuestionId;
const successfulQuestionId = this.successfulQuestionId;
cy.intercept(
"POST",
`/api/dashboard/*/dashcard/*/card/${failingQuestionId}/query`,
{
statusCode: 500,
body: {
cause: "some error",
data: {},
message: "some error",
},
},
);
updateDashboardCards({
dashboard_id: dashboardId,
cards: [
{
card_id: failingQuestionId,
},
{
card_id: successfulQuestionId,
col: 11,
},
],
});
visitDashboard(dashboardId);
});
getDashboardCards()
.eq(0)
.findByText("There was a problem displaying this chart.");
getDashboardCards().eq(1).findByText("18,760").should("be.visible");
});
});
e2e/test/scenarios/dashboard/reproductions/16559-show-recent-dashboard-revision.cy.spec.js deleted 100644 → 0
+ 0
− 94
View file @ ce5b1cfe
import {
dashboardHeader,
editDashboard,
openQuestionsSidebar,
popover,
restore,
sidebar,
rightSidebar,
toggleDashboardInfoSidebar,
visitDashboard,
entityPickerModal,
} from "e2e/support/helpers";
const dashboardDetails = {
name: "16559 Dashboard",
};
describe("issue 16559", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
cy.createDashboard(dashboardDetails).then(
({ body: { id: dashboardId } }) => {
visitDashboard(dashboardId);
},
);
});
it("should always show the most recent revision (metabase#16559)", () => {
toggleDashboardInfoSidebar();
cy.log("Dashboard creation");
cy.findByTestId("dashboard-history-list")
.findAllByRole("listitem")
.eq(0)
.findByText("You created this.")
.should("be.visible");
cy.log("Edit dashboard");
editDashboard();
openQuestionsSidebar();
sidebar().findByText("Orders, Count").click();
cy.button("Save").click();
toggleDashboardInfoSidebar();
cy.findByTestId("dashboard-history-list")
.findAllByRole("listitem")
.eq(0)
.findByText("You added a card.")
.should("be.visible");
cy.log("Change dashboard name");
cy.findByTestId("dashboard-name-heading").click().type(" modified").blur();
cy.findByTestId("dashboard-history-list")
.findAllByRole("listitem")
.eq(0)
.findByText(
'You renamed this Dashboard from "16559 Dashboard" to "16559 Dashboard modified".',
)
.should("be.visible");
cy.log("Add description");
cy.findByPlaceholderText("Add description")
.click()
.type("16559 description")
.blur();
cy.findByTestId("dashboard-history-list")
.findAllByRole("listitem")
.eq(0)
.findByText("You added a description.")
.should("be.visible");
cy.log("Toggle auto-apply filters");
rightSidebar().findByText("Auto-apply filters").click();
cy.findByTestId("dashboard-history-list")
.findAllByRole("listitem")
.eq(0)
.findByText("You set auto apply filters to false.")
.should("be.visible");
cy.log("Move dashboard to another collection");
dashboardHeader().icon("ellipsis").click();
popover().findByText("Move").click();
entityPickerModal().within(() => {
cy.findByText("First collection").click();
cy.button("Move").click();
});
cy.findByTestId("dashboard-history-list")
.findAllByRole("listitem")
.eq(0)
.findByText("You moved this Dashboard to First collection.")
.should("be.visible");
});
});
e2e/test/scenarios/dashboard/reproductions/17879-date-parameter-mapping.cy.spec.js deleted 100644 → 0
+ 0
− 132
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
editDashboard,
cartesianChartCircle,
popover,
restore,
saveDashboard,
showDashboardCardActions,
visitDashboard,
} from "e2e/support/helpers";
const { ORDERS_ID, ORDERS } = SAMPLE_DATABASE;
describe("issue 17879", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query").as(
"dashcardQuery",
);
});
it("should map dashcard date parameter to correct date range filter in target question - month -> day (metabase#17879)", () => {
setupDashcardAndDrillToQuestion({
sourceDateUnit: "month",
expectedFilterText: "Created At is Apr 1–30, 2022",
});
});
it("should map dashcard date parameter to correct date range filter in target question - week -> day (metabase#17879)", () => {
setupDashcardAndDrillToQuestion({
sourceDateUnit: "week",
expectedFilterText: "Created At is Apr 24–30, 2022",
});
});
it("should map dashcard date parameter to correct date range filter in target question - year -> day (metabase#17879)", () => {
setupDashcardAndDrillToQuestion({
sourceDateUnit: "year",
expectedFilterText: "Created At is Jan 1 – Dec 31, 2022",
});
});
it("should map dashcard date parameter to correct date range filter in target question - year -> month (metabase#17879)", () => {
setupDashcardAndDrillToQuestion({
sourceDateUnit: "year",
expectedFilterText: "Created At is Jan 1 – Dec 31, 2022",
targetDateUnit: "month",
});
});
});
function setupDashcardAndDrillToQuestion({
sourceDateUnit,
expectedFilterText,
targetDateUnit = "default",
}) {
if (targetDateUnit === "default") {
cy.createQuestion({
name: "Q1 - 17879",
query: {
"source-table": ORDERS_ID,
limit: 5,
},
});
} else {
cy.createQuestion({
name: "Q1 - 17879",
query: {
"source-table": ORDERS_ID,
aggregation: [["count"]],
breakout: [
["field", ORDERS.CREATED_AT, { "temporal-unit": targetDateUnit }],
],
limit: 5,
},
});
}
cy.createDashboardWithQuestions({
dashboardName: "Dashboard with aggregated Q2",
questions: [
{
name: "Q2",
display: "line",
query: {
"source-table": ORDERS_ID,
aggregation: [["count"]],
breakout: [
["field", ORDERS.CREATED_AT, { "temporal-unit": sourceDateUnit }],
],
limit: 5,
},
},
],
}).then(({ dashboard }) => {
cy.intercept(
"POST",
`/api/dashboard/${dashboard.id}/dashcard/*/card/*/query`,
).as("getCardQuery");
visitDashboard(dashboard.id);
editDashboard(dashboard.id);
showDashboardCardActions();
cy.findByTestId("dashboardcard-actions-panel").icon("click").click();
cy.findByText("Go to a custom destination").click();
cy.findByText("Saved question").click();
cy.findByText("Q1 - 17879").click();
cy.findByText("Created At").click();
popover().within(() => {
cy.findByText("Created At").click();
});
cy.findByText("Done").click();
saveDashboard();
cy.wait("@getCardQuery");
cy.findByTestId("visualization-root").within(() => {
cartesianChartCircle().first().click({ force: true });
});
cy.url().should("include", "/question");
cy.findByTestId("qb-filters-panel").should("have.text", expectedFilterText);
});
}
e2e/test/scenarios/dashboard/reproductions/21830-slow-loading-card-viz-options-error.cy.spec.js deleted 100644 → 0
+ 0
− 52
View file @ ce5b1cfe
import { ORDERS_DASHBOARD_ID } from "e2e/support/cypress_sample_instance_data";
import {
editDashboard,
getDashboardCard,
restore,
showDashboardCardActions,
} from "e2e/support/helpers";
describe("issue 21830", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
it("slow loading card visualization options click shouldn't lead to error (metabase#21830)", () => {
cy.intercept("GET", "/api/dashboard/*").as("getDashboard");
cy.intercept(
{
method: "POST",
url: "/api/dashboard/*/dashcard/*/card/*/query",
middleware: true,
},
req => {
req.on("response", res => {
// throttle the response to simulate a mobile 3G connection
res.setThrottle(100);
});
},
).as("getCardQuery");
cy.visit(`/dashboard/${ORDERS_DASHBOARD_ID}`);
cy.wait("@getDashboard");
// it's crucial that we try to click on this icon BEFORE we wait for the `getCardQuery` response!
editDashboard();
showDashboardCardActions();
getDashboardCard().within(() => {
cy.icon("close").should("be.visible");
cy.icon("click").should("not.exist");
cy.icon("palette").should("not.exist");
});
cy.wait("@getCardQuery");
getDashboardCard().within(() => {
cy.icon("close").should("be.visible");
cy.icon("click").should("be.visible");
cy.icon("palette").should("be.visible");
});
});
});
e2e/test/scenarios/dashboard/reproductions/28756-toast-to-enable-notifications-when-no-permissions.cy.spec.js deleted 100644 → 0
+ 0
− 77
View file @ ce5b1cfe
import { assoc } from "icepick";
import _ from "underscore";
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import { restore, undoToast, visitDashboard } from "e2e/support/helpers";
import { DASHBOARD_SLOW_TIMEOUT } from "metabase/dashboard/constants";
const { PRODUCTS_ID } = SAMPLE_DATABASE;
const UNRESTRICTED_COLLECTION_NAME = "Unrestricted collection";
const RESTRICTED_COLLECTION_NAME = "Restricted collection";
const ADMIN_GROUP_ID = "2";
const TOAST_TIMEOUT_SAFETY_MARGIN = 1000;
const TOAST_TIMEOUT = DASHBOARD_SLOW_TIMEOUT + TOAST_TIMEOUT_SAFETY_MARGIN;
const TOAST_MESSAGE =
"Would you like to be notified when this dashboard is done loading?";
describe("issue 28756", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
cy.createCollection({ name: RESTRICTED_COLLECTION_NAME }).then(
({ body: restrictedCollection }) => {
restrictCollectionForNonAdmins(restrictedCollection.id);
cy.createCollection({ name: UNRESTRICTED_COLLECTION_NAME }).then(
({ body: unrestrictedCollection }) => {
cy.createQuestionAndDashboard({
dashboardDetails: {
collection_id: unrestrictedCollection.id,
},
questionDetails: {
name: "28756 Question",
query: {
"source-table": PRODUCTS_ID,
},
collection_id: restrictedCollection.id,
},
}).then(({ body: { dashboard_id } }) => {
cy.wrap(dashboard_id).as("dashboardId");
});
},
);
},
);
});
it("should not show a toast to enable notifications to user with no permissions to see the card (metabase#28756)", () => {
cy.signInAsNormalUser();
cy.clock();
cy.get("@dashboardId").then(dashboardId => {
visitDashboard(dashboardId);
cy.tick(TOAST_TIMEOUT);
undoToast().should("not.exist");
cy.findByText(TOAST_MESSAGE).should("not.exist");
});
});
});
function restrictCollectionForNonAdmins(collectionId) {
cy.request("GET", "/api/collection/graph").then(
({ body: { revision, groups } }) => {
cy.request("PUT", "/api/collection/graph", {
revision,
groups: _.mapObject(groups, (groupPermissions, groupId) => {
const permission = groupId === ADMIN_GROUP_ID ? "write" : "none";
return assoc(groupPermissions, collectionId, permission);
}),
});
},
);
}
e2e/test/scenarios/dashboard/reproductions/29076-dashboard-card-drill-sandbox.cy.spec.js deleted 100644 → 0
+ 0
− 54
View file @ ce5b1cfe
import { USER_GROUPS, SAMPLE_DB_ID } from "e2e/support/cypress_data";
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import { ORDERS_DASHBOARD_ID } from "e2e/support/cypress_sample_instance_data";
const { ALL_USERS_GROUP, COLLECTION_GROUP } = USER_GROUPS;
import {
describeEE,
restore,
visitDashboard,
setTokenFeatures,
} from "e2e/support/helpers";
const { PRODUCTS_ID, PRODUCTS } = SAMPLE_DATABASE;
describeEE("issue 29076", () => {
beforeEach(() => {
restore("default-ee");
cy.intercept("/api/dashboard/*/dashcard/*/card/*/query").as("cardQuery");
cy.signInAsAdmin();
setTokenFeatures("all");
cy.updatePermissionsGraph({
[ALL_USERS_GROUP]: {
[SAMPLE_DB_ID]: {
"view-data": "blocked",
"create-queries": "no",
},
},
[COLLECTION_GROUP]: {
[SAMPLE_DB_ID]: {
"view-data": "unrestricted",
"create-queries": "query-builder",
},
},
});
cy.sandboxTable({
table_id: PRODUCTS_ID,
attribute_remappings: {
attr_uid: ["dimension", ["field", PRODUCTS.ID, null]],
},
});
cy.signInAsSandboxedUser();
});
it("should be able to drilldown to a saved question in a dashboard with sandboxing (metabase#29076)", () => {
visitDashboard(ORDERS_DASHBOARD_ID);
cy.wait("@cardQuery");
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Orders").click();
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Visualization").should("be.visible");
});
});
e2e/test/scenarios/dashboard/reproductions/31274-dashcard-actions-overlap.cy.spec.js deleted 100644 → 0
+ 0
− 81
View file @ ce5b1cfe
import {
editDashboard,
restore,
visitDashboard,
getTextCardDetails,
} from "e2e/support/helpers";
const createTextCards = length => {
return Array.from({ length }).map((_, index) => {
return getTextCardDetails({
size_x: 2,
size_y: 2,
row: (length - index - 1) * 2,
text: `Text card ${index + 1}`,
});
});
};
describe("issue 31274", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
// cypress automatically scrolls to the element, but we don't need it in this test
it("should not clip dashcard actions (metabase#31274)", () => {
cy.createDashboard().then(({ body: dashboard }) => {
const dashcards = createTextCards(3);
cy.request("PUT", `/api/dashboard/${dashboard.id}`, {
dashcards,
});
visitDashboard(dashboard.id);
editDashboard(dashboard.id);
secondTextCard().realHover();
visibleActionsPanel().should("have.length", 1);
cy.log(
"Make sure cypress can click the element, which means it is not covered by another",
);
visibleActionsPanel().within(() => {
cy.icon("close").click({
position: "top",
});
});
cy.findAllByTestId("dashcard").should("have.length", 2);
});
});
it("renders cross icon on the link card without clipping", () => {
cy.createDashboard().then(({ body: dashboard }) => {
visitDashboard(dashboard.id);
editDashboard(dashboard.id);
});
cy.icon("link").click();
cy.findByPlaceholderText("https://example.com").realHover();
cy.log(
"Make sure cypress can click the element, which means it is not covered by another",
);
cy.findByTestId("dashboardcard-actions-panel").within(() => {
cy.icon("close").click({ position: "bottom" });
});
cy.findByTestId("dashcard").should("not.exist");
});
});
function visibleActionsPanel() {
return cy.findAllByTestId("dashboardcard-actions-panel").filter(":visible");
}
function secondTextCard() {
return cy.findAllByTestId("editing-dashboard-text-preview").eq(1).parent();
}
e2e/test/scenarios/dashboard/reproductions/31697-question-xray-segment.cy.spec.js deleted 100644 → 0
+ 0
− 58
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
cartesianChartCircle,
popover,
restore,
visitQuestion,
} from "e2e/support/helpers";
import { createSegment } from "e2e/support/helpers/e2e-table-metadata-helpers";
const { ORDERS_ID, ORDERS } = SAMPLE_DATABASE;
const segmentDetails = {
name: "Orders segment",
description: "All orders with a total under $100.",
table_id: ORDERS_ID,
definition: {
"source-table": ORDERS_ID,
aggregation: [["count"]],
filter: ["<", ["field", ORDERS.TOTAL, null], 100],
},
};
const getQuestionDetails = segment => ({
display: "line",
query: {
"source-table": ORDERS_ID,
filter: ["segment", segment.id],
aggregation: [["count"]],
breakout: [["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }]],
},
visualization_settings: {
"graph.metrics": ["count"],
"graph.dimensions": ["CREATED_AT"],
},
});
describe("issue 31697", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
createSegment(segmentDetails).then(({ body: segment }) => {
cy.createQuestion(getQuestionDetails(segment), { wrapId: true });
});
cy.intercept("GET", "/api/automagic-dashboards/**").as("xrayDashboard");
});
it("should allow x-rays for questions with segments (metabase#31697)", () => {
cy.get("@questionId").then(visitQuestion);
cartesianChartCircle().eq(0).click();
popover().findByText("Automatic insights…").click();
popover().findByText("X-ray").click();
cy.wait("@xrayDashboard");
cy.findByRole("main").within(() => {
cy.findByText(/A closer look at number of Orders/).should("be.visible");
});
});
});
e2e/test/scenarios/dashboard/reproductions/31766-corrupted-dashcards-after-save.cy.spec.js deleted 100644 → 0
+ 0
− 85
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
editDashboard,
modal,
restore,
visitDashboard,
getTextCardDetails,
updateDashboardCards,
saveDashboard,
} from "e2e/support/helpers";
const { ORDERS_ID } = SAMPLE_DATABASE;
describe("issue 31766", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
it("should not corrupt dashboard data (metabase#31766)", () => {
const questionDetails = {
name: "Orders",
query: { "source-table": ORDERS_ID, limit: 5 },
};
const dashboardDetails = { name: "Orders in a dashboard" };
cy.createQuestionAndDashboard({
questionDetails,
dashboardDetails,
cardDetails: { size_x: 16, size_y: 8 },
}).then(({ body: { dashboard_id, question_id, id: dashcard_id } }) => {
const textCard = getTextCardDetails({
row: 0,
size_x: 24,
size_y: 1,
text: "top",
});
const questionCard = {
row: 2,
size_x: 16,
size_y: 6,
id: dashcard_id,
card_id: question_id,
};
updateDashboardCards({ dashboard_id, cards: [textCard, questionCard] });
visitDashboard(dashboard_id);
editDashboard(dashboard_id);
});
// update text card
cy.findByTestId("editing-dashboard-text-preview").type(1);
saveDashboard();
// visit question
cy.findAllByTestId("dashcard").eq(1).findByText("Orders").click();
cy.log("Update viz settings");
cy.findByTestId("view-footer")
.findByRole("button", { name: "Visualization" })
.click();
cy.findByTestId("Detail-button").click();
saveUpdatedQuestion();
assertQuestionIsUpdatedWithoutError();
});
});
function saveUpdatedQuestion() {
cy.intercept("PUT", "/api/card/*").as("updateQuestion");
cy.findByText("Save").click();
cy.findByTestId("save-question-modal").within(modal => {
cy.findByText("Save").click();
});
}
function assertQuestionIsUpdatedWithoutError() {
cy.wait("@updateQuestion");
modal().should("not.exist");
}
e2e/test/scenarios/dashboard/reproductions/34382-dashboard-back-navigation-preserve-filters.cy.spec.js deleted 100644 → 0
+ 0
− 124
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
dashboardParametersContainer,
getDashboardCard,
restore,
visitDashboard,
filterWidget,
queryBuilderHeader,
popover,
} from "e2e/support/helpers";
const { PRODUCTS, PRODUCTS_ID } = SAMPLE_DATABASE;
describe("issue 34382", () => {
beforeEach(() => {
restore();
cy.signInAsNormalUser();
cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query").as(
"dashcardQuery",
);
});
it("should preserve filter value when navigating between the dashboard and the query builder with auto-apply disabled (metabase#34382)", () => {
createDashboardWithCards();
visitDashboard("@dashboardId");
addFilterValue("Gizmo");
applyFilter();
cy.log("Navigate to Products question");
getDashboardCard().findByText("Products").click();
cy.log("Navigate back to dashboard");
queryBuilderHeader()
.findByLabelText("Back to Products in a dashboard")
.click();
cy.location("search").should("eq", "?category=Gizmo");
filterWidget().contains("Gizmo");
getDashboardCard().within(() => {
// only products with category "Gizmo" are filtered
cy.findAllByTestId("table-row")
.find("td")
.eq(3)
.should("contain", "Gizmo");
});
});
});
const createDashboardWithCards = () => {
const getParameterMapping = ({ card_id }, parameters) => ({
parameter_mappings: parameters.map(parameter => ({
card_id,
parameter_id: parameter.id,
target: ["dimension", ["field", PRODUCTS.CATEGORY, null]],
})),
});
const questionDetails = {
name: "Products",
query: { "source-table": PRODUCTS_ID },
};
const questionDashcardDetails = {
row: 0,
col: 0,
size_x: 8,
size_y: 8,
visualization_settings: {},
};
const filterDetails = {
name: "Product Category",
slug: "category",
id: "96917421",
type: "category",
};
const dashboardDetails = {
name: "Products in a dashboard",
auto_apply_filters: false,
parameters: [filterDetails],
};
cy.createDashboard(dashboardDetails).then(
({ body: { id: dashboard_id } }) => {
cy.createQuestion(questionDetails).then(
({ body: { id: question_id } }) => {
cy.request("PUT", `/api/dashboard/${dashboard_id}`, {
dashcards: [
{
id: -1,
card_id: question_id,
...questionDashcardDetails,
...getParameterMapping({ card_id: question_id }, [
filterDetails,
]),
},
],
});
},
);
cy.wrap(dashboard_id).as("dashboardId");
},
);
};
function addFilterValue(value) {
filterWidget().click();
popover().within(() => {
cy.findByText(value).click();
cy.findByRole("button", { name: "Add filter" }).click();
});
}
function applyFilter() {
dashboardParametersContainer()
.findByRole("button", { name: "Apply" })
.click();
cy.wait("@dashcardQuery");
}
e2e/test/scenarios/dashboard/reproductions/35037-recently-viewed-link-editing-dashboard-link-card.cy.spec.js deleted 100644 → 0
+ 0
− 69
View file @ ce5b1cfe
import { ORDERS_DASHBOARD_ID } from "e2e/support/cypress_sample_instance_data";
import { editDashboard, restore, visitDashboard } from "e2e/support/helpers";
const TEST_DASHBOARD_NAME = "Orders in a dashboard";
const TEST_QUESTION_NAME = "Question#35037";
describe("should not redirect users to other pages when linking an entity (metabase#35037)", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
cy.intercept("GET", "/api/search?q=*").as("search");
cy.intercept("GET", "/api/activity/recent_views").as("recentViews");
});
it("should not redirect users to recent item", () => {
visitDashboard(ORDERS_DASHBOARD_ID);
editDashboard();
cy.url().then(url => {
cy.wrap(url).as("originUrl");
});
cy.icon("link").click();
cy.wait("@recentViews");
cy.findByTestId("recents-list-container").within(() => {
cy.findByText(TEST_DASHBOARD_NAME).click();
});
cy.url().then(currentURL => {
cy.get("@originUrl").should("eq", currentURL);
});
cy.findByTestId("recents-list-container").should("not.exist");
cy.findByTestId("entity-edit-display-link")
.findByText(TEST_DASHBOARD_NAME)
.should("exist");
});
it("should not redirect users to search item", () => {
cy.createNativeQuestion({
name: TEST_QUESTION_NAME,
native: { query: "SELECT 1" },
});
visitDashboard(ORDERS_DASHBOARD_ID);
editDashboard();
cy.url().then(url => {
cy.wrap(url).as("originUrl");
});
cy.icon("link").click();
cy.findByTestId("custom-edit-text-link").type(TEST_QUESTION_NAME);
cy.findByTestId("search-results-list").within(() => {
cy.findByText(TEST_QUESTION_NAME).click();
});
cy.url().then(currentURL => {
cy.get("@originUrl").should("eq", currentURL);
});
cy.findByTestId("search-results-list").should("not.exist");
cy.findByTestId("entity-edit-display-link")
.findByText(TEST_QUESTION_NAME)
.should("exist");
});
});
e2e/test/scenarios/dashboard/reproductions/39863-redundant-queries-on-tab-change.cy.spec.js deleted 100644 → 0
+ 0
− 324
View file @ ce5b1cfe
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import { ORDERS_QUESTION_ID } from "e2e/support/cypress_sample_instance_data";
import {
createDashboardWithTabs,
dashboardGrid,
goToTab,
popover,
restore,
visitDashboard,
} from "e2e/support/helpers";
import { createMockDashboardCard } from "metabase-types/api/mocks";
const { ORDERS } = SAMPLE_DATABASE;
const TAB_1 = { id: 1, name: "Tab 1" };
const TAB_2 = { id: 2, name: "Tab 2" };
const DATE_FILTER = {
id: "2",
name: "Date filter",
slug: "filter-date",
type: "date/all-options",
};
const CREATED_AT_FIELD_REF = [
"field",
ORDERS.CREATED_AT,
{ "base-type": "type/DateTime" },
];
const COMMON_DASHCARD_INFO = {
card_id: ORDERS_QUESTION_ID,
parameter_mappings: [
{
parameter_id: DATE_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", CREATED_AT_FIELD_REF],
},
],
size_x: 10,
size_y: 4,
};
const ID_FILTER = {
id: "3",
name: "ID filter",
slug: "filter-id",
type: "id",
};
const USER_ID_FILTER = {
id: "4",
name: "User ID filter",
slug: "filter-user-id",
type: "id",
};
const PRODUCT_ID_FILTER = {
id: "5",
name: "Product ID filter",
slug: "filter-product-id",
type: "id",
};
const SUBTOTAL_FILTER = {
id: "6",
name: "Subtotal filter",
slug: "filter-subtotal",
type: "number/<=",
};
const TOTAL_FILTER = {
id: "7",
name: "Total filter",
slug: "filter-total",
type: "number/<=",
};
const TAX_FILTER = {
id: "8",
name: "Tax filter",
slug: "filter-tax",
type: "number/<=",
};
const DISCOUNT_FILTER = {
id: "9",
name: "Discount filter",
slug: "filter-discount",
type: "number/<=",
};
const QUANTITY_FILTER = {
id: "10",
name: "Quantity filter",
slug: "filter-quantity",
type: "number/<=",
};
const ID_FIELD_REF = ["field", ORDERS.ID, { "base-type": "type/BigInteger" }];
const USER_ID_FIELD_REF = [
"field",
ORDERS.USER_ID,
{ "base-type": "type/BigInteger" },
];
const PRODUCT_ID_FIELD_REF = [
"field",
ORDERS.PRODUCT_ID,
{ "base-type": "type/BigInteger" },
];
const SUBTOTAL_FIELD_REF = [
"field",
ORDERS.SUBTOTAL,
{ "base-type": "type/Float" },
];
const TOTAL_FIELD_REF = ["field", ORDERS.TOTAL, { "base-type": "type/Float" }];
const TAX_FIELD_REF = ["field", ORDERS.TAX, { "base-type": "type/Float" }];
const DISCOUNT_FIELD_REF = [
"field",
ORDERS.DISCOUNT,
{ "base-type": "type/Float" },
];
const QUANTITY_FIELD_REF = [
"field",
ORDERS.QUANTITY,
{ "base-type": "type/Number" },
];
const DASHCARD_WITH_9_FILTERS = {
card_id: ORDERS_QUESTION_ID,
parameter_mappings: [
{
parameter_id: DATE_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", CREATED_AT_FIELD_REF],
},
{
parameter_id: ID_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", ID_FIELD_REF],
},
{
parameter_id: USER_ID_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", USER_ID_FIELD_REF],
},
{
parameter_id: PRODUCT_ID_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", PRODUCT_ID_FIELD_REF],
},
{
parameter_id: SUBTOTAL_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", SUBTOTAL_FIELD_REF],
},
{
parameter_id: TOTAL_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", TOTAL_FIELD_REF],
},
{
parameter_id: TAX_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", TAX_FIELD_REF],
},
{
parameter_id: DISCOUNT_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", DISCOUNT_FIELD_REF],
},
{
parameter_id: QUANTITY_FILTER.id,
card_id: ORDERS_QUESTION_ID,
target: ["dimension", QUANTITY_FIELD_REF],
},
],
size_x: 10,
size_y: 4,
};
describe("issue 39863", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query").as(
"dashcardQuery",
);
});
it("should not rerun queries when switching tabs and there are no parameter changes", () => {
createDashboardWithTabs({
tabs: [TAB_1, TAB_2],
parameters: [DATE_FILTER],
dashcards: [
createMockDashboardCard({
...COMMON_DASHCARD_INFO,
id: -1,
dashboard_tab_id: TAB_1.id,
}),
createMockDashboardCard({
...COMMON_DASHCARD_INFO,
id: -2,
dashboard_tab_id: TAB_2.id,
}),
],
}).then(dashboard => visitDashboard(dashboard.id));
// Initial query for 1st tab
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 1);
// Initial query for 2nd tab
goToTab(TAB_2.name);
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 2);
// No parameters change, no query rerun
goToTab(TAB_1.name);
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 2);
// Rerun 1st tab query with new parameters
setDateFilter();
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 3);
// Rerun 2nd tab query with new parameters
goToTab(TAB_2.name);
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 4);
// No parameters change, no query rerun
goToTab(TAB_1.name);
goToTab(TAB_2.name);
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 4);
});
it("should not rerun queries just because there are 9 or more attached filters to a dash-card", () => {
createDashboardWithTabs({
tabs: [TAB_1, TAB_2],
parameters: [
DATE_FILTER,
ID_FILTER,
USER_ID_FILTER,
PRODUCT_ID_FILTER,
SUBTOTAL_FILTER,
TOTAL_FILTER,
TAX_FILTER,
DISCOUNT_FILTER,
QUANTITY_FILTER,
],
dashcards: [
createMockDashboardCard({
...DASHCARD_WITH_9_FILTERS,
id: -1,
dashboard_tab_id: TAB_1.id,
}),
createMockDashboardCard({
...DASHCARD_WITH_9_FILTERS,
id: -2,
dashboard_tab_id: TAB_2.id,
}),
],
}).then(dashboard => visitDashboard(dashboard.id));
// Initial query for 1st tab
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 1);
// Initial query for 2nd tab
goToTab(TAB_2.name);
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 2);
// No parameters change, no query rerun
goToTab(TAB_1.name);
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 2);
// Rerun 1st tab query with new parameters
setDateFilter();
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 3);
// Rerun 2nd tab query with new parameters
goToTab(TAB_2.name);
cy.wait("@dashcardQuery");
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 4);
// No parameters change, no query rerun
goToTab(TAB_1.name);
goToTab(TAB_2.name);
assertNoLoadingSpinners();
cy.get("@dashcardQuery.all").should("have.length", 4);
});
});
function setDateFilter() {
cy.findByLabelText("Date filter").click();
popover()
.findByText(/Last 12 months/i)
.click();
}
function assertNoLoadingSpinners() {
dashboardGrid().findAllByTestId("loading-spinner").should("have.length", 0);
}
e2e/test/scenarios/dashboard/reproductions/40695-tab-dashcards-display.cy.spec.js deleted 100644 → 0
+ 0
− 60
View file @ ce5b1cfe
import {
ORDERS_COUNT_QUESTION_ID,
ORDERS_QUESTION_ID,
} from "e2e/support/cypress_sample_instance_data";
import {
createDashboardWithTabs,
dashboardGrid,
editDashboard,
getDashboardCards,
restore,
visitDashboard,
} from "e2e/support/helpers";
import { createMockDashboardCard } from "metabase-types/api/mocks";
const TAB_1 = {
id: 1,
name: "Tab 1",
};
const TAB_2 = {
id: 2,
name: "Tab 2",
};
describe("issue 40695", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
});
it("should not show dashcards from other tabs after entering and leaving editing mode", () => {
createDashboardWithTabs({
tabs: [TAB_1, TAB_2],
dashcards: [
createMockDashboardCard({
id: -1,
dashboard_tab_id: TAB_1.id,
size_x: 10,
size_y: 4,
card_id: ORDERS_QUESTION_ID,
}),
createMockDashboardCard({
id: -2,
dashboard_tab_id: TAB_2.id,
size_x: 10,
size_y: 4,
card_id: ORDERS_COUNT_QUESTION_ID,
}),
],
}).then(dashboard => visitDashboard(dashboard.id));
editDashboard();
cy.findByTestId("edit-bar").button("Cancel").click();
dashboardGrid().within(() => {
cy.findByText("Orders").should("exist");
cy.findByText("Orders, Count").should("not.exist");
getDashboardCards().should("have.length", 1);
});
});
});
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment