Merge pull request #4731 from metabase/commit-on-blur-inqb-template-tags

Save template tag parameter input field value immediately when typing it

frontend/src/metabase/dashboard/containers/ParameterWidget.jsx

@@ -36,11 +36,13 @@ export default class ParameterWidget extends Component {
     }
 
     static propTypes = {
-        parameter: PropTypes.object
+        parameter: PropTypes.object,
+        commitImmediately: PropTypes.object
     };
 
     static defaultProps = {
         parameter: null,
+        commitImmediately: false
     }
 
     getValues() {
@@ -56,7 +58,7 @@ export default class ParameterWidget extends Component {
     }
 
     renderPopover(value, setValue, placeholder, isFullscreen) {
-        const {parameter, editingParameter} = this.props;
+        const {parameter, editingParameter, commitImmediately} = this.props;
         const isEditingParameter = !!(editingParameter && editingParameter.id === parameter.id);
         const values = this.getValues();
         return (
@@ -70,6 +72,7 @@ export default class ParameterWidget extends Component {
                 placeholder={placeholder}
                 focusChanged={this.focusChanged}
                 isFullscreen={isFullscreen}
+                commitImmediately={commitImmediately}
             />
         );
     }

frontend/src/metabase/dashboard/containers/Parameters.jsx

@@ -11,6 +11,7 @@ export default class Parameters extends Component {
     defaultProps = {
         syncQueryString: false,
         vertical: false,
+        commitImmediately: false
     }
 
     componentWillMount() {
@@ -62,7 +63,8 @@ export default class Parameters extends Component {
             editingParameter, setEditingParameter,
             isEditing, isFullscreen, isNightMode, isQB,
             setParameterName, setParameterValue, setParameterDefaultValue, removeParameter,
-            vertical
+            vertical,
+            commitImmediately
         } = this.props;
 
         const parameters = this._parametersWithValues();
@@ -88,6 +90,8 @@ export default class Parameters extends Component {
                         setValue={(value) => setParameterValue(parameter.id, value)}
                         setDefaultValue={(value) => setParameterDefaultValue(parameter.id, value)}
                         remove={() => removeParameter(parameter.id)}
+
+                        commitImmediately={commitImmediately}
                     />
                 ) }
             </div>

frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx

@@ -348,6 +348,7 @@ export default class NativeQueryEditor extends Component {
                             setParameterValue={setParameterValue}
                             syncQueryString
                             isQB
+                            commitImmediately
                         />
                         <a className="Query-label no-decoration flex-align-right flex align-center px2" onClick={this.toggleEditor}>
                             <span className="mx2">{toggleEditorText}</span>