Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
77802184
Commit
77802184
authored
9 years ago
by
Cam Saul
Browse files
Options
Downloads
Patches
Plain Diff
Fix issue where changing value of preview_display might not save
parent
e7cc3fa7
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/api/meta/field.clj
+4
-4
4 additions, 4 deletions
src/metabase/api/meta/field.clj
with
4 additions
and
4 deletions
src/metabase/api/meta/field.clj
+
4
−
4
View file @
77802184
...
...
@@ -39,10 +39,10 @@
{
field_type
FieldType
special_type
FieldSpecialType
}
(
write-check
Field
id
)
(
check-500
(
m/mapply
upd
Field
id
(
merge
{
:description
description
; you're allowed to unset description and special_type
:special_type
special_type
}
; but field_type and preview_display must be replaced
(
when
field_type
{
:field_type
field_type
})
; with new non-nil values
(
when
preview_display
{
:preview_display
preview_display
}))))
(
check-500
(
m/mapply
upd
Field
id
(
merge
{
:description
description
; you're allowed to unset description and special_type
:special_type
special_type
}
; but field_type and preview_display must be replaced
(
when
field_type
{
:field_type
field_type
})
; with new non-nil values
(
when
(
not
(
nil?
preview_display
))
{
:preview_display
preview_display
}))))
(
sel
:one
Field
:id
id
))
(
defendpoint
GET
"/:id/summary"
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment