Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

8786c23a

Unverified Commit 8786c23a authored 8 months ago by Denis Berezin Committed by GitHub 8 months ago

Downloads
- Patches
- Plain Diff

feat(sdk): Improve dashboard and question loaders to show in the middle (#44710)

* Fix SDK components loaders

* Review fixes

parent 9256999d

No related branches found

No related tags found

No related merge requests found

Changes 6

Hide whitespace changes

Inline Side-by-side

Showing

enterprise/frontend/src/embedding-sdk/components/private/InteractiveQuestionResult.tsx 17 additions, 13 deletions

...ding-sdk/components/private/InteractiveQuestionResult.tsx
enterprise/frontend/src/embedding-sdk/components/private/PublicComponentStylesWrapper.tsx 4 additions, 0 deletions

...g-sdk/components/private/PublicComponentStylesWrapper.tsx
enterprise/frontend/src/embedding-sdk/components/private/PublicComponentWrapper/PublicComponentWrapper.tsx 7 additions, 7 deletions

...private/PublicComponentWrapper/PublicComponentWrapper.tsx
enterprise/frontend/src/embedding-sdk/components/private/PublicComponentWrapper/SdkError.tsx 12 additions, 7 deletions

...dk/components/private/PublicComponentWrapper/SdkError.tsx
enterprise/frontend/src/embedding-sdk/components/private/PublicComponentWrapper/SdkLoader.tsx 7 additions, 3 deletions

...k/components/private/PublicComponentWrapper/SdkLoader.tsx
enterprise/frontend/src/embedding-sdk/components/public/InteractiveDashboard/InteractiveDashboard.tsx 31 additions, 31 deletions

...ents/public/InteractiveDashboard/InteractiveDashboard.tsx

with 78 additions and 61 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment