Make admin settings paths prettier (#23781)

enterprise/frontend/src/metabase-enterprise/embedding/index.js

@@ -40,7 +40,7 @@ const APP_ORIGIN_SETTING = {
 PLUGIN_ADMIN_SETTINGS_UPDATES.push(sections =>
   updateIn(
     sections,
-    ["embedding_in_other_applications/full-app", "settings"],
+    ["embedding-in-other-applications/full-app", "settings"],
     settings => {
       return [...settings, APP_ORIGIN_SETTING];
     },

frontend/src/metabase/admin/settings/components/widgets/EmbeddingOption/EmbeddingOption.tsx

@@ -21,7 +21,7 @@ interface EmbeddingOptionProps {
 export default function EmbeddingOption({ setting }: EmbeddingOptionProps) {
   return (
     <Link
-      to={`/admin/settings/embedding_in_other_applications/${setting.embedType}`}
+      to={`/admin/settings/embedding-in-other-applications/${setting.embedType}`}
     >
       <StyledCard compact>
         {setting.embedType === "full-app" && <Label>{t`Paid`}</Label>}

frontend/src/metabase/admin/settings/selectors.js

@@ -306,7 +306,7 @@ const SECTIONS = updateSectionsWithPlugins({
       },
     ],
   },
-  public_sharing: {
+  "public-sharing": {
     name: t`Public Sharing`,
     order: 9,
     settings: [
@@ -329,7 +329,7 @@ const SECTIONS = updateSectionsWithPlugins({
       },
     ],
   },
-  embedding_in_other_applications: {
+  "embedding-in-other-applications": {
     name: t`Embedding`,
     order: 10,
     settings: [
@@ -387,7 +387,7 @@ const SECTIONS = updateSectionsWithPlugins({
       },
     ],
   },
-  "embedding_in_other_applications/standalone": {
+  "embedding-in-other-applications/standalone": {
     settings: [
       {
         widget: () => {
@@ -397,7 +397,7 @@ const SECTIONS = updateSectionsWithPlugins({
               crumbs={[
                 [
                   t`Embedding`,
-                  "/admin/settings/embedding_in_other_applications",
+                  "/admin/settings/embedding-in-other-applications",
                 ],
                 [t`Standalone embeds`],
               ]}
@@ -432,13 +432,13 @@ const SECTIONS = updateSectionsWithPlugins({
       },
       {
         widget: () => (
-          <RedirectWidget to="/admin/settings/embedding_in_other_applications" />
+          <RedirectWidget to="/admin/settings/embedding-in-other-applications" />
         ),
         getHidden: (_, derivedSettings) => derivedSettings["enable-embedding"],
       },
     ],
   },
-  "embedding_in_other_applications/full-app": {
+  "embedding-in-other-applications/full-app": {
     settings: [
       {
         widget: () => {
@@ -448,7 +448,7 @@ const SECTIONS = updateSectionsWithPlugins({
               crumbs={[
                 [
                   t`Embedding`,
-                  "/admin/settings/embedding_in_other_applications",
+                  "/admin/settings/embedding-in-other-applications",
                 ],
                 [t`Full-app embedding`],
               ]}
@@ -464,7 +464,7 @@ const SECTIONS = updateSectionsWithPlugins({
       },
       {
         widget: () => (
-          <RedirectWidget to="/admin/settings/embedding_in_other_applications" />
+          <RedirectWidget to="/admin/settings/embedding-in-other-applications" />
         ),
         getHidden: (_, derivedSettings) => derivedSettings["enable-embedding"],
       },

frontend/src/metabase/public/components/widgets/SharingPane.tsx

@@ -222,7 +222,7 @@ function getEmbeddingHelperText({
     return jt`In order to embed your question, you have to first ${(
       <a
         className="link"
-        href="/admin/settings/embedding_in_other_applications"
+        href="/admin/settings/embedding-in-other-applications"
       >
         enable embedding in your Admin settings.
       </a>

frontend/test/metabase/scenarios/embedding/embedding-premium-token.cy.spec.js

 import { restore, isOSS } from "__support__/e2e/helpers";
 
-const embeddingPage = "/admin/settings/embedding_in_other_applications";
+const embeddingPage = "/admin/settings/embedding-in-other-applications";
 const licensePage = "/admin/settings/premium-embedding-license";
 
 // A random embedding token with valid format

frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js

@@ -7,7 +7,7 @@ import {
   visitIframe,
 } from "__support__/e2e/helpers";
 
-const embeddingPage = "/admin/settings/embedding_in_other_applications";
+const embeddingPage = "/admin/settings/embedding-in-other-applications";
 const licenseUrl = "https://metabase.com/license/embedding";
 const upgradeUrl = "https://www.metabase.com/upgrade/";