Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
a4421cae
Commit
a4421cae
authored
7 years ago
by
Cam Saül
Browse files
Options
Downloads
Patches
Plain Diff
Move druid-topN-results constant to somewhere more sensible [ci drivers]
parent
4daca535
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/metabase/driver/druid/query_processor.clj
+8
-1
8 additions, 1 deletion
src/metabase/driver/druid/query_processor.clj
src/metabase/query_processor/interface.clj
+0
-7
0 additions, 7 deletions
src/metabase/query_processor/interface.clj
with
8 additions
and
8 deletions
src/metabase/driver/druid/query_processor.clj
+
8
−
1
View file @
a4421cae
...
...
@@ -11,6 +11,13 @@
[
metabase.util
:as
u
])
(
:import
[
metabase.query_processor.interface
AgFieldRef
DateTimeField
DateTimeValue
Expression
Field
RelativeDateTimeValue
Value
]))
(
def
^
:private
^
:const
topN-max-results
"Maximum number of rows the topN query in Druid should return. Huge values cause significant issues with the engine.
Coming from the default value hardcoded in the Druid engine itself
http://druid.io/docs/latest/querying/topnquery.html"
1000
)
;; +-----> ::select +----> :groupBy
;; ::query ----| |
;; +----> ::ag-query ----+----> ::topN
...
...
@@ -77,7 +84,7 @@
::total
(
merge
defaults
{
:queryType
:timeseries
})
::grouped-timeseries
(
merge
defaults
{
:queryType
:timeseries
})
::topN
(
merge
defaults
{
:queryType
:topN
:threshold
i/druid-
topN-max-results
})
:threshold
topN-max-results
})
::groupBy
(
merge
defaults
{
:queryType
:groupBy
})}))
...
...
This diff is collapsed.
Click to expand it.
src/metabase/query_processor/interface.clj
+
0
−
7
View file @
a4421cae
...
...
@@ -18,13 +18,6 @@
https://support.office.com/en-nz/article/Excel-specifications-and-limits-1672b34d-7043-467e-8e27-269d656771c3"
1048576
)
(
def
^
:const
druid-topN-max-results
"Maximum number of rows the topN query in Druid should return. Huge values cause significant issues with the engine.
Coming from the default value hardcoded in the Druid engine itself
http://druid.io/docs/latest/querying/topnquery.html"
1000
)
;;; # ------------------------------------------------------------ DYNAMIC VARS ------------------------------------------------------------
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment