little bit of final cleanup.

src/metabase/api/field.clj

@@ -55,7 +55,7 @@
                                                 :field_type      field_type
                                                 :special_type    special_type
                                                 :visibility_type visibility_type}
-                                               (when display_name               {:display_name display_name}))))
+                                               (when display_name {:display_name display_name}))))
       (Field id))))
 
 (defendpoint GET "/:id/summary"

src/metabase/api/table.clj

@@ -55,7 +55,6 @@
 (defendpoint GET "/:id/fields"
   "Get all `Fields` for `Table` with ID."
   [id]
-  ;; TODO: check that order doesn't change in a problematic way due to sorting by position
   (let-404 [table (Table id)]
     (read-check table)
     (sel :many Field :table_id id, :visibility_type [not-in ["sensitive" "retired"]], (k/order :name :ASC))))

src/metabase/driver/query_processor.clj

@@ -172,9 +172,9 @@
       (qp (if-not (should-add-implicit-fields? query)
             query
             (let [fields (for [field (db/sel :many :fields [Field :name :display_name :base_type :special_type :visibility_type :display_name :table_id :id :position :description]
-                                             :table_id   source-table-id
+                                             :table_id        source-table-id
                                              :visibility_type [not-in ["sensitive" "retired"]]
-                                             :parent_id  nil
+                                             :parent_id       nil
                                              (k/order :position :asc) (k/order :id :desc))]
                            (let [field (-> (resolve/rename-mb-field-keys field)
                                            map->Field

src/metabase/models/table.clj

@@ -47,7 +47,6 @@
   "Return the `FieldValues` for all `Fields` belonging to TABLE."
   {:hydrate :field_values, :arglists '([table])}
   [{:keys [id]}]
-  ;; TODO: any reason to return field-values for other visibility options?
   (let [field-ids (db/sel :many :id Field, :table_id id, :visibility_type "normal"
                           (k/order :position :asc)
                           (k/order :name :asc))]