Skip to content
Snippets Groups Projects
Unverified Commit a89ade03 authored by Nick Fitzpatrick's avatar Nick Fitzpatrick Committed by GitHub
Browse files

27356 switch dashboards filters (#27425)

* temp

* Adding cypress test

* removing test

* unskipping test
parent da4b8e82
Branches
Tags
No related merge requests found
......@@ -115,8 +115,8 @@ class Dashboard extends Component {
);
// NOTE: all of these lifecycle methods should be replaced with DashboardData HoC in container
componentDidMount() {
this.loadDashboard(this.props.dashboardId);
async componentDidMount() {
await this.loadDashboard(this.props.dashboardId);
const main = getMainElement();
main.addEventListener("scroll", this.throttleParameterWidgetStickiness, {
......@@ -127,9 +127,9 @@ class Dashboard extends Component {
});
}
componentDidUpdate(prevProps) {
async componentDidUpdate(prevProps) {
if (prevProps.dashboardId !== this.props.dashboardId) {
this.loadDashboard(this.props.dashboardId);
await this.loadDashboard(this.props.dashboardId);
this.throttleParameterWidgetStickiness();
} else if (
!_.isEqual(prevProps.parameterValues, this.props.parameterValues) ||
......
......@@ -21,7 +21,7 @@ const regularDashboard = {
name: "Dashboard Without Params",
};
describe.skip("issue 27356", () => {
describe("issue 27356", () => {
beforeEach(() => {
cy.intercept("GET", "/api/dashboard/*").as("getDashboard");
restore();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment