Revert "Fix missing result metadata (#39201)" (#39294)

* Revert "Fix missing result metadata (#39201)"

This reverts commit d26b7820.

* Move resultsMetadata mapping to getSubmittableQuestion

* Bring back the test

frontend/src/metabase/query_builder/actions/core/core.js

@@ -30,11 +30,10 @@ import {
   getCard,
   getIsResultDirty,
   getOriginalQuestion,
-  getParameters,
   getQuestion,
-  getResultsMetadata,
-  getSubmittableQuestion,
   isBasedOnExistingQuestion,
+  getParameters,
+  getSubmittableQuestion,
 } from "../../selectors";
 import { updateUrl } from "../navigation";
 import { zoomInRow } from "../object-detail";
@@ -237,17 +236,6 @@ export const apiUpdateQuestion = (question, { rerunQuery } = {}) => {
 
     const isResultDirty = getIsResultDirty(getState());
     const isModel = question.type() === "model";
-
-    if (isModel) {
-      const resultsMetadata = getResultsMetadata(getState());
-
-      if (!resultsMetadata) {
-        // Running the question will populate results metadata in redux store.
-        // Without it getSubmittableQuestion won't have all the necessary information.
-        await dispatch(runQuestionQuery());
-      }
-    }
-
     const { isNative } = Lib.queryDisplayInfo(question.query());
 
     if (!isNative) {

frontend/src/metabase/query_builder/actions/querying.js

@@ -121,7 +121,7 @@ export const runQuestionQuery = ({
 
     const queryTimer = startTimer();
 
-    const runQuestionPromise = apiRunQuestionQuery(question, {
+    apiRunQuestionQuery(question, {
       cancelDeferred: cancelQueryDeferred,
       ignoreCache: ignoreCache,
       isDirty: cardIsDirty,
@@ -140,8 +140,6 @@ export const runQuestionQuery = ({
       .catch(error => dispatch(queryErrored(startTime, error)));
 
     dispatch({ type: RUN_QUERY, payload: { cancelQueryDeferred } });
-
-    return runQuestionPromise;
   };
 };