Skip to content
Snippets Groups Projects
Commit b0dff620 authored by Anton Kulyk's avatar Anton Kulyk
Browse files

Manage column formatting for datasets + add extra form fields (UI) (#19291)


* Convert SelectButton to TypeScript

* Add onClick prop to SelectButton

* Extract FormFieldDivider component

* Pass dataset into field metadata sidebar

* Add function to get field metadata form fields

* Simplify field visibility options generation

* Allow to provide custom form field widgets

* Add `renderSearchSection` prop to AccordionList

* Add SemanticTypePicker component

* Use SemanticTypePicker

* Add FieldSelector (DataSelector subset)

* Allow hiding DataSelector trigger expand control

* Add MappedFieldPicker component

* Use MappedFieldPicker for native datasets

* Simplify mapped field name formatting

* Fix dataset type usage

* Remove redundant props

* Disable fuzzy search for SemanticTypePicker

* Allow hiding empty AccordionList sections in search

* Don't show empty sections in SemanticTypePicker

* Add formatting section to field metadata form

* Fix FormFieldDivider margin

* Add FK target and currency pickers

* Hide column title from formatting section

* Wire up column formatting updates

* Convert ChartSettingsWidget to TypeScript

* Use styled-components for ChartSettingsWidget

* Add "variant" prop to ChartSettingsWidget

* Unify sidebar form UI

* Fix hidden column settings are forcefully shown

* Add "column type" field label

* Fix ChartSettingsWidget label size in defaul mode

* Use "radio" input for "view_as" field

* Use "Text" instead of "Off" for view_as field

* Use tab layout in field metadata sidebar

* Hide Formatting tab if missing formatting opts

* Fix hidden formatting fields behavior

* Fix E2E test using renamed label

* change view_as label to "Display as"

* Remove divider from expanded semantic type picker

* Move FormFieldDivider into sidebar's .styled file

* Choose "view_as" widget depending on options count

* use "radio" for exactly two options
* use "select" when there are > 2 options

* Change selected radio button look

* Use "text-dark" in sidebar form

* Set height for semantic type picker

* Use Field's displayName method for formatting

Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
parent c9084750
Branches
Tags
No related merge requests found
Showing
with 677 additions and 103 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment