Serdes v2: Improved selective serialization; several fixes for Stats (#25834)
These changes resulted from the effort to serialize and deserialize some collections from our internal Stats instance, which did not (de)serialize correctly out of the box. The main improvement is more robust "escape" analysis - making sure that all dashboards, cards, models, etc. required by the curated collections actually belong to those curated collections. (Many cards on Stats were actually in people's personal collections and publicly readable - that doesn't work with the curated git workflow.) This adds some new tests, trying to capture some complex MBQL queries and make sure they're correctly (de)serialized.
Showing
- enterprise/backend/src/metabase_enterprise/serialization/api/serialize.clj 4 additions, 3 deletions...d/src/metabase_enterprise/serialization/api/serialize.clj
- enterprise/backend/src/metabase_enterprise/serialization/v2/extract.clj 117 additions, 15 deletions...kend/src/metabase_enterprise/serialization/v2/extract.clj
- enterprise/backend/src/metabase_enterprise/serialization/v2/ingest/yaml.clj 17 additions, 1 deletion.../src/metabase_enterprise/serialization/v2/ingest/yaml.clj
- enterprise/backend/src/metabase_enterprise/serialization/v2/storage/yaml.clj 6 additions, 1 deletion...src/metabase_enterprise/serialization/v2/storage/yaml.clj
- enterprise/backend/src/metabase_enterprise/serialization/v2/utils/yaml.clj 24 additions, 6 deletions...d/src/metabase_enterprise/serialization/v2/utils/yaml.clj
- enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj 1 addition, 0 deletions...est/metabase_enterprise/serialization/v2/extract_test.clj
- enterprise/backend/test/metabase_enterprise/serialization/v2/ingest/yaml_test.clj 32 additions, 0 deletions...metabase_enterprise/serialization/v2/ingest/yaml_test.clj
- enterprise/backend/test/metabase_enterprise/serialization/v2/storage/yaml_test.clj 33 additions, 1 deletion...etabase_enterprise/serialization/v2/storage/yaml_test.clj
- enterprise/backend/test/metabase_enterprise/serialization/v2/util_test.clj 30 additions, 0 deletions...d/test/metabase_enterprise/serialization/v2/util_test.clj
- src/metabase/models/card.clj 12 additions, 5 deletionssrc/metabase/models/card.clj
- src/metabase/models/collection.clj 1 addition, 1 deletionsrc/metabase/models/collection.clj
- src/metabase/models/dashboard.clj 6 additions, 4 deletionssrc/metabase/models/dashboard.clj
- src/metabase/models/dashboard_card.clj 5 additions, 4 deletionssrc/metabase/models/dashboard_card.clj
- src/metabase/models/metric.clj 3 additions, 0 deletionssrc/metabase/models/metric.clj
- src/metabase/models/serialization/base.clj 3 additions, 1 deletionsrc/metabase/models/serialization/base.clj
- src/metabase/models/serialization/hash.clj 5 additions, 0 deletionssrc/metabase/models/serialization/hash.clj
- src/metabase/models/serialization/util.clj 78 additions, 41 deletionssrc/metabase/models/serialization/util.clj
Loading
Please register or sign in to comment