This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 12, 2022
-
-
Braden Shepherdson authored
These changes resulted from the effort to serialize and deserialize some collections from our internal Stats instance, which did not (de)serialize correctly out of the box. The main improvement is more robust "escape" analysis - making sure that all dashboards, cards, models, etc. required by the curated collections actually belong to those curated collections. (Many cards on Stats were actually in people's personal collections and publicly readable - that doesn't work with the curated git workflow.) This adds some new tests, trying to capture some complex MBQL queries and make sure they're correctly (de)serialized.
-
Jeff Bruemmer authored
-
Noah Moss authored
-
Noah Moss authored
* fix serialization test by not hardcoding tmp directory * clean imports * cleanup * change approach
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Hide ID filters in data app pages * Extend existing `getVisibleParameters` utility * Use existing `getVisibleParameters` in Dashboard
-
- Oct 11, 2022
-
-
Nemanja Glumac authored
-
Case Nelson authored
* [Apps] Scaffolding cleanup * Make the back to list button bigger so it doesn't wrap on some screens * Remove the Query prefix from cards * Increase size of list and detail cards to 18x12
-
Anton Kulyk authored
* Remove info sidebar for data app pages * Fix "Last edited by" text behavior
-
Case Nelson authored
When scaffolding, we should be automatically adding the insert,update,delete implicit actions. * Add order by on test Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Case Nelson authored
* [Apps] Model Actions Adding migration and endpoints for model_action. * model action execution Changing the execution endpoints again, still working on implicit action execution tests. Need to also test the parameters fetch. * Re-add execution route for dashcard action_id until Front End catches up * Add name to model_action GET * Hydrate model-action on dashcards * Rename and combine hydration of model_action to action * Implicit action execution support. Use slug columns as parameter ids * Go through model-action when using GET /action * FE integration fixes * Move action execution to use new parameter shape Now, parameters should be a map of parameter-id to value Parameter-id should be mapped on the FE. So the action parameter-id not the unmapped dashboard parameter-id. * Bring ModelAction into copy code * Generate target of implicit actions to match http actions * Update action test to place action on model * Add unique constraint to model_action for (card_id, slug) * Add missing require * model_action.slug needs to be varchar for mysql constraint * Fix test from unique constraint * Consistent ordering for tests * Addressing Code Reviews and Scaffold changes * Add type: implicit to implicit model actions * Update src/metabase/api/model_action.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Allow changing card_id with PUT to dashcard for model-actions * Update tests after merge * Fix implicit delete and add better test coverage * Addressing review changes Add PUT test Add schema for dashboard-id and dashcard-id params Fix select ordering in test * Model Actions: Frontend (#25646) * save actions in models * list model actions on detail page (#25648) * Link Dashcards to model-based actions (#25770) * Link dashcards to model-based actions * address review comments * Data apps model actions implicit creator (#25807) * Link dashcards to model-based actions * address review comments * Link dashcards to model-based actions * Allow implicit actions to be used like explicit ones * address review comments Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
Nick Fitzpatrick authored
* Adding maxDimensions to waterfall charts * Adding test * removing added default column behaviour, adjusting test
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
* support static row chart on the backend * update and add types * update types * add chart columns helper, dataset grouping * add viz settings helpers * fix text measuring * add generic row chart component for static and dynamic rendering * update deps * fix jest config for d3 * allow importing cljs in static viz * add a hook for getting chart columns and series * add a static row chart * build cljs before static viz * specs * add stories, moved isomorphic row chart component to the shared folder * update import * fix backend merge * remove an extra line * one more extra line * exclude unused props from the row chart * cleanup * review * fix types * fix log scale * add visual spec, fix goal label truncate * review * fix mock path * fix specs
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
Dalton authored
* Move parameter target utils to metabase-lib * Move parameter-type utils to metabase-lib * Move parameter constants to metabase-lib * Use Parameter interface, not UiParameter type, in operator utils * Move operator utils to metabase-lib * Move filter utils to metabase-lib
-
Dalton authored
* Fix scripting error in model metadata sidebar * Default to card's result_metadata col if we can't find it in the query metadata * Look at virtual card table for column metadataa
-
Anton Kulyk authored
* tweak header status based on isDataApp * get isDataApp from proper source, use to stop the whole show / hide business * Fix hardcoded color Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
Kyle Doherty authored
* preserve params when saving the dashboard, essential for data apps details * keep existing behavior for normal dashboards, keep params for pages
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
Repro #25543 : Collection list fails to display if there's an invalid parameter in a question (#25868)
-
Mahatthana (Kelvin) Nomsawadi authored
The bug was introduced by https://github.com/metabase/metabase/pull/25651
-
- Oct 10, 2022
-
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Dalton authored
* Move operator utils from schema_metadata.js to metabase-lib * Remove unused function
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
- Oct 07, 2022
-
-
metamben authored
* Implement per group and per db app permissions
-
Jeff Bruemmer authored
-
metamben authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Basic static gauge chart * Add gauge segment min max labels * Add gauge segment label * Cleanup code * Fix React list key error * Remove hard-coded colors * Make the everything calculates at the gauge center * Make gauge segment data easier to understand * Example scaling chart to avoid label overflow * Avoid long labels overflow by scaling the gauge chart down * Match gauge needle color with the design * Fix hard coded gauge segment label anchor calculation * Fix static gauge chart not rotate gauge needle correctly * Add E2E for static gauge chart * Fix `transform-origin: center` not working with BE static chart * Truncate long segment label so charts can never be too small * Fix gauge segment not connected to each other * Static chart refactor part 1 * Final static gauge chart refactoring * Simplify clojure chart render function * Fix relative imports * Make overlapping gauge labels more legible * Make GaugeLabelData property orders consistent * Make a function easier to read * Make the calculation more correct though the behavior would still be the same * Separate presentational component out of the Gauge component * Remove unused tap> * Fix gauge chart not working on chart tester in internal static viz page * Fix gauge chart not rendered with Lato font * Improve internal page static chart tester option clarity * Support column settings in gauge charts * Add unit tests for static gauge chart utils * Address review * Fix unittest failure
-
Gustavo Saiani authored
-
Braden Shepherdson authored
The value is reconstructed on the deserialization side based on the time of deserialization. For the git workflow, `updated_at` makes for a lot of diffs of unrelated files.
-
Dalton authored
* Move some constants in schema_metadata to metabase-lib * Rename isFK and isPK to isTypeFK, isTypePK to handle name conflicts * Move type logic in schema_metadata.js to metabase-lib * Move unit test over to isa.unit.spec.js
-
- Oct 06, 2022
-
-
Nemanja Glumac authored
* Remove duplicated tests * Use the existing test to reproduce 12972 * Merge tests together Do not write tiny, unit-like E2E tests! * Fix the misleading test title * Tidy up caching tests * Use the existing helper function * Move helpers to the bottom of the file * Type less * DRY code
-
Noah Moss authored
* draft fix * test * revert change to email testing helper to fix tests
-