Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

bda43594

Unverified Commit bda43594 authored 1 year ago by Cam Saul Committed by GitHub 1 year ago

Downloads
- Patches
- Plain Diff

[MLv2] `suggested-join-condition` => `suggested-join-conditions` and handle composite keys (#35565)

parent ba02a664

No related branches found

No related tags found

No related merge requests found

Changes 9

Hide whitespace changes

Inline Side-by-side

Showing

frontend/src/metabase-lib/join.ts 3 additions, 3 deletions

frontend/src/metabase-lib/join.ts
frontend/src/metabase/query_builder/components/notebook/steps/JoinStep/use-join.ts 4 additions, 5 deletions

...ry_builder/components/notebook/steps/JoinStep/use-join.ts
src/metabase/lib/core.cljc 1 addition, 1 deletion

src/metabase/lib/core.cljc
src/metabase/lib/join.cljc 75 additions, 61 deletions

src/metabase/lib/join.cljc
src/metabase/lib/js.cljs 5 additions, 5 deletions

src/metabase/lib/js.cljs
test/metabase/lib/field_test.cljc 3 additions, 6 deletions

test/metabase/lib/field_test.cljc
test/metabase/lib/join_test.cljc 166 additions, 20 deletions

test/metabase/lib/join_test.cljc
test/metabase/lib/test_util/mocks_31769.cljc 2 additions, 2 deletions

test/metabase/lib/test_util/mocks_31769.cljc
test/metabase/query_processor_test/explicit_joins_test.clj 2 additions, 2 deletions

test/metabase/query_processor_test/explicit_joins_test.clj

with 261 additions and 105 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment