Skip to content
Snippets Groups Projects
Unverified Commit c718ed3d authored by GitStart's avatar GitStart Committed by GitHub
Browse files

Visualization: Bar chart not showing 0 values unlike line and area chart (#23626)


* Visualization: Bar chart not showing 0 values unlike line and area chart

Co-authored-by: default avatargitstart <gitstart@gitstart.com>
Co-authored-by: default avatargitstart <gitstart@users.noreply.github.com>
Co-authored-by: default avatarNitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: default avatarGh0sT <coolmagnas@gmail.com>
Co-authored-by: default avatarRubens Rafael <70234898+RubensRafael@users.noreply.github.com>
Co-authored-by: default avatarGitStart <1501599+gitstart@users.noreply.github.com>
Co-authored-by: default avatarBenjamin Mayanja <vibenjamin6@gmail.com>
Co-authored-by: default avatarJúlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>

* Visualization: Bar chart not showing 0 values unlike line and area chart

Co-authored-by: default avatargitstart <gitstart@gitstart.com>
Co-authored-by: default avatargitstart <gitstart@users.noreply.github.com>
Co-authored-by: default avatarGitStart-Chalktalk <nitesh.singh@gitstart.dev>
Co-authored-by: default avatarGh0sT <coolmagnas@gmail.com>
Co-authored-by: default avatarRubens Rafael <70234898+RubensRafael@users.noreply.github.com>
Co-authored-by: default avatarGitStart <1501599+gitstart@users.noreply.github.com>
Co-authored-by: default avatarBenjamin Mayanja <vibenjamin6@gmail.com>
Co-authored-by: default avatarJúlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>

* remove 0 filter for bar chart

Co-authored-by: default avatargitstart <gitstart@gitstart.com>
Co-authored-by: default avatargitstart <gitstart@users.noreply.github.com>
Co-authored-by: default avatarGitStart-Chalktalk <nitesh.singh@gitstart.dev>
Co-authored-by: default avatarGh0sT <coolmagnas@gmail.com>
Co-authored-by: default avatarRubens Rafael <70234898+RubensRafael@users.noreply.github.com>
Co-authored-by: default avatarGitStart <1501599+gitstart@users.noreply.github.com>
Co-authored-by: default avatarBenjamin Mayanja <vibenjamin6@gmail.com>
Co-authored-by: default avatarJúlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>

Co-authored-by: default avatargitstart <gitstart@users.noreply.github.com>
Co-authored-by: default avatargitstart <gitstart@gitstart.com>
Co-authored-by: default avatarNitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: default avatarGh0sT <coolmagnas@gmail.com>
Co-authored-by: default avatarRubens Rafael <70234898+RubensRafael@users.noreply.github.com>
Co-authored-by: default avatarBenjamin Mayanja <vibenjamin6@gmail.com>
Co-authored-by: default avatarJúlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>
parent 8889384e
Branches
Tags
No related merge requests found
......@@ -107,20 +107,18 @@ export function onRenderValueLabels(
.flatten(1)
.value();
data = data
.map(([x, y, step], i) => {
const isLocalMin =
// first point or prior is greater than y
(i < step || data[i - step][1] > y) &&
// last point point or next is greater than y
(i >= data.length - step || data[i + step][1] > y);
const showLabelBelow = isLocalMin && display === "line";
const rotated = barCount > 1 && isBarLike(display) && barWidth < 40;
const hidden =
!showAll && barCount > 1 && isBarLike(display) && barWidth < 20;
return { x, y, showLabelBelow, seriesIndex, rotated, hidden };
})
.filter(d => !(display === "bar" && d.y === 0));
data = data.map(([x, y, step], i) => {
const isLocalMin =
// first point or prior is greater than y
(i < step || data[i - step][1] > y) &&
// last point point or next is greater than y
(i >= data.length - step || data[i + step][1] > y);
const showLabelBelow = isLocalMin && display === "line";
const rotated = barCount > 1 && isBarLike(display) && barWidth < 40;
const hidden =
!showAll && barCount > 1 && isBarLike(display) && barWidth < 20;
return { x, y, showLabelBelow, seriesIndex, rotated, hidden };
});
if (display === "waterfall" && data.length > 0) {
let total = 0;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment