Saved question picker bug bash (#16940)

* fix Saved questions string translation

* fix Everything else folder is not showing items in the saved question picker for other languages

* translate query builder header

* Fix saved questions db on the client side

* i18n on "Saved Questions"

Co-authored-by: dan sutton <dan@dpsutton.com>

frontend/src/metabase/query_builder/components/DataSelector.jsx

@@ -899,7 +899,7 @@ const DatabaseSchemaPicker = ({
   }
 
   const sections = databases.map(database => ({
-    name: database.name,
+    name: database.is_saved_questions ? t`Saved Questions` : database.name,
     items:
       !database.is_saved_questions && database.schemas.length > 1
         ? database.schemas.map(schema => ({

frontend/src/metabase/query_builder/components/saved-question-picker/SavedQuestionPicker.jsx

@@ -37,7 +37,7 @@ const propTypes = {
 
 const OUR_ANALYTICS_COLLECTION = {
   ...ROOT_COLLECTION,
-  schemaName: "Everything else",
+  schemaName: t`Everything else`,
   icon: "folder",
 };
 
@@ -110,7 +110,7 @@ function SavedQuestionPicker({
       <CollectionsContainer>
         <BackButton onClick={onBack}>
           <Icon name="chevronleft" className="mr1" />
-          {t`Saved questions`}
+          {t`Saved Questions`}
         </BackButton>
         <Box my={1}>
           <Tree

frontend/src/metabase/query_builder/components/view/NewQuestionHeader.jsx

 import React from "react";
+import { t } from "ttag";
 
 import ViewSection, { ViewHeading } from "./ViewSection";
 
 export default function NewQuestionHeader(props) {
   return (
     <ViewSection {...props}>
-      <ViewHeading>{`Pick your starting data`}</ViewHeading>
+      <ViewHeading>{t`Pick your starting data`}</ViewHeading>
     </ViewSection>
   );
 }

src/metabase/api/database.clj

@@ -153,7 +153,7 @@
 
 (defn- saved-cards-virtual-db-metadata [& {:keys [include-tables? include-fields?]}]
   (when (public-settings/enable-nested-queries)
-    (cond-> {:name               "Saved Questions"
+    (cond-> {:name               (trs "Saved Questions")
              :id                 mbql.s/saved-questions-virtual-database-id
              :features           #{:basic-aggregations}
              :is_saved_questions true}