Rework findColumnIndexForColumnSetting to MLv2 (#37854)
* Rework findColumnIndexForColumnSetting to MLv2 * Throw an error to find all places without query * Use MLv2 in ChartSettingTable (#38171) * Add a comment why we can't use mlv2 in chart setting table * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns * Tests completed, so revert throwing * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170) * Use mlv2 findColumnIndexForColumnSetting in object detail * Address review * Use mlv2 findColumnIndexForColumnSetting in Question (#38169) * Use mlv2 findColumnIndexForColumnSetting in Question * Update question tests * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172) * Use mlv2 findColumnIndexForColumnSetting in Table (#38168) * Cleanup finColumnSettings usage (#38914) * Fix linting
Showing
- frontend/src/metabase-lib/Question.ts 7 additions, 2 deletionsfrontend/src/metabase-lib/Question.ts
- frontend/src/metabase-lib/queries/utils/dataset.ts 18 additions, 16 deletionsfrontend/src/metabase-lib/queries/utils/dataset.ts
- frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailBody.tsx 4 additions, 0 deletions...sualizations/components/ObjectDetail/ObjectDetailBody.tsx
- frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailView.tsx 1 addition, 0 deletions...sualizations/components/ObjectDetail/ObjectDetailView.tsx
- frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailWrapper.tsx 10 additions, 6 deletions...lizations/components/ObjectDetail/ObjectDetailWrapper.tsx
- frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailsTable.tsx 9 additions, 2 deletions...alizations/components/ObjectDetail/ObjectDetailsTable.tsx
- frontend/src/metabase/visualizations/components/ObjectDetail/types.ts 2 additions, 0 deletions.../metabase/visualizations/components/ObjectDetail/types.ts
- frontend/src/metabase/visualizations/components/settings/ChartSettingTableColumns/ChartSettingTableColumns.tsx 2 additions, 0 deletions...ngs/ChartSettingTableColumns/ChartSettingTableColumns.tsx
- frontend/src/metabase/visualizations/components/settings/ChartSettingTableColumns/DatasetColumnSelector.tsx 9 additions, 2 deletions...ttings/ChartSettingTableColumns/DatasetColumnSelector.tsx
- frontend/src/metabase/visualizations/components/settings/ChartSettingTableColumns/utils.ts 7 additions, 1 deletion...ons/components/settings/ChartSettingTableColumns/utils.ts
- frontend/src/metabase/visualizations/lib/settings/column.js 14 additions, 1 deletionfrontend/src/metabase/visualizations/lib/settings/column.js
- frontend/src/metabase/visualizations/lib/settings/visualization.js 2 additions, 2 deletions...src/metabase/visualizations/lib/settings/visualization.js
- frontend/src/metabase/visualizations/visualizations/Table.tsx 6 additions, 5 deletions...tend/src/metabase/visualizations/visualizations/Table.tsx
- frontend/test/metabase-lib/lib/Question.unit.spec.js 12 additions, 0 deletionsfrontend/test/metabase-lib/lib/Question.unit.spec.js
- package.json 2 additions, 0 deletionspackage.json
- yarn.lock 12 additions, 0 deletionsyarn.lock
Loading
Please register or sign in to comment