Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 20, 2024
    • Uladzimir Havenchyk's avatar
      Rework findColumnIndexForColumnSetting to MLv2 (#37854) · e94ea96a
      Uladzimir Havenchyk authored
      * Rework findColumnIndexForColumnSetting to MLv2
      
      * Throw an error to find all places without query
      
      * Use MLv2 in ChartSettingTable (#38171)
      
      * Add a comment why we can't use mlv2 in chart setting table
      
      * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns
      
      * Tests completed, so revert throwing
      
      * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170)
      
      * Use mlv2 findColumnIndexForColumnSetting in object detail
      
      * Address review
      
      * Use mlv2 findColumnIndexForColumnSetting in Question (#38169)
      
      * Use mlv2 findColumnIndexForColumnSetting in Question
      
      * Update question tests
      
      * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172)
      
      * Use mlv2 findColumnIndexForColumnSetting in Table (#38168)
      
      * Cleanup finColumnSettings usage (#38914)
      
      * Fix linting
      Unverified
      e94ea96a
    • Chris Truter's avatar
    • Kamil Mielnik's avatar
    • Kamil Mielnik's avatar
      Align paths in Prettier & ESLint scripts (#38951) · 750638e4
      Kamil Mielnik authored
      * Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json
      
      * Handle ts files in e2e tests
      
      * Manually fix ESLint-reported issues
      
      * Format "lint-prettier-pure" script the same way as "prettier"
      
      * Run "yarn eslint-fix"
      
      * Manually fix remaining issues
      
      * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally
      
      * Remove duplicated eslint call
      Unverified
      750638e4
    • Kamil Mielnik's avatar
      Include e2e directory in prettier scripts (#38948) · 22684b87
      Kamil Mielnik authored
      * Include e2e directory in prettier scripts
      
      * Run "yarn prettier"
      Unverified
      22684b87
    • lbrdnk's avatar
      Use macro that does pre and post cleanup (#38929) · 21c5df97
      lbrdnk authored
      Swaps with-temporary-setting-values for with-report-timezone-id.
      Unverified
      21c5df97
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
    • Kamil Mielnik's avatar
      Fix - Flaky QueryBuilder tests (#38860) · ebb5500c
      Kamil Mielnik authored
      * Use fetchMock.flush() to prevent tests from interfering with each other
      
      * Revert "Use fetchMock.flush() to prevent tests from interfering with each other"
      
      This reverts commit 03f1277cf2bf481ac36db212e15b4f29511a386b.
      
      * Add typing for requests in the redux store
      
      * Fix QueryBuilder flakes by introducing waitForLoadingRequests
      
      * Simplify interface
      
      * Add mocks for requests in redux store, update types
      
      * Simplify code
      
      * Increase timeout
      Unverified
      ebb5500c
  2. Feb 19, 2024
  3. Feb 16, 2024
  4. Feb 15, 2024
    • Raphael Krut-Landau's avatar
      Browse models: refactoring (#38730) · 1ce5b449
      Raphael Krut-Landau authored
      * In browse, move ModelGroup and associated components to a separate file
      * Improve look of Browse tabs and SchemaBrowser crumbs
      Unverified
      1ce5b449
    • Cam Saul's avatar
      Mega QP context and entrypoint overhaul. Reduce QP hairiness by 30% (#35465) · 80dcbdfb
      Cam Saul authored
      * QP enterprise middleware should use `defenterprise`
      
      * Test fix? :wrench:
      
      * Remove `:rff` from the Query Processor context map
      
      * Sort namespaces
      
      * Simplify QP entrypoints part 1
      
      * Test fixes :wrench:
      
      * Test fixes :wrench:
      
      * Make sure defenterprise dispatch is done for every QP run
      
      * B I G  QP context overhaul
      
      * WIP
      
      * Remove qp.context.default
      
      * Test fix :wrench:
      
      * PR feedback
      
      * QP context overhaul [WIP] [ci skip]
      
      * QP context overhaul [WIP] [ci skip]
      
      * Fix duplicate preprocesses
      
      * Some test fixes.
      
      * More test fixes [ci skip]
      
      * Source card resolution middleware should be preprocessing middleware, not around [ci skip]
      
      * Test fixes [WIP] [ci skip]
      
      * Remove `test-qp-middleware`
      
      * Remove `qp/compile`
      
      * Fix Kondo warnings/cleanup
      
      * Remove `mt/compile`
      
      * Fix most tests
      
      * Mostly everything working?
      
      * 4 failures, 1 error
      
      * Eliminate QP context `reducedf`
      
      * 3 failures, 0 errors <3
      
      * All tests are passing <3
      
      * Remove dead debug-qp code
      
      * Fix test failure
      
      * Remove async context
      
      * Remove raisef
      
      * Forget it, just remove context entirely [ci skip]
      
      * Fix Kondo errors
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Remove empty namespace
      
      * Fix some reflection warnings
      
      * Update dox [ci skip]
      
      * Test fix :wrench:
      
      * Fix pivot QP
      
      * Misc improvements
      
      * Test fix :wrench:
      
      * Improvements and test fixes
      
      * More test fixes :wrench:
      
      * Test fixes :wrench:
      
      * Address PR feedback
      
      * Test fixes :wrench:
      
      * More test fixes and docstring improvements
      
      * Appease Eastwood
      
      * Test fixes :wrench:
      
      * More test fixes
      
      * Test fixes :wrench:
      
      
      
      * Revert test parallelization in metabase.models.params.chain-filter-test
      
      * Update src/metabase/async/util.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      80dcbdfb
Loading