Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 14, 2021
    • Anton Kulyk's avatar
      Add slugs to URLs to make them friendlier (#15989) · 01a06c97
      Anton Kulyk authored
      * Install slugify
      
      * Add utils to slugify and parse entity URLs
      
      * Add `<Entity.Link />` component
      
      Basically just a `<Entity.Name />`,
      but wrapped inside `<Link />`
      
      * Add slugs to `/browse/:databaseId` URLs
      
      * Use constant for "Saved Questions" database ID
      
      * Fix "Saved Questions" not displayed in breadcrumbs
      
      * Fix opening browse page for "Saved Questions"
      
      * Add slugs to `/collection/:id` URLs
      
      * Fix personal collection page slug
      
      * Remove `describe.only`
      
      * Remove unnecessary type coercion
      
      * Fix typo
      
      * Fix collections not highlighted in the sidebar
      
      * Add slug to collection `/archive` URL
      
      * Add slug to collection `/edit` URL
      
      * Add slug to collection `/permissions` URL
      
      * Use slug in `getInitialCollectionId` selector
      
      * Explicitly pass root ID to `Urls.collection`
      
      * Pass prop to EntityLink's Link component
      
      * Fix DashboardMoveToast collection link
      
      * Allow overwriting EntityLink's Link component
      
      * Fix links in QueryBuilder's search
      
      * Fix collection link in search results
      
      * Fix navigating to collection after question archived
      
      * Fix navigating to collection from pulse edit
      
      * Slugify users' personal collection URLs
      
      * Test slugified collection URLs are opened correctly
      
      * Add slugs to `/dashboard/:id` URLs
      
      * Fix dashboard URLs at admin public sharing page
      
      * Fix opening dashboards from main page
      
      * Fix navigation to saved automatic dashboard
      
      * Fix dashboard moving
      
      * Fix dashboard history
      
      * Fix closing dashboard editing modal
      
      * Fix dashboard details form is empty
      
      Reproduced if opening the form via URL
      (`/dashboard/:id/details`)
      
      Works correctly if the details modal is opened from a dropdown menu
      
      * Fix dashboard copy form crash
      
      Reproduced if opening the form via URL (`/dashboard/:id/copy`)
      
      * Fix copying dashboard
      
      * Fix closing dashboard copy modal
      
      * Fix navigation once dashboard is created
      
      * Replace hardcoded "root" id with a constant
      
      * Assert pathnames instead of URLs
      
      * Fix duplicate modal not closing automatically
      
      * Fix URLs on Activity page
      
      * Fix navigating to dashboard question is added to
      
      * Fix archiving dashboard
      
      * `dashboardId` —> `slug`
      
      * Add slugs to `/question/:id` URLs
      
      * Fix links to questions on Activity page
      
      * Switch questions to slugified URLs
      
      * Remove not used import
      
      * Update pathname assertion
      
      * Fix collection URL builder fails receiving `null`
      
      * Ensure question URL builder returns valid URL
      
      * Update pathname assertions
      
      * Update pathname assertions
      
      * Update pathname assertions
      
      * Update pathname assertion
      
      * Update pathname assertion
      
      * Add question URL builder unit tests
      
      * Fix collection URL builder
      
      * Fix `null` collection ID when building URL
      
      * Fix repro test issue reference
      
      * Move URLs tests into onboarding folder
      
      * Enable #15256 repro test
      
      * Fix slugs for edge cases
      Unverified
      01a06c97
  2. May 13, 2021
  3. May 12, 2021
  4. May 11, 2021
  5. May 10, 2021
  6. May 07, 2021
  7. May 06, 2021
    • Ariya Hidayat's avatar
      Basic type inference for custom expression (#15940) · ff7e29cb
      Ariya Hidayat authored
      
      * Make it work with MBQL instead
      
      * Update frontend/test/metabase/lib/expressions/typeinferencer.unit.spec.js
      
      Co-authored-by: default avatarflamber <1447303+flamber@users.noreply.github.com>
      Unverified
      ff7e29cb
    • Jeff Evans's avatar
      Add diagnostic info for connection pools to Help page (#15704) · 9dc522a4
      Jeff Evans authored
      Add diagnostic info for connection pools to Help page
      
      Backend changes:
      Add org.clojure/java.jmx dependency to project.clj for use in JMX bean querying
      To troubleshooting.clj, add some functions to capture details from the c3p0 connection pool beans to a map
      Add new API endpoint to invoke that from util.clj
      Add content-disposition header to API endpoint to make it a download
      
      Frontend changes:
      In the Help page, add a new paragraph below the existing "Diagnostic Info" JSON blob for advanced details, envisioned as a list of download links (which users can then attach to tickets, etc.)
      Unverified
      9dc522a4
    • Ariya Hidayat's avatar
    • Anton Kulyk's avatar
      Fix item picker suggests to select items user does not have write access to (#15613) · 27726dbb
      Anton Kulyk authored
      * Test adding question to dashboard
      
      * Test collections filtering when adding a question
      
      When adding a question to dashboard,
      we need to display collections a user has "write" access to.
      Collection with "read" access have to be hidden
      
      * Fix adding question to dashboard without access
      
      * Add a note about permissions test suite
      
      * Move question permission tests to collection suite
      
      * Revert initial collections filtering
      
      * Fix adding question to dashboard without access
      
      * Remove redundant state field
      
      * Enable #15281 issue repro test
      
      * Remove requireCollectionWritePermission prop
      
      * Filter items user doesn't have `write` access to
      
      * Fix permission tests
      
      * Fix dashboard test
      
      * Fix part of permission tests disabled for nodata user
      
      * Bring back issue reference to Cypress test
      
      * Remove underscore prefixes for component methods
      
      * Test offers saving dashboard to opened collection
      
      * Fix tests nested incorrectly
      
      * Split dashboard permission test
      
      * Fix suggest saving items to read-only collections
      
      * Fix collection permission filtering
      
      See comment:
      https://github.com/metabase/metabase/pull/15613#discussion_r614460504
      
      * Move comment
      
      * Fix test failing due to fixed collection suggestion
      
      * Remove `should("exist")` from Cypress tests
      
      * Merge "adding question to dashboard" tests
      
      * Merge similar permission tests
      
      * Merge similar tests into one
      
      * Use sidebar test ID in permissions test
      
      * Select by .AdminSelect
      
      * Remove redundant search test case
      
      * Revert native query test
      
      * Add React list key to ItemPicker items
      
      * Add collection suggestions tests
      
      * Configure Form's `overwriteOnInitialValuesChange`
      
      * Wrap CollectionSelect with `@Collection.loadList`
      
      When suggesting an initial collection,
      we need to check a user has `write` access to it.
      For that, collection objects have to be present in Redux store,
      so we can retrieve a collection by ID and check the `can_write` flag
      
      * Allow modifying CreateDashboardModal's onSave prop
      
      * Fix collection suggestsions for new dashboard
      
      * Fix collection suggestions when copying dashboards
      
      * Add defaultProps to Form
      
      * Fix SaveQuestionModal unit test
      
      * Fix SaveQuestionModal collection suggestion
      
      * Simplify CollectionSelect wrapper
      
      * Fix dashboard header test selector
      
      * Rename permission tests
      
      * Mock HTTP requests at SaveQuestionModal test
      
      * Pass correct params to initialCollectionId
      Unverified
      27726dbb
  8. May 05, 2021
  9. May 04, 2021
Loading