This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 14, 2021
-
-
Anton Kulyk authored
* Install slugify * Add utils to slugify and parse entity URLs * Add `<Entity.Link />` component Basically just a `<Entity.Name />`, but wrapped inside `<Link />` * Add slugs to `/browse/:databaseId` URLs * Use constant for "Saved Questions" database ID * Fix "Saved Questions" not displayed in breadcrumbs * Fix opening browse page for "Saved Questions" * Add slugs to `/collection/:id` URLs * Fix personal collection page slug * Remove `describe.only` * Remove unnecessary type coercion * Fix typo * Fix collections not highlighted in the sidebar * Add slug to collection `/archive` URL * Add slug to collection `/edit` URL * Add slug to collection `/permissions` URL * Use slug in `getInitialCollectionId` selector * Explicitly pass root ID to `Urls.collection` * Pass prop to EntityLink's Link component * Fix DashboardMoveToast collection link * Allow overwriting EntityLink's Link component * Fix links in QueryBuilder's search * Fix collection link in search results * Fix navigating to collection after question archived * Fix navigating to collection from pulse edit * Slugify users' personal collection URLs * Test slugified collection URLs are opened correctly * Add slugs to `/dashboard/:id` URLs * Fix dashboard URLs at admin public sharing page * Fix opening dashboards from main page * Fix navigation to saved automatic dashboard * Fix dashboard moving * Fix dashboard history * Fix closing dashboard editing modal * Fix dashboard details form is empty Reproduced if opening the form via URL (`/dashboard/:id/details`) Works correctly if the details modal is opened from a dropdown menu * Fix dashboard copy form crash Reproduced if opening the form via URL (`/dashboard/:id/copy`) * Fix copying dashboard * Fix closing dashboard copy modal * Fix navigation once dashboard is created * Replace hardcoded "root" id with a constant * Assert pathnames instead of URLs * Fix duplicate modal not closing automatically * Fix URLs on Activity page * Fix navigating to dashboard question is added to * Fix archiving dashboard * `dashboardId` —> `slug` * Add slugs to `/question/:id` URLs * Fix links to questions on Activity page * Switch questions to slugified URLs * Remove not used import * Update pathname assertion * Fix collection URL builder fails receiving `null` * Ensure question URL builder returns valid URL * Update pathname assertions * Update pathname assertions * Update pathname assertions * Update pathname assertion * Update pathname assertion * Add question URL builder unit tests * Fix collection URL builder * Fix `null` collection ID when building URL * Fix repro test issue reference * Move URLs tests into onboarding folder * Enable #15256 repro test * Fix slugs for edge cases
-
- May 13, 2021
-
-
Alexander Lesnenko authored
* hack table visualization flaky spec * Fix the flake by waiting for the table to update Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
dpsutton authored
not-empty so that we don't output a dumb string like > null DB null connections: null/null (null threads blocked) Also put the call to `name` behind a some-> so there's no NPE. Everything else will just output a null if its missing
-
Gustavo Saiani authored
-
Nemanja Glumac authored
* Install `cypress-real-events` library * Register `cypress-real-events` globally
-
Nemanja Glumac authored
Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
Yoshiki Iida authored
-
- May 12, 2021
-
-
Anton Kulyk authored
* Fix 'Our collection' is suggested only to admins * Fix permission test * Fix test according to new collections behavior
-
Alexander Lesnenko authored
* fix question level link display settings * add cypress spec for the question-level link settings on the table visualization * Address review comments: add a spec for clicn behavior with view_as = link, fix admin column settings * revert a straightforward fix for hiding irrelevant settings * fixup! Address review comments: add a spec for clicn behavior with view_as = link, fix admin column settings * prettier * handle link_text null value
-
Nemanja Glumac authored
* Add Cypress custom command `button` (#16007) * Apply new custom command to the missed occurrences on `master`
-
Ariya Hidayat authored
* Remove stray it.only
-
Ariya Hidayat authored
In this case, to fetch the field type.
-
Ariya Hidayat authored
-
- May 11, 2021
-
-
Luis Paolini authored
* Add Azure Guide * Change links to access the guide * Add Azure AD SAML SSO guide * Fix error in pages * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * A couple of changes proposed by Jeff * Update docs/operations-guide/running-metabase-on-azure.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Wrap connection strings in triple backticks Co-authored-by:
Jeff Bruemmer <jeff@metabase.com>
-
Luis Paolini authored
* Separate steps for faster build * Fix typo
-
Alexander Lesnenko authored
* add global search results pagination * fixup! add global search results pagination * nit fix to allow aleksander test without borking perf too much * fix incorrect question object in the search spec * translate pagination * show filters only for existing types of items for a specified search query * fixup! show filters only for existing types of items for a specified search query * fixup! show filters only for existing types of items for a specified search query * Search pagination models (#15972) * querying the models by a buncha queries * up max filtered response because of limits * archived string and table db id is still a thing cuz of weirdo joins and stuff * shove models given in the normal api endpoint * misplaced docstring * redshift root is actually bonafide different than other roots Co-authored-by:
howon lee <hlee.howon@gmail.com>
-
- May 10, 2021
-
-
Cam Saul authored
* Port legacy data type migrations -> Liquibase * Fix migration IDs * Field type validation/error handling * Have semantic type fallback to nil * Fix semantic-type-migrations-test * Fix migrations * Revert accidental changes
-
Luis Paolini authored
-
Cam Saul authored
* Port legacy data type migrations -> Liquibase * Fix migration IDs * Fix migrations
-
Noah Moss authored
* Add deny list of common passwords * replace filtered pw list with full list * switch to using a FileReader to check password line-by-line * bypass deny list if complexity is set to easy * fix tests * more test fixes and remove unneeded ns * fix typos * fix reflection warning * needed to import File * fix final tests, and update docs to reflect change * address initial review comments * fix build after removing import statement * address more review comments * use InputStreamReader to read password file in JARs
-
Kyle Doherty authored
* add Explore results button * lint
-
dpsutton authored
Update tests in accordance with changed geocode API results ("Begles" -> "Talence") See output of: https://get.geojs.io/v1/ip/geo.json?ip=185.233.100.23 Co-authored-by:
Jeff Evans <jeff303@users.noreply.github.com>
-
- May 07, 2021
-
-
Alexander Lesnenko authored
-
Maz Ameli authored
* reduce tabs font size down to 14px * tweak admin tabs padding * update snapshots
-
Gustavo Saiani authored
* Omit dashboard revision history items if no description * Skip Revert button on topmost visible revision history entry * Test that topmost revision history entry omits Revert button * Lint * Use diff as criterion for omitting revision entry * Detail comment in shouldRenderRevisionHistory * Render revision item if either before or after in diff is populated * Update e2e test * Use a more durable string to find element in test
-
Nemanja Glumac authored
Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
-
- May 06, 2021
-
-
Ariya Hidayat authored
* Make it work with MBQL instead * Update frontend/test/metabase/lib/expressions/typeinferencer.unit.spec.js Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Jeff Evans authored
Add diagnostic info for connection pools to Help page Backend changes: Add org.clojure/java.jmx dependency to project.clj for use in JMX bean querying To troubleshooting.clj, add some functions to capture details from the c3p0 connection pool beans to a map Add new API endpoint to invoke that from util.clj Add content-disposition header to API endpoint to make it a download Frontend changes: In the Help page, add a new paragraph below the existing "Diagnostic Info" JSON blob for advanced details, envisioned as a list of download links (which users can then attach to tickets, etc.)
-
Ariya Hidayat authored
-
Anton Kulyk authored
* Test adding question to dashboard * Test collections filtering when adding a question When adding a question to dashboard, we need to display collections a user has "write" access to. Collection with "read" access have to be hidden * Fix adding question to dashboard without access * Add a note about permissions test suite * Move question permission tests to collection suite * Revert initial collections filtering * Fix adding question to dashboard without access * Remove redundant state field * Enable #15281 issue repro test * Remove requireCollectionWritePermission prop * Filter items user doesn't have `write` access to * Fix permission tests * Fix dashboard test * Fix part of permission tests disabled for nodata user * Bring back issue reference to Cypress test * Remove underscore prefixes for component methods * Test offers saving dashboard to opened collection * Fix tests nested incorrectly * Split dashboard permission test * Fix suggest saving items to read-only collections * Fix collection permission filtering See comment: https://github.com/metabase/metabase/pull/15613#discussion_r614460504 * Move comment * Fix test failing due to fixed collection suggestion * Remove `should("exist")` from Cypress tests * Merge "adding question to dashboard" tests * Merge similar permission tests * Merge similar tests into one * Use sidebar test ID in permissions test * Select by .AdminSelect * Remove redundant search test case * Revert native query test * Add React list key to ItemPicker items * Add collection suggestions tests * Configure Form's `overwriteOnInitialValuesChange` * Wrap CollectionSelect with `@Collection.loadList` When suggesting an initial collection, we need to check a user has `write` access to it. For that, collection objects have to be present in Redux store, so we can retrieve a collection by ID and check the `can_write` flag * Allow modifying CreateDashboardModal's onSave prop * Fix collection suggestsions for new dashboard * Fix collection suggestions when copying dashboards * Add defaultProps to Form * Fix SaveQuestionModal unit test * Fix SaveQuestionModal collection suggestion * Simplify CollectionSelect wrapper * Fix dashboard header test selector * Rename permission tests * Mock HTTP requests at SaveQuestionModal test * Pass correct params to initialCollectionId
-
- May 05, 2021
-
-
Cam Saul authored
* Druid Docker image [WIP] * More Druid Docker stuff [WIP] * Test fixes
* Remove maxRowsQueuedForOrdering from query, don't think we need it * Force test Druid host -> localhost for now * Update sync tests for updated test data * Revert unused changes -
Cam Saul authored
-
Howon Lee authored
Whacks in search changes for backend needed in #15768 and #15738. Also whacks in the changes for frontend needed in #15738 but not for #15768.
-
Nemanja Glumac authored
* Handle errors in `ColorSchemeWidget.jsx` * Handle errors in `audit_app/routes.jsx` * Fix missing key prop warnings * Turn on `react/jsx-key` lint rule Co-authored-by:
alxnddr <alxnddr@gmail.com>
-
Nemanja Glumac authored
* Allow multiple `--spec` arguments in Cypress `run` command (#15917) * Split e2e CI groups (#15924) * Add option to choose between source-folder and test-files in CCI * Rearrange Cypress files * Split e2e workflows * Split native queries into a separate CI group
-
Anton Kulyk authored
* Change site-url description copy * Display part of site-url description as bold text * Replace custom description with warningMessage prop
-
- May 04, 2021
-
-
Jeff Evans authored
Similar to #15664, update the applicationName to include the local process identifier Updating test accordingly
-
Jeff Evans authored
How does Lisp work, again?
-
Luis Paolini authored
* Update 13-embedding.md * Update docs/administration-guide/13-embedding.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update 13-embedding.md * Update docs/administration-guide/13-embedding.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/administration-guide/13-embedding.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff@metabase.com>
-
Luis Paolini authored
-