Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 17, 2023
    • lbrdnk's avatar
      Add metabase_field semantic_type migration (#34664) · 07b74ebd
      lbrdnk authored
      * Update migration and add test
      
      Sets semantic_type to null for metabase_field if value was type/Number,
      to avoid log warnings.
      
      * Remove test for trivial migration as suggested
      
      As migration tests are costly and change is trvial, it is better
      to test small migration as one in question manually. Hence removing
      the test.
      07b74ebd
    • metamben's avatar
      Enable column-filter, disable distribution and summarize-column drills for... · 269e19d6
      metamben authored
      Enable column-filter, disable distribution and summarize-column drills for aggregated columns (#34681)
      
      269e19d6
    • metamben's avatar
    • Cam Saul's avatar
    • Nicolò Pretto's avatar
      remove typo from docs (#34732) · d7c93548
      Nicolò Pretto authored
      d7c93548
    • Kamil Mielnik's avatar
      Add custom warning message when leaving creating an SQL question (#34696) · f7cf34e2
      Kamil Mielnik authored
      * Update isNavigationAllowed logic to prevent new model creation
      
      * Add simple model creation test
      
      * Remove identifier
      
      * Update comment
      
      * Add a test case for saving a new model
      
      * Avoid using fetchMock directly in QueryBuilder unit tests
      
      * Remove setupCollectionsEndpointsByIds in favor of setupCollectionByIdEndpoint
      
      * Add native question test base
      
      * Update isNavigationAllowed tests
      
      * Make isNavigationAllowed tests pass
      
      * Update shouldShowUnsavedChangesWarningForSqlQuery logic to account for new questions
      
      * Add a test case to run new native question
      
      * Update mock to include individual collection GET endpoint
      
      * Add DataSourceSelectors to MockNativeQueryEditor
      
      * Update test beforeunload event to reflect new behavior
      
      * Use setupCollectionByIdEndpoint instead of modifying setupCollectionsEndpoints
      
      * Update failing test
      
      * Use serializeCardForUrl
      
      * Add a test for native query editing
      
      * Do not trigger warning when leaving empty question
      
      * Add beforeunload tests for creating new questions
      
      * Remove redundant div
      
      * Make assertions consistent
      
      * Use single resetAllMocks()
      
      * Fix post-rebase conflict
      
      * Work around Cypress not handling beforeunload-related prompts
      
      * Our app registers beforeunload event listener e.g. when editing a native SQL question.
      * Cypress does not automatically close the browser prompt and does not allow manually
      * interacting with it (unlike with window.confirm). The test will hang forever with
      * the prompt displayed and will eventually time out. We need to work around this by
      * monkey-patching window.addEventListener to ignore beforeunload event handlers.
      *
      * @see https://github.com/cypress-io/cypress/issues/2118
      f7cf34e2
    • Nemanja Glumac's avatar
      [CI] Make `Chromatic` workflow 3rd party friendly (#34725) · 45d74606
      Nemanja Glumac authored
      * Make `Chromatic` workflow 3rd-party friendly
      
      * Remove unused output
      
      * Unify the use of `GITHUB_TOKEN`
      
      * Update label check
      
      * Fix wrong token reference
      
      [ci skip]
      45d74606
    • Nemanja Glumac's avatar
      [E2E] Fix broken Replay runs (#34722) · 0d2265b3
      Nemanja Glumac authored
      This was causing scheduled runs to fail due to a
      missing closing quotes in a string.
      
      [ci skip]
      0d2265b3
  2. Oct 16, 2023
  3. Oct 14, 2023
  4. Oct 13, 2023
  5. Oct 12, 2023
Loading