Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 11, 2023
  2. Aug 10, 2023
  3. Aug 09, 2023
  4. Aug 08, 2023
    • Jeff Bruemmer's avatar
      Unverified
      25be72ce
    • Kamil Mielnik's avatar
      Fix - Cannot remove questions when combining questions to create multi-series charts (#32949) · 0f3b3df0
      Kamil Mielnik authored
      * Fix removing series from the legend
      - Fixes #12794
      
      * Use slice instead of filter
      
      * Format code (-1 LOC)
      
      * Refactor AddSeriesModal to TS
      
      * Fix typing error
      
      * Refactor state.state into state.isLoading
      - remove leftover isLoadingMetadata
      
      * Hide the "x" button for the first legend item in the chart in AddSeriesModal
      
      * Fix typo
      
      * Use named export for AddSeriesModal
      
      * Fix dashcardData typing
      
      * Export Props
      
      * Add test boilerplate
      
      * Reduce test setup boilerplate
      
      * Reduce test setup boilerplate
      
      * Add test for the 'x' button
      
      * Add tests for removing series from legend
      
      * Add comprehensive test case
      Unverified
      0f3b3df0
    • Ngoc Khuat's avatar
    • Uladzimir Havenchyk's avatar
      Unverified
      7b6fdbaa
    • Nicolò Pretto's avatar
      fix: cancel ongoing query when removing card from dashboard (#32842) · ba3ec476
      Nicolò Pretto authored
      * fix: cancel ongoing query when removing card from dashboard
      
      * test: #12926 remove card test with xhr.abort stub
      
      * test: use cy.on(fail instead, to specifically expect that request to be aborted
      
      * Revert "test: use cy.on(fail instead, to specifically expect that request to be aborted"
      
      This reverts commit 75e204e8e2c45cc490d79729ee12795ea10291fa.
      
      * refactor: move cancelFetchCardData inside removeCardFromDashboard, which becomes a thunk
      
      * doc jsdocs for should_wait param in visitDashboard
      
      * "undo remove card" re-fetches the card
      
      * test: test for undo -> re-fetch card
      
      * refactor: removed unused param
      
      * revert should_wait on visitDashboard in favor or manually using cy.visit
      
      * artificially slow down requests via cy instead of using pg_sleep
      
      * rename before block
      
      * when undoing remove card, only refetch data if needed
      
      * remove debug console log
      
      * refactor: remove .within call with only one function call inside
      
      * docs: add comment to req.continue
      
      * test: adds assertion that the query data is actually loaded
      
      * remove data already present check as it is already in the thunk
      Unverified
      ba3ec476
Loading