Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 19, 2024
  2. Jun 18, 2024
  3. Jun 17, 2024
    • Alexander Polyankin's avatar
    • Nick Fitzpatrick's avatar
      Search events 1-1-0 (#44314) · 1c83904e
      Nick Fitzpatrick authored
      * search events 1-1-0
      
      * backwards compatible adjustment
      
      * making context optional
      1c83904e
    • Jesse Devaney's avatar
      Fix incorrect goal line plotting when using non-linear y-axis scales (log/pow) (#44320) · 7f19247f
      Jesse Devaney authored
      * refactor: de-duplicate variable usage
      
      * fix incorrect goal-line plotting in pow and log y-axis scales
      
      * add Loki variants to validate and enforce desired behavior
      
      * update loki snapshots
      7f19247f
    • Case Nelson's avatar
      Change run to make-run in process-query-for-card (#44244) · ea9dfd1d
      Case Nelson authored
      * Change run to make-run in process-query-for-card
      
      Fixes #44160
      
      There were two levers where a card could change how it was run.
      
      `qp` this is basically `qp/process-query` with some optional userland
      flags and constraints marked on the passed in query.
      In the case of pivot tables in the
      `/pivot/:card-id/query` endpoints it was `qp.pivot/process-query`
      
      'run' this defaults to a streaming response that takes the `qp` param
      and `export-format` and passes a query to qp. Most often this is
      overriden to not stream the response.
      
      Unfortunately, if `run` is overwritten, then `qp` is thrown away, and
      the caller who overrides `run` must determine the correct `qp` to use.
      
      However, when running `process-query-for-dashcard` it is difficult to properly set
      `qp` for all of the dashcards without doing card lookups. So [this commit](https://github.com/metabase/metabase/blob/release-x.50.x/src/metabase/query_processor/card.clj#L230-L232) did a check to swap the runner in the presence of a pivot query that calls the **default** runner with a `qp.pivot/run-pivot-query`. The problem is that pulse needs to use a non-default runner, but there's no way for `process-query-for-card` to do both.
      
      This commit changes `run` to `make-run` which raises the abstraction to
      a function that produces a runer given a `qp`. This allows
      `process-query-for-card` to change the `qp` as needed while keeping the
      passed in runner.
      
      There's really three things going on that could be teased apart
      further/better.
      
      1. `qp` - this conflates the processor (`qp/process-query` `qp.pivot/run-pivot-query`)
        and modifying query (`qp/userland-query`,
        `qp/userland-query-with-default-constraints` `(update query :info merge info)`)
      2. `make-run` - How the above are processed: (streaming/realized)
      
      * Fix tests
      ea9dfd1d
    • Alberto Perdomo's avatar
      Update SDK README.md (#44292) · 66a189f7
      Alberto Perdomo authored
      Tweak the callout about the SDK still being in development
      66a189f7
    • Alex Yarosh's avatar
      remove audit mentions (#44309) · f8298e49
      Alex Yarosh authored
      f8298e49
    • Raphael Krut-Landau's avatar
      fix: Remove references in the FE to the deprecated `enable-query-caching` setting (#44263) · 01db0a2a
      Raphael Krut-Landau authored
      * wip
      
      * Remove references to the old enable-query-caching setting
      
      * remove fixme
      
      * linter
      
      * remove some more instances
      
      * fix imports
      01db0a2a
Loading