This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 11, 2024
-
-
John Swanson authored
* Fix some minor collections issues - explicitly provide access to the trash to all users, in the same way we provide access to personal collections. Due to migration order, we don't necessarily have a permissions row with the correct `perm_type`, `perm_value`, and `collection_id` for the Trash collection. That's ok - we don't actually move things to the Trash, so there isn't any item where `collection_id=$trash.id` - but this may affect things like effective ancestors for children of the trash. Let's be explicit about the permissions that users have. - replace a case where we manually calculated effective location and then got the parent_id with just hydrating `:effective_parent`. This is more efficient. - replace the simple hydration method for `effective-location-path` with a batched hydration method that fetches `visible-collection-ids` *once* and then uses it to figure out the effective location path for each collection passed.
-
Jeff Bruemmer authored
-
Cam Saul authored
-
Raphael Krut-Landau authored
This PR tests that the user can assign any of three cache invalidation strategies ("duration", "adaptive", and "don't cache") to dashboards and questions. The tests check that the following things are true: * These strategies can be applied directly (via the sidebar) * Dashboards and questions can inherit their caching strategy from the database that underlies them * Dashboards and questions can inherit their caching strategy from the instance-wide default policy * When a question inside a dashboard has been assigned a strategy, this is overridden by the strategy assigned to the dashboard. What these tests do not examine: * the schedule strategy * the minimum query duration * edge-case strategies, such as very long durations or very large values for the adaptive strategy multiplier These may be addressed in follow-up work. Closes #45355
-
Mahatthana (Kelvin) Nomsawadi authored
-
Romeo Van Snick authored
* Alway render models and metrics links * Remove useHasMetrics and useHasModels helpers' * Update metrics test for metrics in sidebar * Fix unit test * Fix e2e tests
-
Aleksandr Lesnenko authored
* fix static visualizations dashcard settings merging * cleanup, fix types * drop an empty file
-
- Sep 10, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
metamben authored
Fixes #47735
-
John Swanson authored
* Move stale endpoint to /ee/stale/${collection-id} It's an enterprise-only endpoint, so it makes sense to put the whole thing under enterprise. * refactors ui to use ee stale endpoint lint fixes, change endpoint location fix failure e2e test * Fix endpoint location --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
John Swanson authored
* Don't encrypt `site-locale` * Fix test for `site-locale` The previous test required encryption. Theoretically the referenced error just depends on the fact that something is logged during the process of getting the value, so I reworked it to depend on that directly rather than triggering it through an encryption key rotation.
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add metric actions * Fix dot menu width * Refetch card when it's being (un-)bookmarked * Add tests for metric dot menu * Make sure bookmarked metric appears in sidebar * Make sure restoring a metric works * Add more tests for readonly users * Use non-root collection for metric test * Render Scalar metric values * Add tooltip * Render Scalar metric value using formatValue * Move isMetricScalar and getMetricValue to utils * Add e2e tests for scalar metric values * Fix unit tests * Add card query endpoint to metabase/api * Use card query from api instead of question loader * Add test for non-numeric scalar metric * Move providesCardQueryTag to utils * Use skipToken for query * Clean up getDatasetScalarValueForMetric
-
Chris Truter authored
-
Chris Truter authored
-
Chris Truter authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add metric actions * Fix dot menu width * Refetch card when it's being (un-)bookmarked * Add tests for metric dot menu * Make sure bookmarked metric appears in sidebar * Make sure restoring a metric works * Add more tests for readonly users * Use non-root collection for metric test
-
- Sep 09, 2024
-
-
Aleksandr Lesnenko authored
* show additional columns in the tooltip * specs, tweaks * drop stack dependency * handle invalid columns * change copy
-
Braden Shepherdson authored
Fixes #45938. Remapping is handled at the top level of the query, and should be ignored for inner queries. This PR hides it from `results_metadata` on source queries. It also fixes the interaction with `large-int-id` logic to make big integers JS-safe.
-
Oleksandr Yakushev authored
-
Ryan Laurie authored
* Question Settings Sidesheet (#47699)
-
metamben authored
Fixes #4755
-
Anton Kulyk authored
* Add series visibility props to `ChartWithLegend` * Mark pie slices as visible or hidden * Don't let to hide the last visible slice * Add space between legend dot and title * Fix legend dot outer circle is clipped by overflow * Use `ChartSettingSeriesOrder` for `pie.rows` setting * Actually hide slices and exclude from total calc * Don't show "0%" next to hidden slice legend items * Hide the "Other" slice * Make overflow slices popover interactive * Fix hover * Fix incorrect visibility state in legend popover * Add e2e test * Remove debug stuff * Fix hover and drill issues with slice index calc * Fix `pie.rows` ordering bug * Revert "Fix hover and drill issues with slice index calc" This reverts commit f104aaa5. * Fix hover and drill issues with slice index calc (2) `dataIndex` based approach * Use a special data key for the "Other" slice * Fixed viewport size in legend e2e test * Fix jumping legend width * Fix dot and label vertical alignment * Rework pie e2e test * Fix legend dot and label alignment
-
Emmad Usmani authored
* handle errors without crashing in SliceNameWidget * add test
-
Case Nelson authored
* fix: bigquery add null checks to result processing Fixes #47339 On the related issue there are different stacktraces indicating likely sources of null pointer exceptions. 1. `.getNextPage` is likely returning a nil value. I was unable to reproduce this but one thing I did notice is that `hasNextPage` is recommended over checking `.getNextPageToken`. Added nil handling around `page` possibly being nil. 2. `cancel-chan` may be triggered before processing begins and such `execute-bigquery` would pass nil as a TableResult to the initial reducer. Testing if cancel-chan happens at just the right moment would be too flaky for CI testing but I was able to reproduce this locally and is fixed by the nil handling added. 3. `cancel-chan` may be triggered during query processing. This is covered by a test now. * Check hasNextPage in test: * Add test for null getNextPage * Fix cljfmt
-
github-automation-metabase authored
-
Phoomparin Mano authored
* remove legacy queries from static question in sdk * remove second query argument * remove the databaseSupportsPivotTables check from isSensible
-
Anton Kulyk authored
* Add repro * Update `isValid` check for metrics and dimensions * Fix unit test
-
Phoomparin Mano authored
-
Romeo Van Snick authored
* Add custom image for empty metrics * Add useFetchMetrics helper * Copy browse models page to metrics page * Add route for browse metrics page * Add useHasMetrics hook * Add link to browse metrics page to the sidebar * Simplify MetricsTable component * Render description markdown in table too * Add unit tests for browse metrics page * Remove custom padding * Fix line height of markdown cell * Add e2e tests for browse page * Fix metrics sorting * Fix types * Fix column widths and cell padding * Typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Remove name check * Simplify alphabet * Remove resetSnowplow * Use helper to get metric in table * Use MouseEvent from React directly * Use --mb-color-icon-primary * Test ellipsification of description * Simplify useHasMetrics * Move useHasMetrics MainNavBar * Merge sortMetrics and sortModels into sortCards * Fix metric default description * Extract SidebarSkeleton to a separate component * Test sorting via Collection too * Use ModelTableRow to fix cursor * Share more components between ModelsTable and MetricsTable * Use the same simplified structure in ModelsTable as for MetricsTable * Render block-level elements as inline so ellipsis detection works * Pick better testid for metric name * Remove delay * Avoid type specificty error in sortCards * Add test for not opening in new tab * Remove useFetchMetrics defaults * Fix unit test import * Test meta-click with cypress * Add comment on inline markdown elements * Use model-name test id * Use correct colors for icon * Remove delay from browse models page too * Make meta key in test platform-dependent * Fix hover color on metrics table * Add focus styling for celss in the models and metrics table * Use MarkdownPreview for table cells * Define --mb-color-icon-primary * Make the collection link take up the whole height of the cell * Remove tabIndex from table rows * Rename ModelsTable.module.css to BrowseTable.module.css * Rename CardsTable to BrowseTable * Remove single module.css class in favor of styled components * Allow customising allowed elements * Allow forcing all markdown on one line * Render bold and italics in markdown descriptions and move content onto one line * Fix legacy tooltip in test * Make sure getValueForSorting returns a string * Remove empty file * Remove icon for metrics in the table * Remove else statement. Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Remove async findBy where possible * Add github issue link for TODO item * Disambiguate between getMetricDescription type * Be explicit with sortModelOrMetric --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Alexander Solovyov authored
-
- Sep 07, 2024
-
-
Oisin Coveney authored
* Fix entity ID status * bump ci --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
- Sep 06, 2024
-
-
Oisin Coveney authored
-
Noah Moss authored
-
Ryan Laurie authored
* Basic Sidesheet Components * sidesheet samples and storybook stories * add unit tests and fix more imports * small styling updates * small styling updates * fix tests * Update frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> * fix type problem --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
-
Noah Moss authored
-
Alexander Polyankin authored
-