Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 11, 2024
    • John Swanson's avatar
      Fix some minor collections issues (#47472) · 0c4a3f8a
      John Swanson authored
      * Fix some minor collections issues
      
      - explicitly provide access to the trash to all users, in the same way
      we provide access to personal collections. Due to migration order, we
      don't necessarily have a permissions row with the correct `perm_type`,
      `perm_value`, and `collection_id` for the Trash collection. That's ok -
      we don't actually move things to the Trash, so there isn't any
      item where `collection_id=$trash.id` - but this may affect things like
      effective ancestors for children of the trash. Let's be explicit about
      the permissions that users have.
      
      - replace a case where we manually calculated effective location and
      then got the parent_id with just hydrating `:effective_parent`. This is
      more efficient.
      
      - replace the simple hydration method for `effective-location-path` with
      a batched hydration method that fetches `visible-collection-ids` *once*
      and then uses it to figure out the effective location path for each
      collection passed.
      Unverified
      0c4a3f8a
    • Jeff Bruemmer's avatar
      update api docs (#47851) · 655b38dd
      Jeff Bruemmer authored
      Unverified
      655b38dd
    • Cam Saul's avatar
    • Raphael Krut-Landau's avatar
      ci(admin/performance): Test several caching strategies and methods (#45231) · 0833bebb
      Raphael Krut-Landau authored
      This PR tests that the user can assign any of three cache invalidation strategies ("duration", "adaptive", and "don't cache") to dashboards and questions. The tests check that the following things are true:
      * These strategies can be applied directly (via the sidebar)
      * Dashboards and questions can inherit their caching strategy from the database that underlies them
      * Dashboards and questions can inherit their caching strategy from the instance-wide default policy
      * When a question inside a dashboard has been assigned a strategy, this is overridden by the strategy assigned to the dashboard.
      
      What these tests do not examine:
      * the schedule strategy
      * the minimum query duration
      * edge-case strategies, such as very long durations or very large values for the adaptive strategy multiplier
      
      These may be addressed in follow-up work.
      
      Closes #45355
      Unverified
      0833bebb
    • Mahatthana (Kelvin) Nomsawadi's avatar
    • Romeo Van Snick's avatar
      Always show metrics and models in menu (#47723) · e45836b8
      Romeo Van Snick authored
      * Alway render models and metrics links
      
      * Remove useHasMetrics and useHasModels helpers'
      
      * Update metrics test for metrics in sidebar
      
      * Fix unit test
      
      * Fix e2e tests
      Unverified
      e45836b8
    • Aleksandr Lesnenko's avatar
      fix static visualizations dashcard settings merging (#47789) · 1baad2a1
      Aleksandr Lesnenko authored
      * fix static visualizations dashcard settings merging
      
      * cleanup, fix types
      
      * drop an empty file
      Unverified
      1baad2a1
  2. Sep 10, 2024
  3. Sep 09, 2024
  4. Sep 07, 2024
  5. Sep 06, 2024
Loading