This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 17, 2023
-
-
Anton Kulyk authored
* Sort `ActionForm's` utils * Remove not used actions entity constants * Move `QueryActionContextProvider` to its own dir * Consolidate `QueryActionContextProvider` utils * Move `QueryActionEditor` to `QueryActionContext` * Add `metabase/actions/constants` * Remove not used export * Move `isEditableField` to `ActionForm` utils * Remove not used `hasImplicitActions` utility * Use `WritebackImplicitQueryAction` type * Remove `isImplicitAction` utility * Move `shouldPrefetchValues` to parameters form * Fix typo * Move `getSubmitButtonColor` to shared utils * Move `getSubmitButtonLabel` to shared utils * Sort `ActionParametersInputForm` imports * Move `reorderFields` to `ActionForm` * Sort `metabase/actions/utils` imports * Sort imports
-
Ngoc Khuat authored
* `db/select-one-id` -> `t2/select-one-pk` * add discourage var
-
Ngoc Khuat authored
* db/select-one-field -> t2/select-one-fn * add discourage var
-
Mark Bastian authored
Exposes models as a GenericTable and adds in UI menu option to show the x-ray. There's still work to be done to add filters and more interesting auto-generated charts, but this is the first step.
-
Mark Bastian authored
Minor point version updates, including the redshift driver.
-
Cal Herries authored
* Transform card data into the same format as that which comes out of the DB * Use `from-json` instead of toucan transformations * Remove unused require * Update docstring and rename to from-parsed-json * Oops, fixed * Remove now * Add docstring * Fix order of docstring * Don't update created_at and updated_at
-
Nemanja Glumac authored
* Extract `parseArguments` into utils * Allow custom browser for Cypress snapshots generation
-
Nick Fitzpatrick authored
-
Nemanja Glumac authored
* [CI] Do not run `i18n` workflow on spec changes * Reverse the order of `name` and `run`
-
Nemanja Glumac authored
-
- Mar 16, 2023
-
-
Nick Fitzpatrick authored
* Updating graph.metrics when column is removed * updating logic and adding unit tests
-
Emmad Usmani authored
-
dpsutton authored
* Ensure we use the ssh tunnel on action execution I'm gonna see if we have an existing way to run tests against ssh dbs. I see there are some tests that use a faking ssh server. Not sure if those are useful or not. But otherwise ssh stuff needs out of process help to accomplish so not sure if it's easily feasible right now * introduce new `with-unpooled-connection-spec` macro it is identical to the `with-connection-spec-for-testing-connection` macro but has a better name. In the future they could diverge as testing requirements and action requirements change. But we want that _implementation_ (which correctly uses tunnels), but we do not want a "testing connection" slug in the usage. In the future (or now if we prefer a different name) we can rename it, find the usages that are not testing vs the ones that are, etc. * tests for actions over ssh * unused require of mb.u.ssh had brought it in but then stuffed all of this inside of `with-unpooled-connection-spec` so no need to worry about ssh, closing it, ensuring the port is there, etc. * Don't test h2 with ssh tunnel details lack a host and it npe's in the ssh tunnel stuff. No big loss as ssh on h2 is not supported (due to this error, and probably many more) * Switch to toucan2 for db access in tests * Use connection pool for custom actions connection Was originally using `jdbc/get-connection` from the details of the db. This was a one-off non-pooled connection that also did not reuse ssh tunnels. I thought the one-off connection was important since it is not read only, but that's not the case. So we can reuse the exact same mechanism that the implicit actions are using with `metabase.driver.sql-jdbc.actions/with-jdbc-transaction`. * cyclic dependency almost moved it into execute, but that gives a very inviting `sql-jdbc.execute/with-jdbc-transaction`. Welcoming even. But `sql-jdbc.actions/with-jdbc-transaction` lets you know its only for transactions.
-
metamben authored
* Add filter constructor functions * Revert changes to defop * Address linter complaints * Add function to set the query filter * Address linter complaints * Fix test name
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Case Nelson authored
* Add an aggregate function to add aggregations to queries * Call ->op-arg on aggregate input * Allow any in aggregations for now because expressions on aggregates are allowed * We have to recurse into clauses
-
Natalie authored
-
Jerry Huang authored
* add permissions and test * address comments * fix whitespace * remove ehitespace * revert vscode changes
-
Tim Macdonald authored
-
Nemanja Glumac authored
-
Denis Berezin authored
* Refactored ExpressionWidget, ClauseStep components to TS (#28687) * Implement new UI design, add unit tests (#28776) * Add design changes to ExpressionWidget * Add new design for ExpressionEditorHelpText (#28920) * Add expression function arguments interactivity (#28966) * New design for expression editor info link (#29113)
-
Anton Kulyk authored
* Fix empty database picker state * Remove redundant `requireWriteback` occurrences * Update test * Update test * Use clearer names * Don't show query language message for actions * Use database `hasActionsEnabled` method * Remove `requireWriteback` prop * Respect `readOnly` prop in `DataSourceSelectors` * Extend e2e test coverage * Use `setActionsEnabledForDB` in Cypress * Fix data picker behavior
-
Nemanja Glumac authored
-
- Mar 15, 2023
-
-
Jeff Bruemmer authored
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Ryan Laurie authored
-
Ryan Laurie authored
* remove 'category' as a field type, because it isnt * update types
-
Ngoc Khuat authored
-
- Mar 14, 2023
-
-
Bryan Maass authored
* defendpoint auto coercion :arrow-heading-up::gear: * annotate all the id fields on the api with ms/Id * mark nillable "boolean" * update shape of action map - also improve the error messages with "recieved: _" * oh yeah! there are like 20 more *id*'s! * fix docstring + parse numbers properly * rename IntGreaterThanZero -> PositiveInt - remove ms/Id * fiddle with test wording * add regexes into compojure routes to avoid arbitrary route matching * tests for compojure route disambiguation w/ regex * trivial change to kick CI * minor refactor + update docstring * add nil condp default case * fix linter errors that snuck through .. somehow * fix typo + update tests that no longer regex-match
-
Tim Macdonald authored
-
Ryan Laurie authored
* Allow linkviz to show recent item suggestions * unit test recent link adding * oops
-
Tim Macdonald authored
* Users can execute actions if they can read the model and the DB is not blocked [Fixes #28425]
-
Anton Kulyk authored
* Handle data permission error for dashboard actions * Extract `setupUnauthorizedDatabaseEndpoints` * Type error as `unknown`
-
Nick Fitzpatrick authored
* adding hasMultipleDimensions check to hasLegend clause * Adding queryBuilderMain helper * PR Feedback * remove only
-
Mark Bastian authored
Updated module versions along with a few updated main deps.edn libs. Also added the outdated task to the deps file and fixed in place the nrepl and shadow-cljs nrepl ports.
-
Bryan Maass authored
-
Austin Lai authored
-