Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 30, 2022
  2. Jan 26, 2022
    • Jeff Evans's avatar
      Support overriding ROWCOUNT for SQL Server (#19267) · 802cc236
      Jeff Evans authored
      * Support overriding ROWCOUNT for SQL Server
      
      Add new "ROWCOUNT Override" connection property for `:sqlserver`, which will provide a DB-level mechanism to override the `ROWCOUNT` session level setting as needed for specific DBs
      
      Change `max-results-bare-rows` from a hardcoded constant to a setting definition instead, which permits a DB level override, and move the former constant default to a new def instead (`default-max-results-bare-rows`)
      
      For `:sqlserver`, set the DB-level setting override (if the connection property is set), via the `driver/normalize-db-details` impl
      
      Add test to confirm the original scenario from #9940 works using this new override (set to `0`)
      
      Move common computation function of overall row limit to the `metabase.query-processor.middleware.limit` namespace, and invoke it from execute now, called `determine-query-max-rows`
      
      Add new clause to the `determine-query-max-rows` function that preferentially takes the value from `row-limit-override` (if defined)
      Unverified
      802cc236
  3. Dec 21, 2021
  4. Dec 03, 2021
  5. Mar 26, 2021
    • Jeff Evans's avatar
      Update MS SQL Server JDBC driver version (#15287) · d6765a11
      Jeff Evans authored
      Bump mssql-jdbc version from 7.4.1.jre8 to 9.2.1.jre8
      
      Bump plugin version accordingly
      
      Override prepared-statement and statement multimethods for :sqlserver to not set holdability at the statement level
      
      Fixing inaccurate log statements
      Unverified
      d6765a11
  6. Aug 17, 2020
  7. Nov 13, 2019
  8. Dec 12, 2018
Loading