This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 10, 2024
-
-
metabase-bot[bot] authored
* Restore tabs display for embedded dashboard without title * Add unit test * Remove empty file --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
These type checks are useful when constructing clauses with full MLv2 metadata available, but when converting from legacy the `:field` refs have only `:base-type`. If a column has its metadata overridden to eg. coerce a string or integer into a date, its `:base-type` will remain `:type/Integer` or `:type/Text` and the `:effective-type` will be `:type/Date` etc. This change skips the type check while converting from legacy, and while checking `can-run`. Eventually this should be replaced with tracking `:effective-type` on refs or using real metdata, instead of relying on the `:base-type` only. Fixes #41122. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
- Apr 09, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Update RTL to v12 * fixing unit tests --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
metabase-bot[bot] authored
I have edited the list of "Download results." Co-authored-by:
Abed Habli <154609371+abdhabli@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- Apr 08, 2024
-
-
metabase-bot[bot] authored
* Group axes with the correct map shape. Prior to this, any time axes were all explicitly set :left or :right by the user, the `group-axes-at-once` function would incorrectly return the map in the following form: `{:left ["a" "b" "c"]}` which is incorrect. It must instead look like this: `{"a" :left "b" :left "c" :left}` This fixes the map shape and permits the user to explicitly set all axes to the left or to the right. * Add a test to confirm the axis settings are respected and do render Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
This logic was trying to match `[name join-alias]` pairs previously, but that won't work since the later stage field doesn't have a `:join-alias` on it. This falls back to matching on only the ID or name, but only if it's unambiguous. See #40252. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
- Apr 07, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Apr 05, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
* Enable not emptyable arguments for is-empty and not-empty clauses (#40957) * Enable not emptyable arguments for is-empty and not-empty clauses * Add review remarks * Shorten dataset name so it is usable with some drivers * Disable test for Athena * Handle possibly missing base type * Update comment * Missing base type field is treated as not emptyable * Update desugar middleware Now middleware adds base type to fields with integer id that are missing that first. This ensures correct function of is-empty expansion. * Update desugar middleware Cleanup base types necessary for desugaring is-empty * Update desugar middleware cleanup * Update test * Adjust tests * Remove now redundant e2e test * Update comment * Backport new emptyable definition and derivates --------- Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
- Apr 04, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Cleanup creator sentiment and follow up email code (#39016) * creator sentiment cleanup * change setting to be survey-enabled * fix test * change send-creator-sentiment-emails * Creator sentiment emails iterate (#40922) * Send creator emails every week mod the email by 52 instead of by 12 and use the current week as an anchor ```clojure user=> (require '[java-time.api :as t]) nil user=> (let [every-day (take 1000 (t/iterate t/plus (t/local-date 2024 1 1) (t/days 1))) f (fn [d] (let [wf (java.time.temporal.WeekFields/of (java.util.Locale/getDefault))] (.get d (.weekOfWeekBasedYear wf))))] (sort (keys (frequencies (map f every-day))))) (1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52) ``` ```clojure user=> (metabase.util.cron/cron-string->schedule-map "0 0 2 ? * 7") {:schedule_minute 0, :schedule_day "sat", :schedule_frame nil, :schedule_hour 2, :schedule_type "weekly"} ``` * fix typo in creator sentiment email, clean up a bit typo: had `:verison` instead of `version`. And while I'm in there, make the payload all in one file and have the email namespace json->bytes->b64-encode so the data is all in one place and the setting that allows it to be present or not is co-located. --------- Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
dpsutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
* Fix embedding (#40841) * Fix overflow static dashboard * Fix `frame` event's height for interactive dashboards * Fix E2E tests * Fix test names to match the correct GitHub issue numbers * Use `data-element-id` for consistency * Make the test selector more consistent * Use the new backported util from master --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
metabase-bot[bot] authored
* Add backport resolution script * backport #40767 to 49 --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Apr 03, 2024
-
-
metabase-bot[bot] authored
* fix indent in referencing models * remove syntax highlighting for now Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
* Make Noah the codeowner for permissions et al et al = `integrations` (OSS google auth, LDAP and Slack integrations) + `enterprise` (audit, advanced SSO, advanced config stuff). `enterprise` also has LLM which doesn't really have a codeowner now, but it also doesn't need one. * Correct the paths and the scopes Co-authored-by:
Lena <125455699+darksciencebase@users.noreply.github.com>
-
metabase-bot[bot] authored
* Clarify that backport/no-backport is an internal thing A few times per month, external contributors ask about the notion doc they can't access and about the labels they are not expected to set. This is not the experience we should give to people who not only take their time to contribute to metabase, but also actually read the PR template. (slightly duplicated condition in the beginning and the end of the paragraph — "For those employed [...] If you're not employed [...]" — is on purpose) * Add linebreaks in PR template --------- Co-authored-by:
Lena <125455699+darksciencebase@users.noreply.github.com> Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
metabase-bot[bot] authored
* Map row id on object detail id * Add a fallback * Add e2e test * Add a limit * Provide a fix for #34070 * Simplify test Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
* Do not put js code into page title * Typecheck * Add e2e test * Update e2e/test/scenarios/question/document-title.cy.spec.js --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
-
- Apr 02, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Maz Ameli <maz@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Add repro test for a model that uses another model and both have custom column with the same name (#40851) (#40917) * Add repro test for a model that uses another model and both have custom column with the same name * Skip test * Update e2e/test/scenarios/models/reproductions/39150-model-with-same-custom-column-name.cy.spec.js * Update e2e/test/scenarios/models/reproductions/39150-model-with-same-custom-column-name.cy.spec.js * Convert to ts and add question --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
metabase-bot[bot] authored
# Conflicts: # frontend/src/metabase/collections/containers/CollectionContent.jsx Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Add repro for "Dashboard filters do not work with custom columns on saved questions used in models" (#40784) (#40893) Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
* Add a repro for 'GUI model joining native ones break with column not found error' * Rename test * Add await * Skip test Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
- Apr 01, 2024
-
-
metabase-bot[bot] authored
* Remove database prompt banner (#40648) * Remove location prop from AppBanner --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-