Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 14, 2023
  2. Aug 01, 2023
  3. Jun 27, 2023
  4. Jun 21, 2023
  5. Jun 13, 2023
  6. Jun 08, 2023
  7. May 11, 2023
  8. May 03, 2023
    • Cal Herries's avatar
      Use display name from model for implicit actions (#30356) · 8aa2cc2f
      Cal Herries authored
      * Use display name from card for implicit actions
      
      * Remove fields arg from generateFieldSettingsFromParameters
      
      * Update implicit action test to include display-name
      
      * Tidy
      
      * Fix unit tests
      
      * Fix e2e test
      
      * Only include display-name in the parameters for implicit action types
      
      * Use `field.displayName()`
      
      * Fix some tests
      
      * Attempt to fix test
      
      * Fix ActionParametersInputForm unit tests
      
      * Only generate field settings from parameters if action.type is implicit
      
      * Fix e2e tests
      
      * Fix unit tests
      
      * Fix tests
      8aa2cc2f
  9. Mar 29, 2023
    • Braden Shepherdson's avatar
      [MLv2] Move template tag extraction into CLJC for use from BE (#29526) · 900651ca
      Braden Shepherdson authored
      This supports both parsing out the tags and constructing the template tags map, with `card-id` and all.
      
      This is not quite a FE no-op because the humanization of text is slightly different between `metabase.util.humanization` and the JS humanization library.
      
      This improves JS<->CLJS conversion to handle UUIDs and be smarter about enums, both of which were needed to handle converting template tag maps.
      
      Extracted a `js=` test helper to `metabase.test.util.js/=` since many tests need to compare JS objects, which are not JS `==` to each other.
      900651ca
  10. Mar 24, 2023
    • Nick Fitzpatrick's avatar
      Update to Cypress 12 (#29396) · ecbaf616
      Nick Fitzpatrick authored
      * Updating to cypress 12
      
      * updating deps
      
      * Updating Tests. Be Green Plz
      
      * removing custom test id from select button
      
      * Select Button Tuning
      ecbaf616
  11. Mar 20, 2023
  12. Mar 15, 2023
  13. Mar 13, 2023
  14. Mar 10, 2023
    • dpsutton's avatar
      List actions endpoint (#29055) · d2e893dd
      dpsutton authored
      
      * List all actions
      
      previously `api/action` required `?model-id=<model-id>`. This caused the
      FE to DOS the backend looping over each action. On stats I found 350 or
      so sequential requests, with app-db saturation leading to requests
      taking from 400ms near the beginning to 7seconds near the end.
      
      This makes `model-id` option and now returns actions on all models the
      user can see.
      
      ```
      ❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb
      [
          {
              "archived": false,
              "creator": {...},
              "creator_id": 1,
              "database_id": 3,
              "dataset_query": {...},
              "id": 1,
              "model_id": 1,
              "name": "source = foo",
              "parameter_mappings": null,
              "parameters": [...],
              ...
          }
          ...
      ]
      ```
      
      * update frontend for action picker to support single action list endpoint
      
      * list actions tests
      
      * update actions e2e tests
      
      * Return empty vector if no results
      
      Running tests locally might return some extra actions not asserted on in
      the tests. And there you might expect a 200. But CI runs with an empty
      database and returns no response so you get a 204. Quite annoying and
      there's no good way to expect a "2xx" status code at the moment. So just
      return the empty vector so it's always a 200 code.
      
      * update actions endpoint unit test mocks
      
      * Simplify logic a little
      
      * docstring tweak
      
      * schema with better error message
      
      * update mocks to accept optional modelId
      
      * simplify sorting and grouping
      
      * make sort case-insensitive
      
      * simplify action api test mocks
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      d2e893dd
  15. Mar 08, 2023
  16. Mar 03, 2023
    • Ryan Laurie's avatar
      Test Time Fields in Action Forms (#28627) · 8f8ee7df
      Ryan Laurie authored
      * WIP action data type tests
      
      * DRY up the actions tests
      
      * lots of type tests
      
      * make the tests work
      
      * reorganize tests
      
      * WIP action data type tests
      
      * DRY up the actions tests
      
      * lots of type tests
      
      * make the tests work
      
      * reorganize tests
      
      * reduce some flakes
      
      * better time formatting in action forms
      
      * sort out all the timezones :woozy_face:
      
      * update after rebase
      
      * rebase disaster
      8f8ee7df
  17. Mar 01, 2023
    • Ryan Laurie's avatar
      Actions/test weird columns (#28593) · 70281b79
      Ryan Laurie authored
      * WIP action data type tests
      
      * DRY up the actions tests
      
      * lots of type tests
      
      * make the tests work
      
      * reorganize tests
      
      * reduce some flakes
      
      * updates after rebase
      70281b79
    • Nemanja Glumac's avatar
      [E2E] Regroup and move all related files to the root (#28749) · f71f20e1
      Nemanja Glumac authored
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      f71f20e1
  18. Feb 24, 2023
  19. Feb 23, 2023
  20. Feb 20, 2023
    • Ryan Laurie's avatar
      Custom Table e2e Tests 5: Simple actions testing (#27989) · cecbdc20
      Ryan Laurie authored
      * add helpers for actions testing
      
      * add basic action execution test
      
      * update add action test
      
      * add tags and documentation for tags
      
      * add tags to model actions spec
      
      * update test for new actions adding flow
      
      * fix merge conflicts
      
      * fix merge conflict again
      
      * address review comments
      
      * make test more reliable
      
      * prettier
      
      * prettier
      cecbdc20
Loading