Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 17, 2022
    • Dalton's avatar
      Fix Dimension instance mismatch problems when filtering via a native Model's... · 1276595f
      Dalton authored
      Fix Dimension instance mismatch problems when filtering via a native Model's remapped field (#24817)
      
      * Add dimension to the clicked object created by a table header click
      
      * Use clicked.dimension in ColumnFilterDrill
      
      * Change how virtual table fields are instantiated
      
      * Add field_ref to reference method of Field
      
      * Revert virtual table field instantiation
      
      * Fix Dimension render method dup words issue
      
      * Carry other secret props over when reinstantiating
      
      * Stupid workaround to handle missing join-alias
      
      * Account for more silly subtitles btwn virtual and real tables
      
      * Update binning e2e tests
      
      * Fix more e2e tests (#16675)
      
      * Fix more e2e tests (#16674)
      
      * Unskip repro and add hacks to make it work
      
      * Try withoutJoinAlias without limiting to virtual tables
      Unverified
      1276595f
    • Nemanja Glumac's avatar
      [E2E] Consolidate question [WIP] (#24733) · 609693d8
      Nemanja Glumac authored
      * Remove test that is not relevant anymore
      
      * Move browse data test where it belongs
      
      * Move repro 16108 to the `sharing` reproductions
      
      * Consolidate tests regarding the new question data picker
      
      * Remove duplicate test
      
      Exactly the same copy lives in `saved.cy.spec.js`
      
      * Move tests related to aggregation to where they belong
      
      * Migrate data picker reproductions over from `new-menu` spec
      
      * Move test to the saved questions
      
      * Remove the `describe` block related to "simple" question mode
      
      Simple or Custom question modes do not exist anymore.
      When opening a new question data picker, it's always in the custom/notebook mode.
      
      The new "simple" mode now refers to an already opened table or a saved question.
      
      * Move repro 15808 to nested questions
      Unverified
      609693d8
    • Nemanja Glumac's avatar
    • Cal Herries's avatar
      Fix for #24715: "Remember Me" functionality doesn't work (#24744) · 4532d07e
      Cal Herries authored
      * Separate setting the timeout cookie's expires attribute from the session cookie's max-age
      
      * Add back public-settings/session-cookies tests and add docstrings
      
      * Fix setting cookies with full-app-embedding
      
      * Add docstring
      
      * Change logout to always delete the session
      
      * Remove extra code
      
      * Change session-cookie-name from multimethod to simple case expression
      
      * Refactor: move use-permanent-cookies? closer to usage
      
      * Fix FE unit test
      Unverified
      4532d07e
    • Cam Saul's avatar
      Remove namespace checker linter (#24752) · df88405f
      Cam Saul authored
      * RIP namespace checker linter
      
      * Remove linters.namespace-checker shim namespace
      Unverified
      df88405f
    • Natalie's avatar
      docs - update google saml (#24829) · fa2a463d
      Natalie authored
      Unverified
      fa2a463d
    • Nemanja Glumac's avatar
  2. Aug 16, 2022
  3. Aug 15, 2022
  4. Aug 12, 2022
    • Cam Saul's avatar
      Enable Kondo for tests part 2: enable `:unused-binding` linter and fix warnings (#24748) · adf45182
      Cam Saul authored
      * Fix some small things
      
      * Add Kondo to deps.edn to be able to debug custom hooks from REPL
      
      * Fix macroexpansion hook for with-temp* without values
      
      * Test config (WIP)
      
      * More misc fixes
      
      * Disable :inline-def for tests
      
      * More misc fixes
      
      * Fix $ids and mbql-query kondo hooks.
      
      * Fix with-temporary-setting-values with namespaced symbols
      
      * More misc fixes
      
      * Fix the rest of the easy ones
      
      * Fix hook for mt/dataset
      
      * Horrible hack to work around https://github.com/clj-kondo/clj-kondo/issues/1773 . Custom linter for mbql-query macro
      
      * Fix places calling mbql-query with a keyword table name
      
      * Fix the last few errors in test/
      
      * Fix errors in enterprise/test and shared/test
      
      * Fix driver test errors
      
      * Enable linters on CI
      
      * Enable unresolved-namespace linter for tests
      
      * Appease the namespace linter again
      
      * Test fixes
      
      * Enable unused-binding linter for test/ => 293 warnings
      
      * 259 warnings
      
      * 234 warnings
      
      * => 114 warnings
      
      * Fix the rest of the unused binding warnings in test/
      
      * Fix unused binding errors in enterprise/backend/test
      
      * Fix unused binding lint errors in driver tests
      
      * Test fix :wrench:
      
      * Assure Kondo that something is in fact used
      Unverified
      adf45182
    • Cam Saul's avatar
      Enable Kondo for tests (part 1) (#24736) · bc4acbd2
      Cam Saul authored
      * Fix some small things
      
      * Add Kondo to deps.edn to be able to debug custom hooks from REPL
      
      * Fix macroexpansion hook for with-temp* without values
      
      * Test config (WIP)
      
      * More misc fixes
      
      * Disable :inline-def for tests
      
      * More misc fixes
      
      * Fix $ids and mbql-query kondo hooks.
      
      * Fix with-temporary-setting-values with namespaced symbols
      
      * More misc fixes
      
      * Fix the rest of the easy ones
      
      * Fix hook for mt/dataset
      
      * Horrible hack to work around https://github.com/clj-kondo/clj-kondo/issues/1773 . Custom linter for mbql-query macro
      
      * Fix places calling mbql-query with a keyword table name
      
      * Fix the last few errors in test/
      
      * Fix errors in enterprise/test and shared/test
      
      * Fix driver test errors
      
      * Enable linters on CI
      
      * Enable unresolved-namespace linter for tests
      
      * Appease the namespace linter again
      
      * Test fixes
      Unverified
      bc4acbd2
    • Ryan Laurie's avatar
      Refactor Filter Popover to functional component (#24729) · e474b0aa
      Ryan Laurie authored
      * refactor FilterPopover to functional component
      Unverified
      e474b0aa
    • Aleksandr Lesnenko's avatar
      fix reset password flow (#24731) · afa548bc
      Aleksandr Lesnenko authored
      * fix reset password flow
      
      * review
      Unverified
      afa548bc
    • Alexander Polyankin's avatar
    • Dalton's avatar
      Retrieve field metadata from cached card object when a dimension has a virtual card table (#24645) · 0646a3e5
      Dalton authored
      * Add cards to the metadata godhead
      
      * Use source query result_metadata when calling fieldDimension.field()
      
      * Various unit test fixes
      
      * First pass at attempting to refactor fields method
      
      * Round 2: more aggressive refactor...
      
      * Third pass, improved comments + minor tweaks
      
      * Add unit tests for more scenarios
      
      * Remove metadata from cards in normalization fn
      
      * Fix broken tests
      
      * Separate field logic for int id fields and non-int id fields
      
      * Remove usage of old metadata.question method
      
      * Limit some logic to datsets/models
      
      * Don't default objects arg of copyObjects
      
      * Add instantiateQuestion unit test
      
      * revert unit test that no longer needs fixing
      
      * Dimension tweaks
      
      * fix unit test fixture
      Unverified
      0646a3e5
  5. Aug 11, 2022
  6. Aug 10, 2022
  7. Aug 09, 2022
Loading