This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 17, 2022
-
-
Dalton authored
Fix Dimension instance mismatch problems when filtering via a native Model's remapped field (#24817) * Add dimension to the clicked object created by a table header click * Use clicked.dimension in ColumnFilterDrill * Change how virtual table fields are instantiated * Add field_ref to reference method of Field * Revert virtual table field instantiation * Fix Dimension render method dup words issue * Carry other secret props over when reinstantiating * Stupid workaround to handle missing join-alias * Account for more silly subtitles btwn virtual and real tables * Update binning e2e tests * Fix more e2e tests (#16675) * Fix more e2e tests (#16674) * Unskip repro and add hacks to make it work * Try withoutJoinAlias without limiting to virtual tables
-
Nemanja Glumac authored
* Remove test that is not relevant anymore * Move browse data test where it belongs * Move repro 16108 to the `sharing` reproductions * Consolidate tests regarding the new question data picker * Remove duplicate test Exactly the same copy lives in `saved.cy.spec.js` * Move tests related to aggregation to where they belong * Migrate data picker reproductions over from `new-menu` spec * Move test to the saved questions * Remove the `describe` block related to "simple" question mode Simple or Custom question modes do not exist anymore. When opening a new question data picker, it's always in the custom/notebook mode. The new "simple" mode now refers to an already opened table or a saved question. * Move repro 15808 to nested questions
-
Nemanja Glumac authored
-
Cal Herries authored
* Separate setting the timeout cookie's expires attribute from the session cookie's max-age * Add back public-settings/session-cookies tests and add docstrings * Fix setting cookies with full-app-embedding * Add docstring * Change logout to always delete the session * Remove extra code * Change session-cookie-name from multimethod to simple case expression * Refactor: move use-permanent-cookies? closer to usage * Fix FE unit test
-
Cam Saul authored
* RIP namespace checker linter * Remove linters.namespace-checker shim namespace
-
Natalie authored
-
Nemanja Glumac authored
-
- Aug 16, 2022
-
-
Nemanja Glumac authored
* Docs: update envvars to v44.1 Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
dpsutton authored
* Preserve metadata visibility-type Was being saved but not preserved and merged correctly. There are two points we need to preserve this information: in annotating the result metadata, we need to "flow" them. This is the combine metadata function which uses `preserve-keys`. And finally that stuff needs to be selected to be saved in `results_metadata`. That plucks off the `cols` map from the query run, merges it with insights and saves it. Missing this metadata in either location means we drop it: we have to flow it through the metadata and then ensure we select it for the final saving. * mt/mbql-query wants a symbol not a keyword * Update test to include visibility type when present
-
dpsutton authored
not a huge deal, just small logger stuff set in metabase.bootstrap
-
Aleksandr Lesnenko authored
* revert render throttling and remove the sidebar animation * skip the initial cards animation * extend comment
-
Ngoc Khuat authored
* fix incorrectly hash a fieldvalues for field that is not the field we use to define sandbox rule * appease clj-kondo * make the doc clearer * remove the _id destructring
-
- Aug 15, 2022
-
-
Jeff Bruemmer authored
-
Natalie authored
-
Alexander Polyankin authored
Revert "Fix #23689: Sandboxed group managers can't see other users in the People tab (#23825)" (#24760)
-
- Aug 12, 2022
-
-
Cam Saul authored
* Fix some small things * Add Kondo to deps.edn to be able to debug custom hooks from REPL * Fix macroexpansion hook for with-temp* without values * Test config (WIP) * More misc fixes * Disable :inline-def for tests * More misc fixes * Fix $ids and mbql-query kondo hooks. * Fix with-temporary-setting-values with namespaced symbols * More misc fixes * Fix the rest of the easy ones * Fix hook for mt/dataset * Horrible hack to work around https://github.com/clj-kondo/clj-kondo/issues/1773 . Custom linter for mbql-query macro * Fix places calling mbql-query with a keyword table name * Fix the last few errors in test/ * Fix errors in enterprise/test and shared/test * Fix driver test errors * Enable linters on CI * Enable unresolved-namespace linter for tests * Appease the namespace linter again * Test fixes * Enable unused-binding linter for test/ => 293 warnings * 259 warnings * 234 warnings * => 114 warnings * Fix the rest of the unused binding warnings in test/ * Fix unused binding errors in enterprise/backend/test * Fix unused binding lint errors in driver tests * Test fix
* Assure Kondo that something is in fact used -
Cam Saul authored
* Fix some small things * Add Kondo to deps.edn to be able to debug custom hooks from REPL * Fix macroexpansion hook for with-temp* without values * Test config (WIP) * More misc fixes * Disable :inline-def for tests * More misc fixes * Fix $ids and mbql-query kondo hooks. * Fix with-temporary-setting-values with namespaced symbols * More misc fixes * Fix the rest of the easy ones * Fix hook for mt/dataset * Horrible hack to work around https://github.com/clj-kondo/clj-kondo/issues/1773 . Custom linter for mbql-query macro * Fix places calling mbql-query with a keyword table name * Fix the last few errors in test/ * Fix errors in enterprise/test and shared/test * Fix driver test errors * Enable linters on CI * Enable unresolved-namespace linter for tests * Appease the namespace linter again * Test fixes
-
Ryan Laurie authored
* refactor FilterPopover to functional component
-
Aleksandr Lesnenko authored
* fix reset password flow * review
-
Alexander Polyankin authored
-
Dalton authored
* Add cards to the metadata godhead * Use source query result_metadata when calling fieldDimension.field() * Various unit test fixes * First pass at attempting to refactor fields method * Round 2: more aggressive refactor... * Third pass, improved comments + minor tweaks * Add unit tests for more scenarios * Remove metadata from cards in normalization fn * Fix broken tests * Separate field logic for int id fields and non-int id fields * Remove usage of old metadata.question method * Limit some logic to datsets/models * Don't default objects arg of copyObjects * Add instantiateQuestion unit test * revert unit test that no longer needs fixing * Dimension tweaks * fix unit test fixture
-
- Aug 11, 2022
-
-
dpsutton authored
-
Cam Saul authored
* Enable clj-kondo for driver namespaces * Fix CI command * Fix CI config (?) * Try hardcoding the driver directories in CI config * Fix some busted stuff * Enable the redundant fn wrapper linter * Appease the namespace linter
-
Aleksandr Lesnenko authored
-
Gustavo Saiani authored
-
Alexander Polyankin authored
-
- Aug 10, 2022
-
-
Nemanja Glumac authored
-
dpsutton authored
* `sql-editor-autocomplete-match-style` options for perf Large instances with 100ks of fields are choking on the select name from fields where name like "%search-term%`. Version in 43 was acceptable. This adds back the behavior in 43: prefix searching. Also adds ability to turn off if even the prefix search is burdensome. * Rename autocomplete-suggestion param `search` -> `substring` * support sql-editor-autocomplete-match-style on the FE * fix substring shows placeholder * Ensure using prefix style matching in e2e test * Make autocomplete style public * Rename defsetting to have "native-query" in name, not sql generally true. Consider mongo which has a native editor but no notion of SQL Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Nemanja Glumac authored
* Fix flake in repro for 12928 * Refactor test for joins on tables - Merge repro for 12221 with the existing "base" test - Merge repro for 13468 with the existing "base" test * Remove deprecated `cy.server()` command * Remove tests that are not related to joins * Reproduce 11452 and 15570 using the existing test * Merge repros 13000 and 13649 together * Reproduce 13744 using the existing test * Merge two `joins` files together * Use the existing helper to open the products table
-
Alexander Polyankin authored
-
dpsutton authored
addresses https://nvd.nist.gov/vuln/detail/CVE-2022-31197 https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md > fix: CVE-2022-31197 Fixes SQL generated in PgResultSet.refresh() to > escape column identifiers so as to prevent SQL injection. > > Previously, the column names for both key and data columns in the > table were copied as-is into the generated SQL. This allowed a > malicious table with column names that include statement terminator > to be parsed and executed as multiple separate commands.
-
Gustavo Saiani authored
-
Nick Fitzpatrick authored
-
Jeff Bruemmer authored
-
Gustavo Saiani authored
-
Nemanja Glumac authored
-
Ngoc Khuat authored
add support for reference snippet with mongo
-
- Aug 09, 2022
-
-
Noah Moss authored
* initial stab at improving formatting for relative dates * get template tags working for cljs translations * get plurals working for cljs translations * cleanup * tests * revert attempt at translations test * add comment for trsn * fix reflection * address comments * fix cypress test
-
Nick Fitzpatrick authored
-
Ryan Laurie authored
* respect remapped display options * test remapped display values
-