Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 20, 2024
    • Kamil Mielnik's avatar
      Fix - Notebook expression editor autocomplete issues (#49949) · 12f85cbb
      Kamil Mielnik authored
      * Allow navigating with arrow up/down between lines in expression editor
      
      * Do not hijack up/down arrow keys for autocomplete suggestions navigation when there's only 1 suggestion
      
      * Add explanatory comments
      
      * Convert tokenizer to TS
      
      * Add a test
      
      * Format code
      
      * Add basic test case
      
      * Fix a deprecation
      
      * Handle incomplete bracket identifier tokens
      
      * Shorten code
      
      * Add comment
      
      * Fix suggestion not always getting selected
      
      * Fix computation
      
      * Fix types
      
      * Update comment
      
      * Add repros for #49882
      
      * Add repro
      
      * Fix comment
      
      * Deprecate a HOC
      
      * Update assertion
      
      * Remove _.compose and default export
      
      * Fix types in ExplicitSize
      
      * Fix typing in ExpressionEditorTextfield
      
      * Fix types
      
      * Fix error handling
      
      * Fix showing errors when expression is invalid
      
      * Do not submit null expressions
      
      * Fix typing
      
      * Update assertion
      
      * Fix flaky test
      
      * Fix filter
      
      * Decrease flakiness
      
      * Fix crashing
      
      * Add comment
      
      * Fix incomplete bracket idenfitiers
      
      * Fix type
      
      * Improve typing
      
      * Add an explanatory comment
      Unverified
      12f85cbb
    • Chris Truter's avatar
      Rank based on when the current user last viewed the item (#50224) · fbd2a24d
      Chris Truter authored
      * Rank based on when the current user last viewed the item
      
      * Fix tests
      Unverified
      fbd2a24d
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Quarantine the flaky assertions (#50198) · 9ed2c3a2
      Mahatthana (Kelvin) Nomsawadi authored
      * Refactor: Speed up E2E tests by not relying on UI
      
      * Quarantine flaky E2E assertions
      Unverified
      9ed2c3a2
  2. Nov 19, 2024
  3. Nov 18, 2024
    • Ngoc Khuat's avatar
    • Ryan Laurie's avatar
      Unverified
      320f0907
    • Ryan Laurie's avatar
      Add Hungarian language support (#50165) · 1a421b3a
      Ryan Laurie authored
      Unverified
      1a421b3a
    • Aleksandr Lesnenko's avatar
      Fix pie chart legend issues (#50116) · 42013c4e
      Aleksandr Lesnenko authored
      * remove LegendVertical logic that preserves legend width
      
      * memoize pie legend items
      
      * prevent pie from jumping when toggle legend
      
      * fix responsive legend logic, cleanup
      
      * drop hyphens from the pie legend (#29597)
      
      * eliminate flickering on render due to not having dimensions
      
      * shortcut
      
      * specs
      
      * test vertical layout has no hyphens
      
      * setup func
      
      * set explicit showLegend=true default
      Unverified
      42013c4e
    • Oleksandr Yakushev's avatar
      perf: Improve the performance of pivoted XLSX export (#50117) · 1ab3e4e9
      Oleksandr Yakushev authored
      
      * [xlsx-export] Cache the custom datetime formatter
      
      * [xlsx-export] Optimize functions in m.q_p.pivot.postprocess
      
      * cljfmt
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Unverified
      1ab3e4e9
    • Cam Saul's avatar
      Revert remaining broken JAR path (#50162) · 0c442b62
      Cam Saul authored
      Unverified
      0c442b62
    • Ryan Laurie's avatar
      Update slack settings urls (#50042) · 4ab6c6eb
      Ryan Laurie authored
      Unverified
      4ab6c6eb
    • Jeff Bruemmer's avatar
      docs - sdk cli guide (#50098) · 2be5130e
      Jeff Bruemmer authored
      Unverified
      2be5130e
    • Nick Fitzpatrick's avatar
      search result order (#50048) · 21ae344b
      Nick Fitzpatrick authored
      Unverified
      21ae344b
    • Nicolò Pretto's avatar
      refactor(sdk): use ignore flag instead of mounted ref (#50069) · b3a46a77
      Nicolò Pretto authored
      * Revert "fix(sdk): put a bandage on the flashing error on static question in strict mode (#49659)"
      
      This reverts commit c57b3a38.
      
      * refactor(sdk): use ignore flag instead of mounted ref
      Unverified
      b3a46a77
    • Chris Truter's avatar
    • Kamil Mielnik's avatar
      Fix flaky x-rays test (#50131) · d291c150
      Kamil Mielnik authored
      * Fix flaky test
      
      * Add extra assertion
      
      * Reset hover state
      
      * Change order of assertions
      Unverified
      d291c150
    • lbrdnk's avatar
      Add temporal unit to display name (#48946) · 5203a15c
      lbrdnk authored
      * Add temporal unit to display name
      
      * Remove temporal unit adjustments from FE
      
      * formatColumn to displayNameForColumn
      
      * Factor out getFriendlyName
      
      * Adjust BE tests
      
      * Add require
      
      * Adjust FE unit tests
      
      * Adjust temporal-unit-parameters.cy.spec.js
      
      * Adjust dashboard-reproductions.cy.spec
      
      * Convert formatColumn occurrence
      
      * Adjust legacy display name logic generation
      
      After `getFriendlyName` was removed from FE, capitalization
      of display name should happen here. Logic is similar, should
      be adjusted prior merging the PR.
      
      * Adjust embedding-linked-filters.cy.spec.js
      
      * Adjust joins-reproductions.cy.spec.js
      
      * Adjust metrics-editing.cy.spec.js
      
      * Adjust timelines-question.cy.spec.js
      
      * Adjust offset.cy.spec.ts
      
      * TMP Avoid duplication of temporal unit in display name in MLv2 code
      
      * Probably FE fix: add default temporal bucket only if not present
      
      * WIP Add ends-with-temporal-unit? function
      
      Current strategy is to add temporal units to display names if same is not already present
      
      * Adjust display-name-method :metadata/column
      
      Append TU to display name only if different to what's already present
      
      * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element
      
      * Return also temporal-unit from visible-columns
      
      * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns
      
      * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec
      
      * Adjust multiple-column-breakouts.cy.spec.ts
      
      * It was not a bug.
      
      * Revert changes in _BaseBucketPickerPopover
      
      * Restore temporal-unit for next stages removal in stage.cljc
      
      * Add inherent-temporal-unit
      
      * Adjust display name temporal bucket logic
      
      * Rename to inherited-temporal-unit
      
      * Shutdown too broad display name capitalization
      
      * Eastwood
      
      * Adjust pivot-rows-order-test
      
      * Adjust pivot-non-numeric-values-in-aggregations
      
      * Adjust inherent to inherited
      
      * Rename to inherited
      
      * Add inherent-temporal-unit only to returned-columns
      
      * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Update consistent-date-formatting-test
      
      * Update dashboard/x-rays.cy.spec.js
      
      * Update waterfall.cy.spec.js
      
      * Return month default for default inherited-temporal-unit
      
      * Update reproductions-3.cy.spec.js
      
      * Update downloads/downloads.cy.spec.js
      
      * Update legend.cy.spec.js
      
      * Update pie_chart.cy.spec.js
      
      * Update click-behavior.cy.spec.js
      
      * Update embedding-linked-filters.cy.spec.js
      
      * Return QueryColumnPicker's condition to original state
      
      * Remove reundant export
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Comment
      
      * Update nested.cy.spec.js
      
      * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js
      
      * Adjust to TS types
      
      * Adjust for cljfmt
      
      * Capitalize
      
      * Add propagation tests
      
      * Add inherited-temporal-unit propagation for expressions
      
      * Add default inherited-temporal-unit test cases
      
      * Add qp temporal-bucket-test ns
      
      * Simplify default unit logic
      
      * Comment
      
      * Use NULL_DISPLAY_VALUE
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Remove redundant code (for now)
      
      * Update comments
      
      * Comment
      
      * Restore way too daring simplification
      
      * cljfmt
      
      * Adjust capitalize
      
      * Update comment
      
      * Update test
      
      * Address remarks in tests
      
      * Update test
      
      * Address remarks
      
      * typo
      Unverified
      5203a15c
    • Uladzimir Havenchyk's avatar
      fix: respect click behavior on public dashboards (#50067) · 552cf921
      Uladzimir Havenchyk authored
      * fix: pass noop as navigateToNewCardFromDashboard from public or embedded dashboard
      
      * add e2e test
      
      * rework a fix
      Unverified
      552cf921
Loading