Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 04, 2024
  2. Apr 03, 2024
    • Lena's avatar
      Make Noah the codeowner for permissions et al (#40919) · 83865263
      Lena authored
      * Make Noah the codeowner for permissions et al
      
      et al = `integrations` (OSS google auth, LDAP and Slack integrations) + `enterprise` (audit, advanced SSO, advanced config stuff).  `enterprise` also has LLM which doesn't really have a codeowner now, but it also doesn't need one.
      
      * Correct the paths and the scopes
      Unverified
      83865263
    • Lena's avatar
      Clarify that backport/no-backport is an internal thing (#40954) · 359a8dac
      Lena authored
      
      * Clarify that backport/no-backport is an internal thing
      
      A few times per month, external contributors ask about the notion doc they can't access and about the labels they are not expected to set. This is not the experience we should give to people who not only take their time to contribute to metabase, but also actually read the PR template.
      
      (slightly duplicated condition in the beginning and the end of the paragraph — "For those employed [...] If you're not employed [...]" — is on purpose)
      
      * Add linebreaks in PR template
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      Unverified
      359a8dac
  3. Apr 02, 2024
  4. Apr 01, 2024
  5. Mar 27, 2024
    • Uladzimir Havenchyk's avatar
      Upgrade node to 18.20 (#40661) · 0c9e3d55
      Uladzimir Havenchyk authored
      * Upgrade node to 18.20
      
      * Trigger CI
      
      * Try 20 again
      
      * Revert "Try 20 again"
      
      This reverts commit 8f4b39e7a64f1fae7c60decfb91ea87aff81f587.
      
      * Revert change
      
      * Add nvmrc to the frontend_sources list
      Unverified
      0c9e3d55
  6. Mar 18, 2024
  7. Mar 14, 2024
    • Tim Macdonald's avatar
      SQL Lineage: Track field usage, expose stale queries (#39707) · 3093f7c3
      Tim Macdonald authored
      * SQL Lineage: Create the QueryField model
      
      This links Cards (with native queries) to Fields, showing us which
      queries use which Fields.
      
      QueryFields are automatically maintained as part of the Card lifecycle
      
      Cards with stale queries (powered by QueryField info) are exposed via the `card?f=stale` API
      Unverified
      3093f7c3
  8. Mar 12, 2024
  9. Mar 08, 2024
  10. Mar 06, 2024
  11. Mar 05, 2024
  12. Mar 04, 2024
  13. Mar 01, 2024
  14. Feb 29, 2024
    • Mark Bastian's avatar
      Fixing E2E Cross-version Tests (#39285) · e6c518a9
      Mark Bastian authored
      * Fixing E2E Cross-version Tests
      
      E2E cross version tests were broken for multiple reasons, primarily due to changes made in UI layout, cypress testing, and data changes. Overall, the basic workflows still work, but subtle click order differences and other small changes made the entire job consistently fail.
      
      To fix this, this PR:
      - Provides a function, `parseVersionString`, which computes version information provided a test version string. This information includes the raw string version, the edition (ee or oss), and the major, minor, and patch version of the version string.
      - In the same file, `cross-version-helpers.js`, adds constants identifying versions in which certain breaking UI or Cypress changes occurred.
      - Finally, a set of exported functions are provided which take a version object and execute conditional logic based on the provided version so that behavior is consistent across Metabase versions.
      
      The versions are computed in `cross-version-source-helpers.js` and `cross-version-target-helpers.js` and are used in js files as shown:
      
      ```js
      import { visualize } from "e2e/support/helpers";
      import {
        fillAreaUnderLineChart,
        newQuestion,
        saveQuestion,
      } from "e2e/test/scenarios/cross-version/helpers/cross-version-helpers.js";
      ```
      
      This then allows logic like the below, where the high level call is made and the right logic is dispatched based on the version information.
      
      ```js
      it("should create questions", () => {
        cy.signInAsAdmin();
      
        cy.visit("/question/new");
      
        newQuestion(version);
      
        // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
        cy.findByText("Orders").click();
      })
      ```
      
      Other smaller changes were also made that created a more universal sequence of UI actions.
      
      Fixes #39229
      
      * clear -> click
      
      * Fixing area icon selection
      
      * Restoring scheduling to align with master
      
      * fe lint
      Unverified
      e6c518a9
    • Nicolò Pretto's avatar
  15. Feb 27, 2024
  16. Feb 22, 2024
  17. Feb 16, 2024
  18. Feb 13, 2024
  19. Feb 02, 2024
  20. Feb 01, 2024
  21. Jan 31, 2024
  22. Jan 29, 2024
  23. Jan 24, 2024
  24. Jan 23, 2024
  25. Jan 18, 2024
  26. Jan 16, 2024
  27. Jan 12, 2024
Loading