This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 09, 2024
-
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
These type checks are useful when constructing clauses with full MLv2 metadata available, but when converting from legacy the `:field` refs have only `:base-type`. If a column has its metadata overridden to eg. coerce a string or integer into a date, its `:base-type` will remain `:type/Integer` or `:type/Text` and the `:effective-type` will be `:type/Date` etc. This change skips the type check while converting from legacy, and while checking `can-run`. Eventually this should be replaced with tracking `:effective-type` on refs or using real metdata, instead of relying on the `:base-type` only. Fixes #41122.
-
Romeo Van Snick authored
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove unused CSS custom properties * Migrate .ModalContainer * Migrate .Modal * Migrate .ModalBackdrop * Migrate Modal transition classes * Migrate modal sizes * Fix tests * Add missing classes from migration * Address review: use `data-testid` * Remove unused classes * Revert the util that selects Mantine modal
-
Abed Habli authored
I have edited the list of "Download results."
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Improve the fetching logic in a notebook native preview * Rely on `isFetching` always * Show a disabled convert button when there's no query
-
Nemanja Glumac authored
* Convert `ui` actions to TypeScript * Make sure fetched user is not `null`
-
Tim Macdonald authored
-
Nemanja Glumac authored
-
Alexander Solovyov authored
We need to serialize it for any card, since when a normal question depends on a native question - their result_metadata won't be updated when opening a dashboard, which leads to front-end not understanding how to connect the parameters from a dashboard to a card, and errors during queries.
-
- Apr 08, 2024
-
-
adam-james authored
* Group axes with the correct map shape. Prior to this, any time axes were all explicitly set :left or :right by the user, the `group-axes-at-once` function would incorrectly return the map in the following form: `{:left ["a" "b" "c"]}` which is incorrect. It must instead look like this: `{"a" :left "b" :left "c" :left}` This fixes the map shape and permits the user to explicitly set all axes to the left or to the right. * Add a test to confirm the axis settings are respected and do render
-
Cam Saul authored
* Wow * Test fix
* Fixes * Actions should use strings for column names (fix :update-row and :create-row normalization) * MLv2 schema should check against keys for the other query type * Ok, have I fixed things? * More fixes * Fix indentation * Another round of test fixes. * Hopefully the last few test fixes * We need to test normalization for queries that have keyword keys as well. * Fix Cljs i18n namespaces * Sort namespaces * Only test against H2 * Rename `metabase.mbql` to `metabase.legacy-mbql` * Fix Kondo warnings * Test fixes * Register MBQL clause schemas and test fixes * Test fixes and PR feedback * Test fix * Remove the normalization tests * Test fixes * Fix kondo * Fix import * Another fix * Merge * FIXES * Add another missing REQUIRE * More Metric => LegacyMetric renaming * metabase.models.metric-important-field => metabase.models.legacy-metric-important-field * Even more renaming * More renaming * Even more fixes. * More renaming * Wow, even more renaming!! -
Cam Saul authored
* Use window functions for SQL drivers for cumulative count and sum * H2/Snowflake/Redshift implementation * Test fixes
* Use SELECT expression positions as the default window function implementation * Some test fixes. * Fix bugs in add-alias-info * MongoDB fixes * Another pass * BigQuery should use positions? * BigQuery almost works 100% now. * MLv2 fix conversion behavior for expressions with type info * Add transformations for nesting cumulative aggregations in expressions * Minor tweaks * MLv2 should escape aliases using driver/escape-alias (dynamically bind this) * Kondo fix * Lint fixes * More test fixes and revert test changes * Update some tests to use correct case for nominal Field literal refs * Wow! BigQuery is fixed! Remove upgrade-field-literals middleware * Disable tests for the failing drivers, we can fix in follow-on PRs. * Enable BigQuery :window-functions * Extra info * Add GH issue numbers * Update more GH issue numbers * Fix SQL Server!!!! wooo * I THOUGHT WE WERE DISABLING SPARK SQL!!!!!!!!!!1 * Cleanup to get things ready for review. * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER * Code cleanup * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER * Code cleanup * Test fixes * Much simpler BigQuery implementation * Add GH issue context * Remove commented-out code * Remove unused add-stage-at-index * Documentation * Test fix? * Test fix -
Cam Saul authored
* Legacy MBQL documentation * Do not commit dox * Subject the legacy MBQL stuff to the same stricter linting rules as MLv2 * PR feedback
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
* Add new user-local setting `notebook-native-preview-preferences` * Update user settings on FE * Use two distinct setting entries * Update FE types * More explicit `notebook-native-preview-sidebar-width` definition * Add selectors * Initialize QB uiControls based on the BE settings * Rename QB store entry `isNativePreviewSidebarOpen` -> `isShowingNotebookNativePreview` * Rename QB store entry `nativePreviewSidebarWidth` -> `notebookNativePreviewSidebarWidth` * Add Redux actions * Dispatch user settings on top of Redux store * Fix test title typo * Add E2E test to make sure sidebar is resizable * Expand the E2E test to cover persisting settings across sessions * Be more explicit that we're resizing along x axis * Store window breakpoint as a variable * Calculate handle's left position more explicitly
-
Alexander Solovyov authored
-
Oisin Coveney authored
-
Ryan Laurie authored
* make collectionpicker child-aware * update unit tests * add another unit test * move test some place more sensible * fix rebase
-
Cal Herries authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Make the height of the rows consistent when there is no info icon * Limit the amount of connected tables shown * Use Array.from({ length }) Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Use a regex to find connected tables in test --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Romeo Van Snick authored
* Make canSelectSection a function * Use a custom type for actions in the accordionlist * Add the globalSearch prop to AccordionList * Improve AccordionList tests * Enable globalSearch in the AccordionPicker on the FilterColumn and QueryColumn picker * Assume alwaysVisible for action sections * Add state for empty search results * Fix test case * Allow passing globalSearch to Select * Set globalSearch in semantic type picker * Handle search when a section does not have items * Rename variable to be more descriptive * Add borders to headings in select * Add border to back button too
-
Braden Shepherdson authored
This optional fourth argument will disregard all joins at `position` and later when suggesting conditions. This is useful when editing a join's RHS, which wipes out the condition. We don't want to generate a suggested condition that's based on keys from the RHS of the join we just edited, or from later joins. Fixes #40916. Part of #40890.
-
Braden Shepherdson authored
Fixes #41023.
-
Alexander Solovyov authored
New endpoint accepts entity and entity ids in form of `database=1&dashboard=2&question=3`. If you don't supply `&include=overrides`, then it tries to find configs directly referencing supplied entities and updates their `invalidated_at`. If you supply `&include=overrides`, all the referenced cards are updated (`report_card.cache_invalidated_at`). Cache strategies then select the maximum `invalidated_at` in their logic. EE-only. resolves #40548
-
Chris Truter authored
-
Chris Truter authored
-
Nick Fitzpatrick authored
* update deps * adjusting tests to work with new RTL * removing testing-library/no-unnecessary-act:off
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Display sql preview on sizes less than 1280px * Handle min notebook width using Mantine responsitve style prop * Display the resizable sidebar on sizes >= 1280px * Set sidebar width on resize * Add custom handle * Simplify window resizing with `useWindowSize` hook * Use "white" from the theme colors * Improve sidebar semantics with `aside` * Define the `NativeQueryPreviewSidebar` as `aside` * Use Mantine style props instead of CSS module * Run the E2E test again using regular browser We removed the nested media query that ReplayIO doesn't support. Now this test can run using Replay Chromium as all other tests do. * Add some breathing room between the scrollbar and the resizable sidebar
-
Oisin Coveney authored
-
Tim Macdonald authored
[Fixes #13922]
-
Alexander Solovyov authored
-
Oisin Coveney authored
-
- Apr 06, 2024
-
-
Noah Moss authored
-
- Apr 05, 2024
-
-
Cam Saul authored
* MLv2 normalization: add :lib/uuid automatically to options maps if it's missing * Remove unneeded normalization code in QP * Fix
* Ignore invalid metadata providers when passed in from the REST API
-