Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 05, 2023
  2. Mar 22, 2023
    • Ryan Laurie's avatar
      :cherries: Manual Backport #29295 Action/Model-Actions Tests (#29377) · 79e01bc3
      Ryan Laurie authored
      * Actions/e2e model actions tests (#29295)
      
      * extract model creation helper
      
      * update model actions test to actually mutate data
      
      * fix merge conflicts and clean up
      # Conflicts:
      #	e2e/test/scenarios/models/model-actions.cy.spec.js
      
      * don't assert not found
      79e01bc3
  3. Mar 21, 2023
  4. Mar 16, 2023
  5. Mar 09, 2023
  6. Mar 08, 2023
  7. Mar 07, 2023
    • metabase-bot[bot]'s avatar
      Elevate field type in the action editor (#28862) (#28960) · 7a8bf439
      metabase-bot[bot] authored
      
      * Remove redundant `isSettings` prop
      
      * Extract `FormFieldEditorDragContainer`
      
      * Extract `FormFieldEditor` component
      
      * Update field editor UI
      
      * Disable validation in parameters editor
      
      * Fix crash on adding a new parameter
      
      * Add new tests and fix existing
      
      * Remove redundant `overflow: hidden`
      
      * Use shorter flex properties
      
      * Remove redundant `key` prop
      
      * Increase icon size
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      7a8bf439
  8. Mar 01, 2023
    • metabase-bot[bot]'s avatar
      [E2E] Regroup and move all related files to the root (#28749) (#28777) · 28b00a04
      metabase-bot[bot] authored
      
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      28b00a04
  9. Feb 27, 2023
  10. Feb 24, 2023
  11. Feb 23, 2023
  12. Feb 21, 2023
    • Anton Kulyk's avatar
      Allow creating actions with "+ New" button (#28419) · 9b9edf46
      Anton Kulyk authored
      * Make `modelId` optional in `ActionCreator`
      
      * Add `onSubmit` prop to `ActionCreator`
      
      * Allow creating actions with "+ New" button
      
      * Add `nock.cleanAll()`
      
      * Address comments
      
      * Use `CollectionItem` type
      
      * Use `import type`
      
      * Enable loading and error wrapper for loader
      9b9edf46
  13. Feb 20, 2023
  14. Feb 17, 2023
  15. Feb 16, 2023
  16. Feb 15, 2023
  17. Feb 10, 2023
  18. Feb 06, 2023
    • Cal Herries's avatar
      [Feature] Allow actions to be shared via public link: Milestone 1 (#27777) · 90919d31
      Cal Herries authored
      * Add public_uuid and made_public_by_id to actions table & endpoints to enable/disable the public sharing on individual actions (#27721)
      
      * Add migration for public_uuid (indexed) and made_public_by_id
      
      * Add UUIDString schema
      
      * Add endpoints for enabling/disabling sharing of actions
      
      * Test that the new fields are returned with `GET /api/action/:id`
      
      * Remove validCheckSum on migration
      
      * Remove trailing whitespace
      
      * Fix DELETE test
      
      * Fix tests
      
      * Please migration linter
      
      * Update the default public_uuid every test run
      
      * Please migration linter
      
      * Add FK onDelete cascade
      
      * Replace ü
      
      * Add GET endpoint and post-select for action
      
      * Revert "Add GET endpoint and post-select for action"
      
      This reverts commit 8cc8b57d6034146dd726b54bc4199830ec1fda21.
      
      * Fix merge
      
      * Reorder migrations
      
      * Update test for GET `api/action?model-id=<id>` endpoint to include public sharing keys (#27802)
      
      * Add GET: /api/public/action/:uuid endpoint (#27781)
      
      * Add test
      
      * Remove non-public columns and check for 404
      
      * Fix docstring
      
      * Rename for clarity
      
      * Fix missing ns
      
      * Remove unneccessary keys from action
      
      * Update test
      
      * Remove unused refer
      
      * Reorder migrations
      
      * Use mt
      
      * Add require and refactor
      
      * Use mt
      
      * Add endpoint for executing a public action (#27793)
      
      * Add endpoint and test
      
      * Add more tests and TODOs
      
      * Use mt
      
      * Reorder migrations
      
      * Remove unused require
      
      * Rate limit actions at 1 per second
      
      * Fix the tests for the throttle
      
      * Refactor tests
      
      * Fix test
      
      * Fix docstring
      
      * Add test for failed execution if actions are disabled
      
      * Use crowberto in tests
      
      * Fix using crowberto in tests
      
      * Fix cyclic load dependency
      
      * Refactor ActionCreator (#27832)
      
      * Refactor make ActionCreator more sane
      
      * Render sidebar conditionally with JS rather than hiding it in CSS
      
      * Make action public (#27809)
      
      * Move action creator action buttons to the header following design
      
      * Remove double border which make it looks thicker
      
      * Draft toggle action public
      
      * Add confirmation when disabling public link similiar to questions and dashboards
      
      * Add an action public UUID input and copy button
      
      * Show action settings based on user permission
      
      * Add public action toggle tests
      
      * Remove unused import :face_palm:‍
      
      * Attempt to fix flaky CI unit tests
      
      The problem seems to be because of how long it takes for the response
      to be received even on unit tests, it took longer than 1 second which is
      the default timeout for `waitFor`.
      
      * See if not using `userEvent` could make the involving nock faster
      
      * Improve test speed to reduce flakiness
      
      * Add public action page (#27747)
      
      * Add basic public action page
      
      * Add form submit logic placeholder
      
      * Use "Submit" as default action form's button label
      
      * Add "big" variant to `EmbedFrame's` footer
      
      * Use new footer variant for action page
      
      * Break down the page, add document title
      
      * Handle long forms better
      
      * Add `PublicWritebackAction` type
      
      * Use public action GET endpoint
      
      * Add endpoint to execute public actions
      
      * Use action execution endpoint
      
      * Add tests
      
      * Handle actions without parameters
      
      * Rename variant prop
      
      * Replace `waitFor` with `findBy`
      
      * Define `FooterVariant` type
      
      * Fix router setup in `renderWithProviders`
      
      * Show which action is publicly accessible on model detail page (#28039)
      
      * Bring e2e tests back
      
      Manually bringing back tests added in: https://github.com/metabase/metabase/pull/28056
      
      
      
      * Update typo
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * Remove TODO and use malli for defendpoint
      
      * Add malli schema for endpoints
      
      * Update permissions checks for POST and DELETE
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      90919d31
  19. Jan 31, 2023
    • Anton Kulyk's avatar
      Add routes for model detail page tabs (#27959) · be435ce6
      Anton Kulyk authored
      * Remove unused code
      
      * Add `<Tab.Link />` component
      
      * Allow to customize `TabList's` styled components
      
      * Add `tab` arg to model detail URL helper
      
      * Add `:tab` routes for model detail page
      
      * Use link tabs in model detail page
      
      * Open actions tab directly in e2e tests
      
      * Add safety checks for tabs
      
      * Don't nest `TabLink` under `Tab`
      
      * Use explicit tab routes
      
      * Use `IndexRedirect`
      
      * Don't use `Array.prototype.at`
      
      Fails with Node 14.x :(
      be435ce6
  20. Jan 25, 2023
  21. Jan 24, 2023
  22. Jan 17, 2023
    • Anton Kulyk's avatar
      Add actions tab to model detail page (#27657) · 4460a4b1
      Anton Kulyk authored
      * Add Fira Code
      
      * Add basic actions tab
      
      * Add "New action" flow
      
      * Fix actions tab width
      
      * Fix code doesn't show newlines
      
      * Add action editing flow
      
      * Fix console error
      
      * Use Monaco for code snippet
      
      * Add an empty state
      
      * List implicit actions
      
      * Make it possible to add implicit actions
      
      * Hide actions tab if actions are turned off
      
      * Handle read-only permissions
      
      * Fix loader
      
      * Sort actions
      
      * Add server mocks for action endpoints
      
      * Add `createMockImplicitCUDActions` helper
      
      * Add tests for the actions tab
      
      * Add E2E test for action create-read-update flows
      
      * Clean up
      
      * Move e2e test to models for now
      
      * Fix `EmptyState` usage
      
      * Fix action sorting
      
      * Avoid boolean casting
      
      * Ensure the page explicitly loads database
      
      * Use existing color for action query card
      
      * Use `space` function
      
      * Fix length check
      4460a4b1
Loading