This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 12, 2023
-
-
Cal Herries authored
-
Ngoc Khuat authored
-
Nemanja Glumac authored
Stress-testing a spec with a lot of tests can easily time out before 20 minutes mark. This commit is bumping that timeout to 60 minutes. [ci skip]
-
Anton Kulyk authored
-
Nemanja Glumac authored
* Fix join flake for field literals Example of a failed run from the past: https://www.deploysentinel.com/ci/runs/647ff0426bd09da7e252a052 * Fix flake in repro #12928 An example of the failed run from the past: https://www.deploysentinel.com/ci/runs/647f17d60baaca08b249b4aa This commit extracts the joins logic to select two saved questions to a seperate helper, because it seems we'll use it in many places. * Fix flake for repro #18512 An example of a previously failed CI run: https://www.deploysentinel.com/ci/runs/647f605e4d5097b4de537e07 * Fix flake for repro #18502 An example of a failed run from the past: https://www.deploysentinel.com/ci/runs/64807a6e45294b33d5240830 * Tentatively fix flake in repro #17767 This flake has a different cause than the rest of the flakes in this PR. The request `POST /api/dataset` is timing out in CI. It takes more than 30 seconds to complete, and Cypress times out in meantime. This is suspiciously slow, even for CI. I'm trying to limit the number of results by limiting rows in the original query. This reduces the number of total results (after the join) from 1,136 rows to just 9.
-
- Jun 10, 2023
-
-
Nemanja Glumac authored
* Document how to improve code reviews This commit adds a section to the existing documentation on code review process. It points to the video presentation of a research on this topic, and adds a few pointers for both the code owners and code reviewers. * Apply Jeff's edits Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Ariya Hidayat authored
-
- Jun 09, 2023
-
-
Ngoc Khuat authored
* forward migration for size_x and col * done? * test fixes * adds some document * migration should not contains comment * mysql and postgres use different syntax in casting * makes it work on mariadb * update grid columns * update specs * update specs * use float for postgres * postgresql not postgres * add migration for revision with model=Dashboard * row is reserved in h2 too * handle edge case with rollback migration where we have a 1x1 card that located at the shrinkage line * kondo * Cal's feedback * add the code we used to generate random array * clean up * use the algorithm to dynamicall generate test data * no more height migrations * grid ratio * unmigrate height in cypress specs * update specs --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Noah Moss authored
-
Noah Moss authored
* enforce download perms on dashcards * fix tests
-
Noah Moss authored
-
bryan authored
* use hydrate-root-collection on card and dashboard - GET /api/card/:id - GET /api/dashboard/:id * include missing ns require * copy root-collection-with-ui-details into collection.root * import the var from collection.root * remove unused require
-
Ryan Laurie authored
* allow upload table prefixes on dbs with schema * add optional copy * make boolean logic easier to read
-
Noah Moss authored
-
Oisin Coveney authored
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Jun 08, 2023
-
-
Jesse Devaney authored
* initial prototype commit * add default value for text cards * auto focus text/heading cards on creation * remove default value - use placeholders instead * fix inability to edit when there is no heading value * remove unnecessary comment * re-word heading & text tooltip * refactor and fix draggable area bug * fix border artifacts when combined with dragging styling * fix stroke width for hovering and focused - make them the same * display placeholder value in editing mode if content is empty for text and heading dash-cards * remove duplicate placeholders * allow pointer-events anywhere on the div (not just content) * refactor styling to apply no content borders * Fix heading overflow * refactor text dash-card button - remove unnecessary redux store usage * refactor border styling to one css format * rename class names to match syntax conventions * refactor auto-preview styling for dash-card root * refactor style name * remove comment * undo unnecessary re-formatting * refactor popover styling * remove comment that was previously addressed * refactor to typescript * remove comment * remove un-used code * fix TypeScript errors in text unit spec * update button key and event description * add e2e tests for text and heading dash-cards * add e2e tests * add small heading unit tests * fix typescript error * add aria-label removed by merging with master * fix broken test * fix broken tests * fix typescript errors * align edit text with preview text * change from hover editing to click editing * update tests for click editing - remove hover tests - change focus tests to click tests - remove top-level findByText() calls * refactor to use-focus hook * add "heading" to getSupportedCardsForSubscriptions * rename showVisualizationOptions to showDashcardVisualizationSettings * add aria label to buttons and query in tests by label * refactor E2E tests to make longer flows * add existing metabase types to Heading * refactor heading and text menu to use EntityMenu * fix aria-label * [skip ci] fix css syntax error from missing semi-colon * adjust styles and use rem value standards * [skip ci] prevent drag on click to edit surface area * tweak styles for mobile resolutions * fix react import lint error * fix E2E tests * refactor e2e helper to shorthand * refactor to use e2e helper * refactor to use saveDashboard() e2e helper * refactor e2e tests * rename styling variables * null coalesce minWidth * remove unnecessary anonymous function wrapping * refactor to useToggle * improve no content check * use object creation shorthand * simplify expression * refactor empty content styling * move text-edit-container styling into heading and text components * refactor resize handle styling and abstract condition into function * refactor to use CSS function for string styling * improve Heading unit tests * improve Text unit tests * update Heading and Text unit tests * update for new Icons * fix E2E tests * refactor E2E test assertions * refactor click events to use user-event library * fix tooltip positioning
-
Ryan Laurie authored
* update upload loading state for long uploads * add unit tests * fix fake timers
-
Nemanja Glumac authored
* Move core actions E2E tests to a separate folder * Run new `actions` E2E group in CI Metabase actions deserve their own E2E group, as the test suite around them is expected to grow. This commit introduces `actions` E2E group to the CI.
-
shaun authored
-
Ryan Laurie authored
* add upload info modals * unit test upload buttons + modals * update types an imports * update file upload test
-
Nemanja Glumac authored
Although I've already dismissed `fast-xml-parser` dependabot alert (which is a Deploysentinel dependency), they also upgraded it upstream in their Cypress debugger. This was just a reason more to upgrade. Full changelog: https://www.deploysentinel.com/docs/cypress-changelog
-
Nemanja Glumac authored
We're seeing increasing number of timeouts in CI without any significant changes in the test suite. This could be due to GitHub's runners performance. [ci skip]
-
Aleksandr Lesnenko authored
* fix pivot table settings crash when the question is unaggregated * error boundary
-
Alexander Polyankin authored
-
Cam Saul authored
-
Kyle Doherty authored
the inclusion of this CSS reset causes issues with the font family in our input fields and is currently unnecessary
-
bryan authored
* Adds audit v2 view migrations to liquibase * bit of cleanup
-
Oisin Coveney authored
-
Ngoc Khuat authored
-
- Jun 07, 2023
-
-
bryan authored
* wip * fix caching behavior for audit db in database-id->connection-pool * test that caching behavior works as advertised - db->pooled-connection-spec always returns the same pool for audit-db - audit-db-id is not in the database-id->connection-pool cache * DISABLE audit db exposure through GET api/database * Lots of things - automagically loads instance analytics on app startup - TODO: logging in after that is bokred * add some logs / fix comment * remove internal_analytics resource * fix linter issues + update logging * add tests for existing and missing content - add test replica of content into test-resources * remove unused require * delete sample db + personal collection from test-resources * get instance_analytics resource off the resource path * point it to the proper IA resource * un-hotwire the change to show audit DB on GET /databases * fix test + lookup the right resource * remove creator_id references from instance_analytics export test data - get test feedback * Revert "remove creator_id references from instance_analytics export test data" This reverts commit 1aa9d4b1dad304ac0c6d88221f81432d78fc88f0. * fix tests * lint * fix tests * more test fixing * linter fix * revert yarn.lock * Look up the correct instance_analytics resource * cleanup comment in serialization/cmd.clj * silence noisy serialization import logs * remove a bunch of unused serialization files * rename Audit Database + docstring * rename audit database everywhere * Put the database and tables back * constrain tests to postgres * ignore ia data in a test
-
Cam Saul authored
* Question URL methods to functions * Move URLs to their own file --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Cam Saul authored
-
john-metabase authored
Updates Snowflake driver to decode uploaded private key file data if necessary
-
Jerry Huang authored
* initial commit * add require * update gen hash * fix test * add email logic to alerts * fix one test * test fix * re-add retry * fix test * add test * address comments * fix typo * fix test * fix test * update req
-
Kyle Doherty authored
-
Nemanja Glumac authored
We stopped using Currents.dev analytics a few months ago. This PR removes the stray project ID from E2E workflow. [ci skip]
-