This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 18, 2024
-
-
github-automation-metabase authored
* Fix flaky test * Add extra assertion * Reset hover state * Change order of assertions Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Sep 09, 2024
-
-
Aleksandr Lesnenko authored
* show additional columns in the tooltip * specs, tweaks * drop stack dependency * handle invalid columns * change copy
-
- Sep 03, 2024
-
-
Anton Kulyk authored
* Move current click handler to legend title * Add `onToggleSeriesVisibility` prop to `Legend` * Update `LegendItemDot` component * Update `LegendItemTitle` * Toggle series visibility * Fix hover effect * Don't let to hide the last visible series * Add `visible` property to `BaseSeriesModel` * Fix dangling split axis label when hiding a series * Update `graph.series_order` viz setting widget * Fix can't toggle series visibility from legend popover * Fix legend dot clipped by `overflow: hidden` * Fix eslint error * Fix legend popover scroll * Add unit tests * Add e2e tests * Fix show/hide series for scatter charts * Default `LegendItemDot` to visible state * Only apply legend dot hover effect if there's a click handler * Don't allow to remove the last series in `ChartSettingSeriesOrder` * Fix tooltip performance drop * Fix e2e tests around `series_order` viz setting widget * Use `text-medium` for outer circle background * Update dot style * tweak inner circle color * Update copy * Use div instead of button if can't toggle visibility * Fix legend layout issue * Don't show trendlines for hidden series * Fix missing prop value * Disable visibility toggle outside of dashboard/qb view * Add public dashboard test * Add tooltip footer e2e helpers * Fix chart tooltip shows hidden series data --------- Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
- Aug 16, 2024
-
-
Aleksandr Lesnenko authored
* use ECharts tooltip on cartesian charts * fix tooltip lag when changing hovered series * facelift tooltip * fix static viz crashes due to tooltip option * facelift * pie chart echarts tooltip * facelift * facelift * facelift * tweaks * e2e specs * return back the pie other slices tooltip * more specs * specs * fix pie total * fix tooltip overflow * fix specs * fix infinite rerender in embedding mode for charts that have warnings * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
- Jul 31, 2024
-
-
Emmad Usmani authored
* echarts pie * setup rendering pipeline for static pie chart (#43547) * setup rendering pipeline for static pie chart * remove more donut code from BE * compute viz settings for static pie chart (#43548) * compute viz settings for static pie chart * create chartModel for pie chart (#43549) * create chartModel for pie chart * render static pie chart (#43550) * render static pie chart * render static pie chart legend (#43551) * disable animation * alter static-viz pie chart be tests to account for echarts-impl The old implementation had a different implementation for legends, separate from the 'categorical/donut' js render. Echarts nicely combines the legend into the pie render, so we don't need to worry about that stuff anymore. Instead, I've written a simple set of assertions on the echarts pie implementation now. * Get rid of this test that was attempting to use old code path * echarts pie * One last spot where we don't need old pie stuff anymore. * add loki specs * save snapshots * fix small slices disappearing * update snapshots * add repro story for exteremely small slice * add snapshot * fix rounded total * fix percent formatting in legend * fix date dimension formatting * fix binned and relative date dimension labels on legend * add specs and snapshots for null and unaggregated dimensions * hide overlaping labels on chart * fix null dimension color * show error when metric column has a negative value * move legend to botom * make dot margin smaller * add columns to legend * sort legend vertically * dont use grid if only one row for legend * never hide legend in static viz * fix empty column culling * show single legend item * add long dimension name story * fix long dimension name in legend * right justify percentages in legend * remove negative error and re-add stories * handle negative values * create chart definition for dynamic pie chart * render chart with responsiveness * add comment for borderWidth calculation * center legend * fix legend centering * add story for missing currency formatting * fix missing currency formatting * fix graalvm crashing * fix column settings computation * add another currency formatting repro * fix wrong order of col settings computations * convert colors to hex * fix colors missing from viz settings * temp todo comment * fix colors in dynamic viz * update snapshots * fix crashing due to invalid dimension/metric setting * fix chart crashing for boolean dimension with labels on chart * add repro * fix regression in label formatting * fix labels on small slices * update specs * emphasis state for slice hover * recreate old label hiding logic * include height measurement in getIsLabelVisible * move d3 slices to chart model * fix labels on static viz * wip basic hover state and tooltip * fix emphasis style getting stuck by memoizing everything * update total display value * fix stuck emphasis by setting notMerge to false for pie only * handle other slice in tooltip * fix bugs in total graphic * use OTHER_SLICE_KEY const in static viz legend * implement legend and connect to hover state * implement click actions * fix slice not clickable * handle all zero slices * add repro * update specs * update pie_chart.cy.spec.js * update chart_drill.cy.spec.js * add repro for single column legend * use minimum 2 legend columns * fix legend text overlap * use more margin for single row legend * update specs * add repro for 28568 * add repro for 38424 * fix percent label not showing on large slices * hide total text when chart is small * replace comment about animations * show warning for mixed positive and negative values * delete old chart files * fix type errors * update d3 import * update specs * remove branch from uberjar.yml * dont put single slice into other * fix lint errors and pie render test * update more d3 imports * remove unused settings * revert preview-card-width change * remove unused import * remove majorWidth option from formatting * use debounceLeading refresh mode in ChartWithLegend * remove TOTAL_GRAPHIC_OPTION constant * delete unit test for pie chart * fix failing test by doing set comparison instead * fix typo in comment * remove SUNBURST_SERIES_OPTION constant * fix lint by removing unused eslint-disable * move default color computation to getValue * fix static pie test to show that we will always render the legend * update pie border color for night mode and embedding * fix styles for embedding case and add stories * skip embedding stories --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
- Jun 11, 2024
-
-
Nemanja Glumac authored
* Fix the typo * Replace `realHover` with the `mouseMove` trigger * Be explicit when targetting elements by their index * fix combo chart tooltip e2e specs * cy.wait as a last resort --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
- May 21, 2024
-
-
Emmad Usmani authored
* highlight hovered timeline event * add e2e test * use TIMELINE_EVENT_DATA_NAME constant * add test case for clicking icon
-
- May 16, 2024
-
-
Aleksandr Lesnenko authored
* combo stacked chart * spec * remove irrelevant spec * combo stacking * fix selecting y-axis on stacked charts * snapshot * linter, specs, types * propagate combo stacking to area and bar charts (#42600) * propagate combo stacking to area and bar charts * enable combo stacking for bar/area charts, fix data transform * fix types, specs * fix y-axis extents calculations * remove spec that tested the removed control, update specs, update test data * review * show show data values setting on normalized charts that have a line series * fixes
-
- Apr 26, 2024
-
-
Aleksandr Lesnenko authored
Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
Mark Bastian <markbastian@gmail.com> Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- Mar 01, 2023
-
-
Nemanja Glumac authored
* Register new E2E path alias * Move E2E support files * Move E2E runner files * Move E2E snapshot related files * Move E2E visual regression tests * Move E2E `downloads` scenarios * Move E2E `admin` scenarios * Move E2E `auditing` scenarios * Move E2E `bining` scenarios * Move E2E `ccollections` scenarios * Move E2E `cross-version` scenarios * Move E2E `custom-column` scenarios * Move E2E `dashboard` scenarios * Move E2E `dashboard-filters` scenarios * Move E2E `dashboard` reproductions * Move E2E `embedding` scenarios * Move E2E `filters` scenarios * Move E2E `joins` scenarios * Move E2E `models` scenarios * Move E2E `native-filters` scenarios * Move E2E `native` scenarios * Move E2E `onboarding` scenarios * Move E2E `organization` scenarios * Move E2E `permissions` scenarios * Move E2E `question` scenarios * Move E2E `visualizations` scenarios * Move E2E `sharing` scenarios * Move E2E `docker-compose` * Fix commands imports * Fix helpers imports * Fix downloads reproductions imports * Fix integration imports * Move visual regression tests * Various fixes * Move `validate-e2e-files` script * Add eslint rules for E2E folder * Improve file paths * Move `cross-version` tests into scenarios * Path fixes * Register E2E alias in tsconfig * Fix failing tests after rebase
-
- Jun 21, 2022
-
-
Aleksandr Lesnenko authored
-