Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 11, 2022
  2. Apr 10, 2022
  3. Apr 08, 2022
  4. Apr 07, 2022
    • Noah Moss's avatar
      Data model permission enforcement part 2 (#21475) · e86e80ad
      Noah Moss authored
      * add can_access_data_model key to api/user/current
      
      * add exclude_uneditable flag to /api/database/:id/metadata
      
      * clean ns
      
      * WIP figuring out how to update perm checks for Field model
      
      * fix errors
      
      * fix more errors
      
      * tests for field APIs
      
      * table perms changes
      
      * tests for table API
      
      * fix function call
      
      * clean ns
      
      * perm enforcement for other table APIs
      
      * perm enforcement for other field APIs
      
      * address comments
      Unverified
      e86e80ad
    • Ngoc Khuat's avatar
      Fix SSO failed to sync admin group (#20991) · 0708ce0a
      Ngoc Khuat authored
      * fix failed to sync admin group
      
      * address noah's comments and add migration script
      
      * document for run-with-data-migration-index
      
      * update comments
      
      * fix name space
      
      * adding data_migrations tests
      
      * add docg
      
      * make sure we don't remove admin group if sso and ldap are not configured
      
      * fix tests for be-ee
      
      * fix tests for oss
      
      * misc docs updates
      
      * remove data-migration-index
      
      * return some newlines
      
      * is it failling here?
      
      * update data_migration docs
      
      * update data_migration docs
      
      * fix all styling comments
      
      * make migration to run both in oss and enterprise and make sure the tests are accounted for that
      
      * fix failed namespace checks
      
      * Add a comment to the test
      
      * fix per comments
      
      * Update permissions.clj
      
      * tweaking with the :warning: icon
      
      * refactor with-temporary-raw-setting-values
      
      * update comments
      
      * Add extension for cert file
      
      * address Noah's comments
      Unverified
      0708ce0a
  5. Apr 06, 2022
  6. Apr 05, 2022
  7. Apr 04, 2022
  8. Apr 01, 2022
    • Alexander Lesnenko's avatar
      FE: Download permission users UI (#20931) · 1da02e27
      Alexander Lesnenko authored
      * download permission UI with specs
      
      * permission editor UI tweaks
      
      * reset download permission on blocked data sources
      
      * update specs
      
      * update copy
      
      * update specs
      Unverified
      1da02e27
    • Noah Moss's avatar
      QP middleware for download perms (#21021) · 04473fc5
      Noah Moss authored
      Unverified
      04473fc5
    • Alexander Lesnenko's avatar
      FE: Subscriptions management permission (#21307) · eb50aafa
      Alexander Lesnenko authored
      * subscriptions management permission
      
      * specs
      
      * update contract
      
      * specs
      Unverified
      eb50aafa
    • Alexander Polyankin's avatar
    • Ngoc Khuat's avatar
      Grant Subscription permission by default (#21179) · e36304ec
      Ngoc Khuat authored
      * add API to fetch general permisisons graph
      
      * add API to update general permissionns
      
      * change author of migration
      
      * update documents
      
      * misc fixes to applease the CIs
      
      * Add tests for general permission APIs and models
      
      * linting and fix a failed test case
      
      * fix some failed tests
      
      * update docs and change /subscription/ to /general/subscription/ for consistency
      
      * Hook and migration to make sure subscription are created for new groups by default
      
      * add schema migrations tests
      
      * set for the win
      
      * address noah's comments
      
      * Parse number as is in http-client for tests
      
      * address Cam's comments
      
      * revert the last commit about parsing API response in tests
      
      * change fk name
      
      * delete a comment
      
      * Changes:
      - Rename `changes` column to `after` to keep things consistent
      - If a group  has no General Permisions, it'll not be included in the graph
      - Update tests and some docs
      
      * fix failing tests in ee
      
      * add some tests and make docstring completes
      
      * polishing comments
      
      * namespaces
      
      * fix namespaces
      
      * Add general permisison flags to `GET /api/user/current` (#21250)
      
      * return general permisison flags for /api/current
      
      * namespaces
      
      * move permission flags to under
      
      * Enforce Subscription permissions (#21285)
      
      * return general permisison flags for /api/current
      
      * namespaces
      
      * enforce general permissions for subscription and tests
      
      * update check-has-general-permisison to add option to require superuser
      
      * adding arity
      
      * add tests for permissions helper function
      
      * Move advanced permissions check funcs to ee namespace
      
      * unpushed changes
      
      * namespaces
      
      * ignore exception when load namespaces
      
      * change helper fn name
      
      * Enforce Monitoring Permissions (#21321)
      
      * return general permisison flags for /api/current
      
      * namespaces
      
      * enforce general permissions for subscription and tests
      
      * update check-has-general-permisison to add option to require superuser
      
      * adding arity
      
      * enforce permissions to call /api/dataset for internal queries
      
      * enforce monitoring permissions for api/task and api/util
      
      * add tests for OSS
      
      * add tests for db-connection-info endpoint
      
      * change test schema
      
      * update name func and fix ns
      
      * whydon't CI run ?
      
      * Enforce Setting Permissions (#21386)
      
      * return general permisison flags for /api/current
      
      * namespaces
      
      * enforce general permissions for subscription and tests
      
      * update check-has-general-permisison to add option to require superuser
      
      * adding arity
      
      * enforce permissions to call /api/dataset for internal queries
      
      * enforce monitoring permissions for api/task and api/util
      
      * add tests for OSS
      
      * add tests for db-connection-info endpoint
      
      * change test schema
      
      * update name func and fix ns
      
      * whydon't CI run ?
      
      * Enforce Setting permissions
      
      * fix failing test
      
      * make sure we could run slack test twice
      
      * make the mock consistent
      
      * address Noah's comments
      
      * shorter permissions check
      Unverified
      e36304ec
    • Noah Moss's avatar
      Unverified
      01092b5c
    • Noah Moss's avatar
      Data model permission writes & reads (#21168) · 2d81ec58
      Noah Moss authored
      Unverified
      2d81ec58
  9. Mar 30, 2022
    • Anton Kulyk's avatar
      Add global navigation sidebar (#21069) · 8b341b1a
      Anton Kulyk authored
      
      * Prototype new nav skeleton (#20875)
      
      * yarn
      
      * begin basic layout flip
      
      * rough in collections list
      
      * position query builder
      
      * remove fitViewport from QB to fix layout quirks
      
      * extract search
      
      * clean up props
      
      * position search / style
      
      * fix dashboard layout
      
      * fix search icon
      
      * move ProfileLink
      
      * tweak spacing
      
      * fix burger
      
      * add basic toggle
      
      * tweak layout for sidebar toggle
      
      * tweak style
      
      * tweak sidebar sizing
      
      * Quick fix to prototype starting points init (#20922)
      
      * fix scroll overflow on sidebar
      
      Co-authored-by: default avatarGustavo Saiani <gustavo@poe.ma>
      
      * add currentUser to profile link
      
      * move footer items out of collection sidebar
      
      * tweak footer style
      
      * fix hover style
      
      * clean up footer
      
      * fixup
      
      * remove un-needed overflow hidden
      
      * hide app bar when in admin mode
      
      * merge sidebar header into new color scheme / nav layout
      
      * clean up headers
      
      * fix root collection spacing
      
      * smaller font size for nav items
      
      * provide flex context, fixes metadata editing
      
      * fix login page
      
      * Remove console logs
      
      * Put user's personal collection under Our analytics (#21061)
      
      * Browsing | Handle long item names in the sidebar (#21063)
      
      * Handle long names in the nav sidebar
      
      * Show tooltip with a full item name if its cut
      
      * Browsing | Fix data reference & admin permissions layout (#21101)
      
      * Remove admin navbar CSS fix
      
      * Handle admin navbar in root App component
      
      * Extract styled components
      
      * Fix data reference layout
      
      * Fix main container height
      
      * Browsing | Hide sidebar for questions, models and dashboards on page open (#21064)
      
      * Manage default sidebar visibility
      
      * Handle ad-hoc questions better
      
      * Move nav elements based on feedback (#21190)
      
      * scoot buttons around
      
      * move logo to appbar, scoot search
      
      * remove user footer, home link [ci skip]
      
      * review feedback [ci skip]
      
      * fix accidental removal of links (minimalism was a fad anyway) (#21192)
      
      * add button classes to new button (#21213)
      
      * Nav visual changes (#21223)
      
      * switch nav bg + move styling to NavRoot
      
      * readable text
      
      * increase contrast
      
      * selected icon color
      
      * remove bottom padding
      
      * search bar color
      
      * restructure sidebar position
      
      * fix sidebar header color
      
      * move to fixed when small
      
      * fix multiple scrollbars
      
      * fix sidebar width
      
      * home as own item, gear below
      
      * fix admin nav
      
      * extract nav constant, fix types
      
      * remove unused constant [ci skip]
      
      * New nav - get base colors in order (#21262)
      
      * new sidebar button
      
      * nav bg to bg-light
      
      * fix link track, remove extra home link
      
      * color tweaks
      
      * swap colors
      
      * Fix E2E tests for new navigation UI (#21196)
      
      * Use `main` HTML tag for main page content
      
      * Add extra UI helpers for Cypress
      
      * Fix tests failing due to nav UI changes
      
      * Remove not needed NavBar code
      
      * Fix loading databases list
      
      * Use `navigationSidebar` helper for collections
      
      * Use `navigationSidebar` for collection tests
      
      * Close sidebar in SQL filters tests
      
      * Extract AppBar component to `metabase/nav`
      
      * Fix test
      
      * Fix test
      
      * Skip sidebar visibility control test
      
      * Fix JSON engine DB check
      
      * Fix DatasetEditor edit bar colors
      
      * Fix global containers heights
      
      * Fix tests scrolling target
      
      * Fix styles
      
      * Fix navbar cypress helpers
      
      * [ci nocache]
      
      * Fix scroll in e2e test
      
      * Browsing | Manage sidebar state with redux (#21226)
      
      * Move navbar state to redux
      
      * Hide sidbebar using CSS
      
      * Fix native E2E test
      
      * Fix native e2e test
      
      * Fix model tests
      
      * Use more accurate element getters
      
      * Fix e2e tests
      
      * Browsing | Fix dashboard UI (#21233)
      
      * Fix parameter widgets event listeners
      
      * Attach scroll events to "main" instead of window
      
      * Resize filters panel when navigation sidebar open
      
      * Reorder imports at App
      
      * Hide AppBar and NavBar when editing dashboard
      
      * Fix navbar & appbar visibility
      
      * Fix filter positions
      
      * Extract `getMainElement` helper
      
      * Update unit tests
      
      * Fix test
      
      * Browse fix bulk actions (#21320)
      
      * make bulk action bar aware of sidebar, remove extraneous layout components
      
      * clean up styling
      
      * convert BulkActionBar to tsx
      
      * Fix types
      
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Co-authored-by: default avatarGustavo Saiani <gustavo@poe.ma>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      8b341b1a
  10. Mar 29, 2022
    • Noah Moss's avatar
    • Ngoc Khuat's avatar
      Add General Permissions graph APIs (#21124) · 57d0ff0a
      Ngoc Khuat authored
      * add API to fetch general permisisons graph
      
      * add API to update general permissionns
      
      * change author of migration
      
      * update documents
      
      * misc fixes to applease the CIs
      
      * Add tests for general permission APIs and models
      
      * linting and fix a failed test case
      
      * fix some failed tests
      
      * update docs and change /subscription/ to /general/subscription/ for consistency
      
      * address noah's comments
      
      * Parse number as is in http-client for tests
      
      * revert the last commit about parsing API response in tests
      
      * change fk name
      
      * Changes:
      - Rename `changes` column to `after` to keep things consistent
      - If a group  has no General Permisions, it'll not be included in the graph
      - Update tests and some docs
      
      * fix failing tests in ee
      
      * add some tests and make docstring completes
      
      * fix namespaces
      Unverified
      57d0ff0a
  11. Mar 28, 2022
  12. Mar 23, 2022
  13. Mar 16, 2022
  14. Mar 15, 2022
  15. Mar 14, 2022
  16. Feb 23, 2022
  17. Feb 17, 2022
  18. Feb 16, 2022
  19. Feb 08, 2022
    • Alexander Lesnenko's avatar
      Migrate styled-components 3 to the latest emotion (#20275) · 63c607fc
      Alexander Lesnenko authored
      * replace attrs to defaultProps (#20260)
      
      * replace attrs to defaultProps
      
      * fix replaced attrs
      
      * fix className in defaultProps
      
      * use emotion (#20265)
      
      * replace attrs to defaultProps
      
      * fix replaced attrs
      
      * use emotion
      
      * fix typo in css
      
      * eliminate innerRefs
      
      * fixes
      
      * fixes
      
      * fixes
      
      * fixes
      
      * flakes
      
      * specs
      
      * specs
      
      * docs
      
      * specs
      
      * fix last spec
      
      * remove classNames from defaultProps
      Unverified
      63c607fc
    • Jeff Evans's avatar
      Remove :bigquery driver (#20142) · 22ebe102
      Jeff Evans authored
      
      * Remove :bigquery driver
      
      Add "migration" to convert existing Database instances from :bigquery to :bigquery-cloud-sdk (with error log if using outdated OAuth mechanisms), by way of `normalize-db-details`
      
      Removing references to :bigquery from various places in the code
      
      * Remove from modules/drivers/deps.edn
      
      * Remove stuff from CircleCI that is running the old driver
      
      Remove `driver-switch-test` since there is no practical way to run this anymore (since we can't initialize the old driver)
      
      Remove buggy redef of `isa?` from `semantic-type-migration-tests`
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      22ebe102
    • Cam Saul's avatar
      Rework how the remappings middleware matches remapped to/from columns for... · e35ecaca
      Cam Saul authored
      Rework how the remappings middleware matches remapped to/from columns for explicit external (FK) remaps (#20009)
      
      * Fix #9236 [WIP]
      
      * Revert unneeded changes
      
      * Only merge namespaced :options into result info
      
      * Revert unneeded changes
      
      * Everything is working :scream_cat:
      
      * Revert unneeded change
      
      * Clean namespaces
      
      * Add `:test` profile to `namespace-checker` to suppress log messages.
      
      * PR feedback
      
      * Fix namespaces
      Unverified
      e35ecaca
Loading