This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 24, 2021
-
-
Nemanja Glumac authored
-
Ariya Hidayat authored
-
- Aug 23, 2021
-
-
Dalton authored
* enable unset default params on dashboard * add unit tests
-
Gustavo Saiani authored
-
Nemanja Glumac authored
* Update parameter names in `editDashboardCard` Cypress custom command * Update tests
-
Howon Lee authored
Mongo custom expressions now are turned on for mongo 5.0 and after only. One idiosyncrasy is that we don't really support the BSON ID format at all in our typesystem despite having it in there, but both of my attempts to get them to work with the native mongo pipeline commands bounced because they really aren't strings, they're BSON ID's. We do rely on the pipeline commands heavily which is the reason for the version requirement.
-
Ariya Hidayat authored
-
Ariya Hidayat authored
This requires unfortunately an additional layer of indirection, however I believe it's super cheap and it shouldn't impact execution speed. In the mean time, many other predicates (isFoo etc) which rely on isa() will be correctly type-inferred, which gives a huge win for editing and debugging purposes.
-
Noah Moss authored
-
Nemanja Glumac authored
* Expand `setAdHocFilter` helper function to include current date * Add repro for #17551 * Update test title
-
dpsutton authored
I'm not sure we can fix this. We need the graal compiler which doesn't appear to be jdk 8 compatible but I can't actually find javadocs for it. Its not clear from https://github.com/oracle/graaljs/blob/master/docs/user/RunOnJDK.md how you can actually run it. I tried adding the graal compiler but that seems to assume you are in a graal vm and fails not finding a class. To get a list of all the options available for a context's engine, ```clojure (doto 'metabase.pulse.render.js-engine require in-ns) (map (comp (juxt :name :help) bean) (.getOptions (.getEngine (context)))) ``` I've done some profiling ```clojure (dotimes [_ 5] (time (do (let [rows [["apples" 2] ["bananas" 3]] colors {"apples" "red" "bananas" "yellow"}] (js-svg/categorical-donut rows colors)) nil))) "Elapsed time: 210.32659 msecs" "Elapsed time: 193.211736 msecs" "Elapsed time: 190.97775 msecs" "Elapsed time: 195.843254 msecs" "Elapsed time: 188.077405 msecs" nil ``` For interpreted and in another language, this doesn't seem the end of the world. And adding more quantities ```clojure (letfn [(rand-string [] (str/join "-" (repeatedly 4 #(rand-nth ["banana" "horse" "battery" "cloak"]))))] (dotimes [_ 5] (let [rows (repeatedly 20 (fn [] [(rand-string) (rand-int 100)])) colors (zipmap (map first rows) (cycle ["red" "green" "blue" "yellow"]))] (time (js-svg/categorical-donut rows colors))))) "Elapsed time: 288.659887 msecs" "Elapsed time: 334.733071 msecs" "Elapsed time: 317.369294 msecs" "Elapsed time: 272.084918 msecs" "Elapsed time: 272.7203 msecs" nil ``` For a timeline line chart, rendering one datapoint per day for a whole year: ```clojure (dotimes [_ 5] (let [dates (take 365 (iterate #(.plusDays % 1) #t "2020")) rows (map (fn [d] [d (rand-int 200)]) dates) labels {:left "count" :bottom "year"}] (time (js-svg/timelineseries-line rows labels)))) "Elapsed time: 569.691124 msecs" "Elapsed time: 544.415676 msecs" "Elapsed time: 539.131092 msecs" "Elapsed time: 492.60486 msecs" "Elapsed time: 523.765691 msecs" nil ```
-
Noah Moss authored
-
Alexander Lesnenko authored
-
Greg Wilson authored
* Troubleshooting guide for filters. After conversation with @flamber, split this into one guide for simple filters and one for linked filters. The explanation at the top of the second page may still need some work... * Updating filter troubleshooting * Troubleshooting when you can't see the tables you should. * Why is my dashboard slow? * Troubleshooting: can't send email * Adding @flamber's batch script-style guide * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * Fixing first item * Addressing feedback * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-send-email.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Adding flamber's comment * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Splitting entry * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Troubleshooting timezones * Reformatting the filter troubleshooting guides * Partial update to troubleshooting filters * specify sql questions * link * update relative links * more link fixes * still more links * specify dashboard filters * fix typo * Italicizing one more word * Unifying all troubleshooting guides so far * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/cant-see-tables.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Incorporating suggestion * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Update docs/troubleshooting-guide/my-dashboard-is-slow.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Another small fix Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> Co-authored-by:
jeff bruemmer <jeff.bruemmer@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Aug 21, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Aug 20, 2021
-
-
Jeff Evans authored
* Fix serialization dump error when there are no collections Update `select-collections` to correctly handle the case where there are no collections Adding new test that removes all collections, then ensures that dump works with no errors * Fix serialization load error into empty/blank target DB Rethrowing exception in cmd when overall load fails Add test to ensure that a dump containing a user can be loaded into a blank target app DB successfully Adding a few missing bindings to the `with-temp-empty-app-db` code to set the connection vars under metabase.db.connection In upsert, add hooks for a :pre-insert-fn and :post-insert-fn to be invoked for new entity instances created by the upsert process, since whether an entity will be an insert or update isn't necessarily known by the load process (only by upsert once identity-condition is checked for each) In load, setting the pre and post insert functions for a User instance to initialize :password with a random value, and to generate and send a password reset email to the newly inserted user's email, respectively NOTE: this post insert fn (to send a password reset email for newly inserted users) is NOT hooked up for User as of x.41 release, since it is considered a bugfix, but this can be enabled in a future release) Adding new defs for the magic permission group names to make those easier to override from tests that might need to (such as the one added for this commit) * Fix serialization objects being incorrectly updated on skip Remove `maybe-fixup-card-template-ids!`, which was forcing mode :update, since the existing retry logic should cover what it was trying to do Update Card and Metric models to delete any Dependency instances for which they are the `:model_id` (to make serialization tests after other tests created temporary Card/Dependency pairs) Adding missing assertions for Dependency serialization * Serialization: Fix reload entity logic Now that the `:mode` is always respected instead of being ignored sometimes, we need to update our "second pass" reload functions to always make the mode `:update` on the second pass, or else that entity would just be skipped, which is bad Also updated the test to use `:mode` `:skip` from the beginning to be more stringent
-
Dalton authored
* refactor/move parameter object transformations to one place * use hasParameterValue in place of nil check * remove enableDefaultParameters arg since it is unused
-
Gustavo Saiani authored
-
Jeff Evans authored
New BigQuery Driver Create new :bigquery-cloud-sdk driver using the google-cloud-bigquery library instead, and whose source is adapted from the :bigquery driver https://cloud.google.com/bigquery/docs/reference/libraries Marking existing :bigquery driver as deprecated, and superseded-by the new one (bigquery-cloud-sdk) Update new driver and query processor code to use newer Google SDK Switch test data loading over to use new API Add project-id connection property to override the value from the service account JSON, and use it as part of qualified names in the query processor if set Updating google driver so its libraries are compatible with the newer ones used in BigQuery Update date bucketing tests to skip :bigquery-cloud-sdk (new driver) where :bigquery is skipped Update `with-bigquery-fks` to take in the driver, since there are now multiple ones Adding test to confirm that overriding project-id for a public BQ project works (sync and query) Fixing a bunch of whitespace alignment errors in tests
-
Ariya Hidayat authored
Type inference can already correctly infer those return types, no need to explicit anymore.
-
Ariya Hidayat authored
-
Nemanja Glumac authored
* Update `dashboard` custom Cypress command * Update composite custom commands to accommodate new syntax * Update tests that use `cy.createDashboard()` custom command * Update default snapshot generator
-
- Aug 19, 2021
-
-
Anton Kulyk authored
-
Dalton authored
* don't prefetch data for the data selector * rmv prefetch cy test * fix mongo test
-
Alexander Lesnenko authored
* replace backport label with a more flexible backport command * fix backport bot command
-
Ariya Hidayat authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Remove not displayed NotebookCell's 'icon` prop * Refactor NotebookCell to accent `right` prop * Fix cypress getter * Fix icons opacity * Fix margins and paddings * Pass initialState to getStore test helper * Add basic tests for JoinStep * Test automatic join fields assignment * Add selectTable test helper * Fix private property access * Add join fields tests * Test join is correctly applied to query * Add more tests for join dimension pickers * Test selecting joined table columns * Disable failing JoinStep test (jest timeout) * Extend timeout for JoinStep tests
-
Alexander Lesnenko authored
-
- Aug 18, 2021
-
-
dpsutton authored
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Ariya Hidayat authored
Regression in PR #17460
-
Anton Kulyk authored
* Add tooltips to authority level configs * Use tooltips for CollectionAuthorityLevelIcon * Pass tooltips to getCollectionIcon result * Display tooltip in CollectionHeader * Display tooltip in collections sidebar * Display tooltip on the homepage * Display tooltip in ItemPicker * Accept icon props as a TreeNode's icon prop value * Display tooltip in saved question picker * Accept icon props as a SelectListItem's icon prop value * Display tooltip in dashboard's question picker * Add "Belongs to an Official collection" tooltip * Fix prop-types errors * Add tests for CollectionAuthorityLevelIcon * Add tests for isRegularCollection * Fix search results collection icons * Show "Official Collection" label in search results * Don't show tooltips for official collections in search * Fix ItemPicker's prop type * Add basic test for ItemPicker * Test read-only collections are not displayed * Add test IDs to ItemPicker * Refresh Redux store in each ItemPicker's test * Test opening a nested collection * Test default breadcrumbs state * Fix ItemPicker's header test ID * Test ItemPicker read-only items visibility * Add test for onChange prop * Test navigating back from an open collection * Test personal collections are grouped in ItemPicker * Assert number of ItemPicker items * Test getCollectionIcon in EE * Add a workaround for tooltip offsets * Add describe block for CollectionsList tests * Make CollectionsList test shorter * Test collection types on CollectionList * Fix SearchResult's info * Add SearchResult tests * Use isRegularCollection for AuthorityLevelIcon
-
Ariya Hidayat authored
codecov patch calculation is incorrect. Thus, let's rely only on the whole-project calculation and threshold (which is working fine).
-
Nemanja Glumac authored
-