This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 26, 2021
-
-
Ariya Hidayat authored
-
- Aug 25, 2021
-
-
Ariya Hidayat authored
-
Cam Saul authored
*
B L O C K permissions * Fix test failure in OSS since EE namespace doesn't exist. * Remove unused var * Oops, uncomment a commented-out test * Clean up the new perms documentation a bit -
Ariya Hidayat authored
-
Noah Moss authored
-
Jeff Evans authored
0.254 -> 0.260
-
Alexander Lesnenko authored
-
Alexander Lesnenko authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Enable repro tests * Don't sync stuctured questions on query complete
-
dpsutton authored
```bash % curl 'http://localhost:3000/api/card/760' -H <stuff omitted> | jq % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2003 0 2003 0 0 102k 0 --:--:-- --:--:-- --:--:-- 102k { "description": null, "archived": false, "collection_position": null, "table_id": 2, "creator_id": 1, "moderation_reviews": [ { "most_recent": true, "moderator_id": 1, "updated_at": "2021-08-16T21:30:00.665952Z", "status": "verified", "id": 1026, "user": { "email": "dan@metabase.com", "first_name": "dan", "last_login": "2021-08-10T21:17:35.366176Z", "is_qbnewb": false, "is_superuser": true, "id": 1, "last_name": "sutton", "date_joined": "2021-03-15T20:42:55.751834Z", "common_name": "dan sutton" }, "moderated_item_id": 760, "created_at": "2021-08-16T21:30:00.665952Z", "moderated_item_type": "card", "text": null } ], "dataset_query": { "database": 1, "query": { "source-table": 2 }, "type": "query" }, "id": 760, "display": "table", "last-edit-info": { "id": 1, "email": "dan@metabase.com", "first_name": "dan", "last_name": "sutton", "timestamp": "2021-05-12T22:04:57.205978Z" }, ... } ```
-
dpsutton authored
* Include the results base type as the cols effective type previously was merged the effective type from the col which caused issues with dates when selecting a particular temporal unit, ie month. Queries like this return months as integers so the base and effective types are :type/Integer, and something somewhere else is responsible for the unit conversion of `1` to January (or feb, months get weird i think) ```clojure ;; after {:description "The date and time an order was submitted.", :unit :month-of-year, :name "CREATED_AT", :field_ref [:field 4 {:temporal-unit :month-of-year}], :effective_type :type/Integer, ;; we have the proper effective type :display_name "Created At", :base_type :type/Integer} ;; before: {:description "The date and time an order was submitted.", :unit :month-of-year, :name "CREATED_AT", :field_ref [:field 4 {:temporal-unit :month-of-year}], :effective_type :type/DateTime, ;; included effective type from db :display_name "Created At", :base_type :type/Integer} ``` * tests * Driver tests * Ignore effective/base types in breakout tests sparksql is weird and its totally unrelated to the file under test * Use correct options for datetimes that are projected to month, etc When aggregating by a datetime column, you can choose a unit: month, hour-of-day, week, etc. You often (always?) end up with an integer. Previously the base_type was (inexplicably) :type/Integer and the effective_type was :type/DateTime which really just didn't make sense. The ideal solution is :type/DateTime as the base_type and :type/Integer as the effective_type. But this breaks the frontend as it expects to treat these columns in a special way. But it expected them to report as date columns. I've changed it only here. I thought about making isDate understand the `column.unit` attribute and recognize that these are in fact dates, but that seems wrong. These are integers that are special cases. It seems that the contexts that need to talk about dates should understand integers in a special way than all date code needs to be aware that integers might flow through. This might mean extra work but ultimately feels better as the correct solution. * unit is not default
-
Nemanja Glumac authored
-
Anton Kulyk authored
* Move JoinStep's NotebookCell down to JoinClause * Break JoinClause into two NotebookCells * Update labels * Use `space` helper function * Simplify conditional statement * Fix not translated string
-
Alexander Polyankin authored
-
- Aug 24, 2021
-
-
Ariya Hidayat authored
-
Gustavo Saiani authored
-
Jeff Evans authored
* Add Kerberos support to Presto JDBC Driver Adding Kerberos properties as DB details properties Refactoring utility methods for dealing with additional options Adding test for Kerb properties -> connection string Adding GitHub action to run integration test Start to move logic for capturing necessary files to new script, and calling that from mba run Adjust settings in `metabase.test.data.presto-jdbc` to capture test parameters
-
Jeff Evans authored
Fix counting on grouped aggregated field Adding QP test Reworking the BigQuery version of the :breakout to more closely match the structure of the standard sql.qp version
-
Gustavo Saiani authored
-
Noah Moss authored
-
Nemanja Glumac authored
-
Alexander Lesnenko authored
* add PermissionSelect component * add PermissionSidebar component * add PermissionTable component * add PermissionEditor component * add useLeaveConfirmation hook * add selectors for the collections permissions page * add selectors for the data permissions pages * add confirmation creators to use in selectors * sandboxing permissions modal: redirect to parent route when closed * Add PermissionsPageLayout component * Adjust CollectionPermissionsModal to use new permissions UI * Add CollectionPermissionsPage * Add data permissions pages * Adjust collection permissions modal route * Adjust permissions routes according new pages structure * update permissions actions, reducers * adjust sandboxing * remove old permissions code * support admin colorScheme in Radio * support admin colorScheme in TextInput * support admin colorScheme in Tree * update permissions specs * fix data permissions url typo * fix sandboxing * add search debounce to permission pages * exclude schemas from search, make it flat * fix permissions for databases without schemas * fix copy for native queries permissions, show table display_name instead of raw name * fix before leave warning shown when change collections * permissions sidebar: make database name clickable * fix string groupIds lead to bugs in permissions editor * fix disabling table permissions shows all tables permission disabled * fix permissions copy * fix permissions disabled tooltips copy * fix, add specs * fix permissions edit bar button colors, fix breadcrumbs on schemaless dbs * fix official collection color, make sidebar tree scrollable * fix scroll in permissions modal * fix breadcrumbs * change table icon * create helpers for entity ids and permissions url creation * remove hardcoded colors * make confirmations an array * store confirmAction in state * add ModalRoute specs * fix propTypes, typo * build permission pages urls with helpers * revert switching from ref to state for confirm action function due to react invokes it on a render * move mapStateToProps to the top of the files * add visual specs * add more specs * fix edit sandbox access action * add cypress spec for sandboxing
-
Ariya Hidayat authored
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Try reverting mongo QA image back to 4.0 * Update mongo query assertion
-
Nemanja Glumac authored
-
Ariya Hidayat authored
-
- Aug 23, 2021
-
-
Dalton authored
* enable unset default params on dashboard * add unit tests
-
Gustavo Saiani authored
-
Nemanja Glumac authored
* Update parameter names in `editDashboardCard` Cypress custom command * Update tests
-
Howon Lee authored
Mongo custom expressions now are turned on for mongo 5.0 and after only. One idiosyncrasy is that we don't really support the BSON ID format at all in our typesystem despite having it in there, but both of my attempts to get them to work with the native mongo pipeline commands bounced because they really aren't strings, they're BSON ID's. We do rely on the pipeline commands heavily which is the reason for the version requirement.
-
Ariya Hidayat authored
-
Ariya Hidayat authored
This requires unfortunately an additional layer of indirection, however I believe it's super cheap and it shouldn't impact execution speed. In the mean time, many other predicates (isFoo etc) which rely on isa() will be correctly type-inferred, which gives a huge win for editing and debugging purposes.
-
Noah Moss authored
-
Nemanja Glumac authored
* Expand `setAdHocFilter` helper function to include current date * Add repro for #17551 * Update test title
-
dpsutton authored
I'm not sure we can fix this. We need the graal compiler which doesn't appear to be jdk 8 compatible but I can't actually find javadocs for it. Its not clear from https://github.com/oracle/graaljs/blob/master/docs/user/RunOnJDK.md how you can actually run it. I tried adding the graal compiler but that seems to assume you are in a graal vm and fails not finding a class. To get a list of all the options available for a context's engine, ```clojure (doto 'metabase.pulse.render.js-engine require in-ns) (map (comp (juxt :name :help) bean) (.getOptions (.getEngine (context)))) ``` I've done some profiling ```clojure (dotimes [_ 5] (time (do (let [rows [["apples" 2] ["bananas" 3]] colors {"apples" "red" "bananas" "yellow"}] (js-svg/categorical-donut rows colors)) nil))) "Elapsed time: 210.32659 msecs" "Elapsed time: 193.211736 msecs" "Elapsed time: 190.97775 msecs" "Elapsed time: 195.843254 msecs" "Elapsed time: 188.077405 msecs" nil ``` For interpreted and in another language, this doesn't seem the end of the world. And adding more quantities ```clojure (letfn [(rand-string [] (str/join "-" (repeatedly 4 #(rand-nth ["banana" "horse" "battery" "cloak"]))))] (dotimes [_ 5] (let [rows (repeatedly 20 (fn [] [(rand-string) (rand-int 100)])) colors (zipmap (map first rows) (cycle ["red" "green" "blue" "yellow"]))] (time (js-svg/categorical-donut rows colors))))) "Elapsed time: 288.659887 msecs" "Elapsed time: 334.733071 msecs" "Elapsed time: 317.369294 msecs" "Elapsed time: 272.084918 msecs" "Elapsed time: 272.7203 msecs" nil ``` For a timeline line chart, rendering one datapoint per day for a whole year: ```clojure (dotimes [_ 5] (let [dates (take 365 (iterate #(.plusDays % 1) #t "2020")) rows (map (fn [d] [d (rand-int 200)]) dates) labels {:left "count" :bottom "year"}] (time (js-svg/timelineseries-line rows labels)))) "Elapsed time: 569.691124 msecs" "Elapsed time: 544.415676 msecs" "Elapsed time: 539.131092 msecs" "Elapsed time: 492.60486 msecs" "Elapsed time: 523.765691 msecs" nil ```
-
Noah Moss authored
-