This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 21, 2024
-
-
github-automation-metabase authored
-
Phoomparin Mano authored
-
- Jun 20, 2024
-
-
Noah Moss authored
-
Nicolò Pretto authored
* simplify bordered logic *
setTitled * setHideDownloadButton * setHideParameters * inline useEmbedDisplayOptions * move DEFAULT_EMBED_DISPLAY_OPTIONS to costants file so we can remove use-embed-display-options.ts * move consts up in the file * update deps of useEffect * fix ts error in the sdk * use useEmbedFrameOptions in useDashboardUrlParams * embed frame should not touch the `embed` slice, which is used for interactive embedding -
Mahatthana (Kelvin) Nomsawadi authored
-
Raphael Krut-Landau authored
-
Phoomparin Mano authored
* funnel start color should be text-dark * change pivot table font size unit to em for scaling * change funnel and legend item unit to em * change funnel font size to em * change object detail font size to em * change gauge font size to em * add cartesian chart padding config * update docs * remove isEmbeddingSdk prop * simulate the 0.875em base font size * chart padding override should apply in query builder * add cartesian padding to stories * update readme docs * fix collection browser option in readme docs * fix pivot table font size scaling * update loki * update loki * use em for smart scalar * update chart default padding * revert smart scalar font size scaling due to measurement * dynamic font family and font size as defaults * pivot table * add more properties to sdk docs * make FONT_SIZES constant local * link to discussion on query builder extra spacing * enforce that font is passed to getLeftHeaderWidths
-
Phoomparin Mano authored
* load custom font family * always return custom font family * add tests for returning custom font family
-
github-automation-metabase authored
-
Alberto Perdomo authored
Remove warnings about not using MB versions in production. This is a left over from the time we were pointing to builds off master and RCs.
-
- Jun 19, 2024
-
-
Raphael Krut-Landau authored
* Use an indicator-agnostic testid * Run sed * Use correct testid
-
Raphael Krut-Landau authored
Ensures that minimum query durations are correctly displayed in the form post-save (#44249) and that all times can be used in the Schedule component (#44257)
-
Cal Herries authored
Exclude native query matches in search scoring when the search should exclude native queries (#43982) Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
Denis Berezin authored
* Temp * Add support for saved questions * Try to fix question not found issue * Try to fix question not found issue * Fix unit tests * Add basic unit test * Fix unit tests * Fix unit tests, fix question not found issue * Review fixes * Review fixes * Refactor components structure, review fixes * Adjust readme
-
github-automation-metabase authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Update readme pointing to newer 50 release * Update enterprise/frontend/src/embedding-sdk/README.md Co-authored-by:
Phoomparin Mano <poom@metabase.com> --------- Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
Alexander Solovyov authored
Also OpenAPI generation now handles parameter renaming, like in `{c :count}` destructuring.
-
github-automation-metabase authored
-
Ngoc Khuat authored
-
- Jun 18, 2024
-
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Jun 17, 2024
-
-
Alberto Perdomo authored
Tweak the callout about the SDK still being in development
-
Raphael Krut-Landau authored
* wip * Remove references to the old enable-query-caching setting * remove fixme * linter * remove some more instances * fix imports
-
- Jun 14, 2024
-
-
github-automation-metabase authored
-
Oisin Coveney authored
fix(sdk): Update README to move `Embedding the collection browser` to `Features currently supposed` (#44208)
-
Raphael Krut-Landau authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Phoomparin Mano authored
* docs update * add dashboard.backgroundColor
-
- Jun 13, 2024
-
-
Raphael Krut-Landau authored
This PR removes: - a warning about missing React keys in the `Schedule` component - a warning about invalid props in the `StrategyFormLauncher` component
-
Noah Moss authored
-
Noah Moss authored
* little bit of refactoring in sso test code * use :once instead of :each
-
Phoomparin Mano authored
* expose card title settings * Add dashboard test skeleton * add a sample dashcard to the test * dashboard grid should have card title by default * add unit test for card title * remove unused delay in unit test * fix width and height being smaller than min values * flip grid layout condition --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Phoomparin Mano authored
* apply cell background color * add id column overrides * do not add transparency to id column cell when overridden * fix static dashboard theming * update loki reference image * add style resets and regenerate loki snapshots * add style resets and regenerate loki snapshots
-
- Jun 12, 2024
-
-
Raphael Krut-Landau authored
-
Oisin Coveney authored
-
- Jun 11, 2024
-
-
bryan authored
* adds the endpoint and a test * add recents endpoint, todo: tests * add post recents endpoint * return recent views for both lists, but make the endpoint work * Make recent-views context aware - pruning is context aware, only checks for the recently-inserted context - Adds endpoints: - POST to create selection recents, - GET activity/recents - requres context query param to be one of: - all, views, selections - Adds context arg to update-users-recent-views! - Cleans up arg schema for update-users-recent-views * impl GET api/activity/recents - return recent-selections and recent-views from - send context == collection from pinned card reads * update callsites of recent-views/update-users-recent-views! - to use :view param where necessary * fixes models/recent-view tests * adds more activity/recent-view tests * wip - fix whitespace linter * Fix command palette e2e test - reuse util snake-keys * updates fe to use new recents endpoints * fixes fe type issue * snake-keys -> deep-snake-keys - I've been betrayed by lsp rename * snake-keys -> deep-snake-keys - I've been betrayed by lsp rename * log selection events for created collections * mysql doesn't allow default values for TEXT types * log a recent view on data-picker selection * decouple view-log context from card-event view context * fix a doc typo * stop double logging recent-views on POST * maybe fixes some tests * some e2e fixes * fix mysterious divide by zero during score search * fix divide by zero possibilities everywhere in score-items metabase.api.activity/score-items used to throw when there weren't any items being scored (even though there's a `(when (seq items) ...)` check) * more test fixes * fix more e2e tests, + rename endpoint in tests * fix oopsie * fixes a few more tests * address review comments/questions * allow for a comma delimited list in qps like ?context=views,selections returns all recent view items with those contexts, most recent first under the `:recents` key. * refactors FE around new endpoint * fixes for unit tests * use ms/QueryVectorOf for context * fix models/recent_views tests * use multiple query params instead of comma delimited value on FE * ignore timestamp when deduping recents * review comments + test fixing * update docstring * fix api/activity_test s * actually dedupe * add test for deduping by context * e2e fix: shows up-to-date list of recently viewed items after another page is visited * e2e fix: should undo the question replace action * e2e fix: should replace a dashboard card question (metabase#36984) * e2e fix: should preselect the most recently visited dashboard * fix 6 more e2e tests * fixes fe type check and unit failure * renames unit test mocking function * fix a flaky e2e test * widen Item to accept str or kw where sensible - allow strings or keywords for moderated_status, and authority_level * simplify impl + add test * add view-log to events schema * add collection context to view log * fix the final 2 failing e2e tests * click dashboard tab when the user has can-read? on recent entities --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
John Swanson authored
* Improve the Trash Ok, so I had a realization at the PERFECT time, immediately after the RC cutoff. Great job, brain! Here's the realization. For the Trash, we need to keep track of two things: - where the item actually is located in the hierarchy, and - what collection we should look at to see what permissions apply to the item. For example, a Card might be in the Trash, but we need to look at Collection 1234 to see that a user has permission to Write that card. My implementation of this was to add a column, `trashed_from_collection_id`, so that we could move a Card or a Dashboard to a new `collection_id`, but keep track of the permissions we actually needed to check. So: - `collection_id` was where the item was located in the collection hierarchy, and - `trashed_from_collection_id` was where we needed to look to check permissions. Today I had the realization that it's much, much more important to get PERMISSIONS right than to get collection hierarchy right. Like if we mess up and show something as in the Trash when it's not in the Trash, or show something in the wrong Collection - that's not great, sure. But if we mess up and show a Card when we shouldn't, or show a Dashboard when we shouldn't, that's Super Duper Bad. So the problem with my initial implementation was that we needed to change everywhere that checked permissions, to make sure they checked BOTH `trashed_from_collection_id` and `collection_id` as appropriate. So... there's a much better solution. Instead of adding a column to represent the *permissions* that we should apply to the dashboard or card, add a column to represent the *location in the hierarchy* that should apply to the dashboard or the card. We can simplify further: the *only time* we want to display something in a different place in the hierarchy than usual is when it was put directly into the trash. If you trash a dashboard as a part of a collection, then we should display it in that collection just like normal. So, we can do the following: - add a `trashed_directly` column to Cards and Dashboards, representing whether they should be displayed in the Trash instead of their actual parent collection - use the `collection_id` column of Cards and Dashboards without modification to represent permissions. There's one main downside of this approach. If you trash a dashboard, and then delete the collection that the dashboard was originally in, what do we do with `dashboard.collection_id`? - we have to change it, because it's a foreign key - we can't set it to null, because that represents the root collection In this initial implementation, I've just cascaded the delete: if you delete a dashboard and then delete a collection, the dashboard will be deleted. This is not ideal. I'm not totally sure what we should do in this situation. * Rip out all the `trashed_from_collection_id` * Migration to delete trashed_from_collection_id * fixes * don't move collections And don't allow deleting collections * only show cards/dashboards with write perms * Show the correct archived/unarchived branch * some cleanup * add a todo for tomorrow * Fix for yesterday's TODO * more wip * refactor * memoize collection info * move around memoization a bit * fix schema migration test * oops, delete server.middleware.memo * Use a migration script (postgres only for now) * Fix some tests * remove n+1 queries in `collection-can-restore` * fix test * fix more tests, and x-db migration script * fix h2 rollback * fix mysql/mariadb migration * lint * fix some mariadb/mysql tests * fix h2 rollback * Fix mysql rollback * Fix Postgres migration * "Real" `trash_operation_id` UUIDs from migration * fix mariadb migration * Separate MySQL/MariaDB migrations * trashed directly bit->boolean * Remove `trashed_from_*` from migrations * Rename `api/updates-with-trashed-directly` Previously named `move-on-archive-or-unarchive`, which was no longer accurate since we're not moving anything! * Add `can_delete` * Delete test of deleted code * Can't move anything to the Trash The Trash exists as a real collection so that we can list items in and such without needing special cases. But we don't want anything to _actually_ get moved to it. * integrates can_delete flag on FE * Update src/metabase/models/collection.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Update src/metabase/search/impl.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Better name for `fix-collection-id` Also consolidated it into a single function. It takes the trash-collection-id as an argument to prevent a circular dependency. * s/trashed/archived/ on the backend In the product, we want to move to "trashed" as the descriptor for things that are currently-known-as-archived. It'd be nice to switch to that on the backend as well, but that'll require quite a lot of churn on the frontend as we'd need to change the API (or have an awkward translation layer, where we call it `trashed` on the backend, turn it into `archived` when sending data out via the API, and then the FE turns around and called it "trashed" again). For now, let's just be consistent on the backend and call it `archived` everywhere. So: - `archived_directly` instead of `trashed_directly`, and - `archive_operation_id` instead of `trash_operation_id` * Fix up a couple docstrings * Rename `visible-collection-ids` args for `collection/permissions-set->visible-collection-ids`: - `:include-archived` => `:include-archived-items` - `:include-trash?` => `:include-trash-collection` * select affected-collection-ids in the tx * Stop dealing with `:all` visible collection ids This used to be a possible return value for `permissions-set->visible-collection-ids` indicating that the user could view all collections. Now that function always returns a set of collection IDs (possibly including "root" for the root collection) so we don't need to deal with that anymore. * Don't use separate hydration keys for collections Dispatch on the model of each item (but still keep them in batches for efficiency.) * vars for collectable/archived-directly models * Round up loose `trashed_directly`s * Fix a test * Use `clojure.core.memoize` instead of handrolled It's slightly different (TTL instead of exactly per-request) but that should be fine. * FE lint fixes *
e2e test fix --------- Co-authored-by:Sloan Sparger <sloansparger@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Phoomparin Mano authored
* add option to customize dashcard border * use the shadow CSS variable Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * make the shadow and border decoration call more explicit Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * pass in theme as argument --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-